From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35383: 27.0.50; Complete process of decoding Gnus group names Date: Sun, 19 May 2019 02:03:28 +0100 Message-ID: <8736lbuufz.fsf@tcd.ie> References: <878sw1995f.fsf@ericabrahamsen.net> <87sgu87ayo.fsf@ericabrahamsen.net> <87woiuf6ya.fsf@ericabrahamsen.net> <87ef4v4iii.fsf@ericabrahamsen.net> <87r28v76pd.fsf@tcd.ie> <874l5r4a9w.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="171698"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Katsumi Yamaoka , 35383@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 19 03:07:58 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSAIw-000iYJ-Iq for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 May 2019 03:07:58 +0200 Original-Received: from localhost ([127.0.0.1]:40577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSAIv-0004eZ-Br for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 May 2019 21:07:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSAIj-0004bI-8j for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 21:07:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSAF8-0006t5-VX for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 21:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48094) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSAF8-0006sg-C0 for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 21:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hSAF7-0006ZZ-Vo for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 21:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 May 2019 01:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35383 X-GNU-PR-Package: emacs Original-Received: via spool by 35383-submit@debbugs.gnu.org id=B35383.155822781925233 (code B ref 35383); Sun, 19 May 2019 01:04:01 +0000 Original-Received: (at 35383) by debbugs.gnu.org; 19 May 2019 01:03:39 +0000 Original-Received: from localhost ([127.0.0.1]:33405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSAEl-0006Yv-28 for submit@debbugs.gnu.org; Sat, 18 May 2019 21:03:39 -0400 Original-Received: from mail-ed1-f67.google.com ([209.85.208.67]:37841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSAEi-0006Yi-W9 for 35383@debbugs.gnu.org; Sat, 18 May 2019 21:03:38 -0400 Original-Received: by mail-ed1-f67.google.com with SMTP id w37so17282700edw.4 for <35383@debbugs.gnu.org>; Sat, 18 May 2019 18:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iqE4OcmeG99C4rjOY9hR0ZkCu5rMVNSdD2p93TfXp+o=; b=hKTMTfZ12HuwZOwQ6Ay14bm3yCMjuQVUEfiCMkEDxPC7HW0MGlk8FhN2ZjVUTONQHz oc5Tv+yszwYVTLOLPCpHMvac6s0w9t+j6BV+8JqmFfgwfy/SCdOmNhAsw0yeav3xjeHk 8AUmv0uyu5fJX3uBO4EivEvEGjrLYgE38RIAAgmSYm/ns4ebLE0ZGUxRyckdbcMNFY1U sPtke/t1FelKqqS9Mc09SsIVsIaVnGbfhLhQI07yCpw5Jq7Seaz1v4QshugctRtl5YCh jlsNLQlFGKujP+c1KucqeuEiEAbT9Apq3RAK+eWjO1+tAYMDtEEIrGiq5mjjhijC/sio tXlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iqE4OcmeG99C4rjOY9hR0ZkCu5rMVNSdD2p93TfXp+o=; b=PUQoxgIuVnXkiD9VN8v5I7HVshQc05YAW9Z4J9/G2iAjiQZ+bUlxi9Z3Rdn9nQY3fN Q93Aa9JMsh//5Ftm3pgdbKqOan9sCyzbisGFBciw+f9tpQ5FNlHSad7QTsypMfOZMacA zRBy4RS1Wpu+3bigrfcm4OVbrlDUCBNdwBLmIUgRIkI1lxuUNH+9vhaegV7G3beJuZNp wI1w7k9OtN4A2JRd8yLmpoLEXamzb6QZwa1UhNzbg6PDoU0Cr6uGpcSTIY+sAy1A59gH 63zfQY7BboqfEZMI5GcEBfI3bm4Jhl748RRKCoA41jlIHYMPiUzqxDYzv7xqkJUgN5pT y7gg== X-Gm-Message-State: APjAAAU01CGrn+8fqHMe5v3Wf1/xllQ5ffgYRye7VsNaoimvtwWOfJ7n +HtBzhHWJcCIgOYsYx2LRXAqfQ== X-Google-Smtp-Source: APXvYqwUbsnDAfaDT5pq8OnkTIq/wuAgYInrc9Ofwoh8TZ6KajjeCtgmDtsgyrmKat1XUicTFBvS9A== X-Received: by 2002:a50:9987:: with SMTP id m7mr64669809edb.286.1558227811094; Sat, 18 May 2019 18:03:31 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id r3sm2403536ejb.88.2019.05.18.18.03.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 18 May 2019 18:03:30 -0700 (PDT) In-Reply-To: <874l5r4a9w.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 18 May 2019 16:23:39 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159519 Archived-At: Eric Abrahamsen writes: >> I noticed gnus-start.el (already) uses seq.el functions without first >> loading the library, so how about the following minor addendum? > > It does require gnus.el, though, which requires seq, so I figured that > was good enough -- no compiler warnings, anyway. I think it's customary (if not better) for each translation unit to load its own dependencies, without depending on dependencies to do so, but I don't know whether this falls in bikeshedding territory. >> (defun gnus-subscribe-alphabetically (newgroup) >> "Subscribe new NEWGROUP and insert it in alphabetical order." >> - (let ((groups (cdr gnus-group-list)) >> - before) >> - (while (and (not before) groups) >> - (if (string< newgroup (car groups)) >> - (setq before (car groups)) >> - (setq groups (cdr groups)))) >> + (let ((before (seq-find (lambda (group) >> + (string< newgroup group)) >> + (cdr gnus-group-list)))) >> (gnus-subscribe-newsgroup newgroup before))) > > Looks fine to me! I'll just add this to the patch? Yes please, thanks, -- Basil