From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 35737@debbugs.gnu.org
Subject: bug#35737: xref--original-command
Date: Mon, 27 May 2019 22:59:37 +0300 [thread overview]
Message-ID: <8736kzekie.fsf@mail.linkov.net> (raw)
In-Reply-To: <c02b7797-7511-5722-528b-62a320c00b4e@yandex.ru> (Dmitry Gutov's message of "Sat, 25 May 2019 01:48:28 +0300")
>> Thanks, I tried xref revert and it works fine.
>> Also I agree with Eli regarding the command name,
>> documentation and NEWS.
>
> Should be good now.
Thanks. I wonder why you renamed xref--revert-xref-buffer
to a such strange name xref-refresh-results? Why not simply
xref-revert-buffer?
>> But I don't want to write a new function. I just need to check
>> if the xref buffer was created by a particular command.
>
> I think you need to make a choice here.
>
> Do you want to customize your personal Emacs, or do you want to improve the
> default behavior?
>
> If it's the former, I think the advice you posted will work as well as any
> other solution.
>
> I was kind of expecting the latter.
The goal was to improve the default behavior to make customization easier.
>> If despite a chain of indirections, xref still can't distinguish
>> different commands that created the xref buffer, I'd rather close
>> this feature request and use 'advice-add' in customization.
>
> Do we really need to be able to distinguish between xref-find-references
> and project-find-regexp as well?
>
> TBH, xref--original-command is easy to add, but then we'll have an internal
> variable that isn't used anywhere. Somebody will just delete it someday.
The idea was to make xref more customizable differently for different
commands: xref-find-definitions, xref-find-references, project-find-regexp.
next prev parent reply other threads:[~2019-05-27 19:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 20:53 bug#35737: xref--original-command Juri Linkov
2019-05-15 1:07 ` Dmitry Gutov
2019-05-15 21:04 ` Juri Linkov
2019-05-15 22:30 ` Dmitry Gutov
2019-05-16 19:58 ` Juri Linkov
2019-05-24 1:59 ` Dmitry Gutov
2019-05-24 18:40 ` Juri Linkov
2019-05-24 22:48 ` Dmitry Gutov
2019-05-27 19:59 ` Juri Linkov [this message]
2019-05-27 21:13 ` Dmitry Gutov
2019-05-27 23:21 ` Dmitry Gutov
2019-05-28 2:41 ` Eli Zaretskii
2019-05-28 7:46 ` Dmitry Gutov
2019-05-28 15:01 ` Eli Zaretskii
2019-05-28 20:30 ` Juri Linkov
2019-05-30 17:33 ` Dmitry Gutov
2019-06-09 23:44 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736kzekie.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=35737@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).