From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Philipp Stephani <p.stephani2@gmail.com>, 30205@debbugs.gnu.org
Subject: bug#30205: 27.0.50; Minor mode commands enable the minor mode even if the body fails
Date: Fri, 19 Jul 2019 15:25:16 +0200 [thread overview]
Message-ID: <8736j288cj.fsf@mouse.gnus.org> (raw)
In-Reply-To: <87lfwvyqbo.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 18 Jul 2019 22:40:11 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Unless we can provide a way to roll back the entire mode function
> "transaction", I would regard errors in mode functions as UB and the
> real bug here. In other words, I don't see any benefit to using the
> mode variable as an indicator of success, when mode functions shouldn't
> fail to begin with.
I agree, and am closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-07-19 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 9:54 bug#30205: 27.0.50; Minor mode commands enable the minor mode even if the body fails Philipp Stephani
2019-07-14 17:40 ` Lars Ingebrigtsen
2019-07-18 21:40 ` Basil L. Contovounesios
2019-07-19 13:25 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736j288cj.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=30205@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).