From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#26328: 26.0.50; checkdoc action for join lines drops final " Date: Sun, 28 Jul 2019 10:05:53 -0400 Message-ID: <8736iquuda.fsf@gmail.com> References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="113476"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: Marco Wahl , 26328@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 16:07:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrjpO-000TJU-Et for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 16:07:11 +0200 Original-Received: from localhost ([::1]:45398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrjpM-00081i-Rj for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 10:07:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40941) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrjpH-00081c-HT for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrjpG-0008Qm-Gc for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38105) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrjpG-0008Q7-A5 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrjpG-0007Zu-2I for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 26328-submit@debbugs.gnu.org id=B26328.156432276229053 (code B ref 26328); Sun, 28 Jul 2019 14:07:02 +0000 Original-Received: (at 26328) by debbugs.gnu.org; 28 Jul 2019 14:06:02 +0000 Original-Received: from localhost ([127.0.0.1]:46926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrjoH-0007YM-IQ for submit@debbugs.gnu.org; Sun, 28 Jul 2019 10:06:01 -0400 Original-Received: from mail-io1-f43.google.com ([209.85.166.43]:44360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrjoG-0007Y5-5s for 26328@debbugs.gnu.org; Sun, 28 Jul 2019 10:06:00 -0400 Original-Received: by mail-io1-f43.google.com with SMTP id s7so114357537iob.11 for <26328@debbugs.gnu.org>; Sun, 28 Jul 2019 07:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LweKmrTtSkmnucwTu3ybDQRN0hobgV4BfmQapm7S700=; b=IakVAGZBWlOtp14ysWjq78MLCdzoroZaVHZBeuSKyFdeicCvrymQnBottXqihHArDC rTwwguY2+7iEMWzmb2xF1MhczYcpXI8R5D7ksV81M8cxbQobutMKHUzmC+zMwSTi6Ldb uNZTP4V4vfGnpkyCWCTQuFO/B9OOi3zawyjCQKexUFbisDZo/iEaRHnyhdmdQJusZ8/c Fz6HZkQAtxkwljepXmhnn6S6pu4oCll/GGBbVfzPEPUguuOg/fd/VB5VdCtMqyZ6eP25 dK7Fxp2FkmFw7j9J0DMpGUEB/yDtZFFBKY4tn8F1txoepH6TtTYWC031lzdUpks4c4kL YBqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LweKmrTtSkmnucwTu3ybDQRN0hobgV4BfmQapm7S700=; b=r6PLO94EX6LFhlLqlX/ilMA6pdI8cVEVlpSQWuAkhDffrJoNBll/8gCpyN112OLTyz NeOBYPTP+BJHpM4eovIHi23EFfwk1Rx+JbAlkFiWuIvX6Gfu1ZUsKwwiOZmWiOLnzHVZ KIM9MrLSr6ssLiWcs7608/xmgFlMkWzutnm16xwFjr6m6haCfJqB6a/UFL0c+0tFk+Z8 cIPpISAEhg6vdzul6QUUCkYMKt26yK6zJhampYabbQImnBVogolg0Y6T3xvtrT7WHntA vjioaiCn3guym7HWqXDOqJatMpX7NtKVfNu+G9ivJJLrh9bXbTxpe6IDgio9tqXZRDKi bUjw== X-Gm-Message-State: APjAAAWCwHQMJYcp82N6LMQyKvZHXk0qIqEGo4PR0i/q+Wgv3oll58vQ uAaNsh4v9A4amfQogZi2g5MjHDpV X-Google-Smtp-Source: APXvYqzYLiD/6zJxS6jTL9EHNHo07UhJlaNLKatmXo0qcQcUxhH8QvQ7dByi/j+AgiZfyWer6PmOLg== X-Received: by 2002:a02:b883:: with SMTP id p3mr35493958jam.79.1564322754493; Sun, 28 Jul 2019 07:05:54 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id x22sm44121782iob.84.2019.07.28.07.05.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jul 2019 07:05:53 -0700 (PDT) In-Reply-To: <878sslnk5w.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 26 Jul 2019 12:51:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163958 Archived-At: >> Suggestion for a fix: >> >> modified lisp/emacs-lisp/checkdoc.el >> @@ -1520,7 +1520,7 @@ checkdoc-this-string-valid-engine >> ;; They said yes. We have more fill work to do... >> (goto-char (match-beginning 1)) >> (delete-region (point) (match-end 1)) >> - (insert "\n") >> + (insert "\"") >> (setq msg nil)))))) >> (if msg >> (checkdoc-create-error msg s (save-excursion > > The " at the end of the doc string is removed by that `delete-region', > so it's all a bit confusing. The following patch also fixes the problem > in this example, but I'm not quite sure what the code is attempting to > do here. > > Anybody familiar with this code? > > diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el > index 830743f5f8..7ac557711a 100644 > --- a/lisp/emacs-lisp/checkdoc.el > +++ b/lisp/emacs-lisp/checkdoc.el > @@ -1498,12 +1498,7 @@ checkdoc-this-string-valid-engine > p (1+ p) > "1st line not a complete sentence. Join these lines? " > " " t) > - (progn > - ;; They said yes. We have more fill work to do... > - (goto-char (match-beginning 1)) > - (delete-region (point) (match-end 1)) > - (insert "\n") > - (setq msg nil)))))) > + (setq msg nil))))) > (if msg > (checkdoc-create-error msg s (save-excursion > (goto-char s) AFAICT, both proposed patches will do the wrong thing for this case: (defun foo () "Bla bla bla bla. More words bla bla bla.")