From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line Date: Wed, 14 Aug 2019 10:16:52 -0500 Message-ID: <8736i3hj4r.fsf@gmail.com> References: <87r3gcmyfc.fsf@riseup.net> <871sfh4o92.fsf@mouse.gnus.org> <87h8ocei9c.fsf@mouse.gnus.org> <87imr0u7dc.fsf@gmail.com> <877e7gvhpq.fsf@mouse.gnus.org> <875zn0r9x4.fsf@gmail.com> <874l2kio0r.fsf@gmail.com> <837e7gsc3q.fsf@gnu.org> <87ftm36enn.fsf@gmail.com> <851rxn3ie2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26687"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 22700@debbugs.gnu.org, larsi@gnus.org, monnier@IRO.UMontreal.CA To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 14 17:17:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hxv1W-0006no-BU for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Aug 2019 17:17:14 +0200 Original-Received: from localhost ([::1]:33308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxv1V-00040V-0x for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Aug 2019 11:17:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39320) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxv1L-0003ys-Vc for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 11:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxv1L-0005Jt-0V for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 11:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hxv1K-0005Jo-T5 for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 11:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hxv1J-0007Ul-WA for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 11:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Aug 2019 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 22700-submit@debbugs.gnu.org id=B22700.156579582028799 (code B ref 22700); Wed, 14 Aug 2019 15:17:01 +0000 Original-Received: (at 22700) by debbugs.gnu.org; 14 Aug 2019 15:17:00 +0000 Original-Received: from localhost ([127.0.0.1]:49589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxv1I-0007UR-E6 for submit@debbugs.gnu.org; Wed, 14 Aug 2019 11:17:00 -0400 Original-Received: from mail-oi1-f169.google.com ([209.85.167.169]:41218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxv1G-0007UE-Up for 22700@debbugs.gnu.org; Wed, 14 Aug 2019 11:16:59 -0400 Original-Received: by mail-oi1-f169.google.com with SMTP id g7so73352971oia.8 for <22700@debbugs.gnu.org>; Wed, 14 Aug 2019 08:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2aJ8/BroTQuT74iHOfjK64lr6OzvUHfwBFVXsChR1h4=; b=hw4TnRpII22z6EwaasqMYVa5uKEGaTmOmKduKpP7LmEnrzaSY0mDemSxqxS81DIlne CWlNENiMAzeDB0mF1XBleCcJNOufNHWhFGQnzsaJfRpRa1cGl5JjV5znq5ioQP79C1Wt /+6lMRzMiw9ISYb+zHxm3nTQ5biHnaO59H8mEO4JQ5yapRb4/lsI+umAu30aMvyAyhjk rOKKWwAcXpZU/eeaa1L9u0qlvfvdQ3rM6hdKOJVCAsYcD+NlC/V+HTmos6zkbe/Dd09c 9yBXqHsbaXiWC26pD2VPKOABlcYrLqLRZKQ1gb20q+ekmUiyyEBZrVDVIemsNkPyIPtr lbNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2aJ8/BroTQuT74iHOfjK64lr6OzvUHfwBFVXsChR1h4=; b=fPVF1WQgw43Bd2bZj3CgYjK6DgyNT8cOPdjAT0Xb7RdPYlGEcT1seXvDn834ktZnba tB9r5Y8BhlfkhwEA8jy6iplG0mSdLXYWlUU781uPdAuF+s8zcp13nis5kLT69QgK8JQn EcDGShmbTVukjxs0BKES4LGlzpJ+BTDnXWz97qiuPcGS8uI//gAj3pgV3GfVhf4g2Dcs OoUzTkqfXtU3pQr0+lAkFx6GLHjWkdlaIVuTCLZ50aMsr+tloLC/Poh4D3ZgWoxqfhcc uMtaXgbkDouuQTTP/vjm6GXToOWxbaSBaNZYJr9f5rRR7X9NcyQwy6c57z/BbBK6g9rU I4Sg== X-Gm-Message-State: APjAAAW8pRHT5mht5ctUlKkq0ExCeZi2Z81wYTHIaDHz6QL159n1OaDG HmybXUfz38lfa8mPCX2rC/E= X-Google-Smtp-Source: APXvYqzMW0PKfdVlN5fj1RFa2A373zbM4feBtozGmSamYSUEskcV2G9Cx5woY3cu1TqMnhbCkfM2jg== X-Received: by 2002:a05:6808:3d5:: with SMTP id o21mr297968oie.108.1565795813170; Wed, 14 Aug 2019 08:16:53 -0700 (PDT) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id k12sm64006oij.21.2019.08.14.08.16.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 08:16:52 -0700 (PDT) In-Reply-To: <851rxn3ie2.fsf@gmail.com> (Noam Postavsky's message of "Wed, 14 Aug 2019 10:56:37 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164979 Archived-At: On Wed 14 Aug 2019 at 10:56, Noam Postavsky wrote: >> + (when erc-echo-timestamps >> + (when-let ((stamp (get-text-property (point) 'timestamp)) >> + (message (format-time-string erc-echo-timestamp-format stamp))) >> + (unless (string= message (current-message)) >> + (message "%s" message))))) > > I'm not an erc user, so perhaps it's just expected to be this way, but > this sounds too aggressive to me. E.g., if you run a command like > describe-key-briefly its message will immediately be replaced by the > timestamp. Most of the time we won't be echoing a timestamp since point will be in the same line as the prompt (i.e. the area where you compose a message). > I was thinking erc-echo-timestamp would just save the last timestamp it > sent in a buffer-local variable, and then only send a new message if the > current timestamp is different. That's certainly possible to do as well. If others prefer that, I can write that version up. Alex