From: Alex Branham <alex.branham@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 22700@debbugs.gnu.org, larsi@gnus.org, monnier@IRO.UMontreal.CA
Subject: bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line
Date: Wed, 14 Aug 2019 10:16:52 -0500 [thread overview]
Message-ID: <8736i3hj4r.fsf@gmail.com> (raw)
In-Reply-To: <851rxn3ie2.fsf@gmail.com> (Noam Postavsky's message of "Wed, 14 Aug 2019 10:56:37 -0400")
On Wed 14 Aug 2019 at 10:56, Noam Postavsky <npostavs@gmail.com> wrote:
>> + (when erc-echo-timestamps
>> + (when-let ((stamp (get-text-property (point) 'timestamp))
>> + (message (format-time-string erc-echo-timestamp-format stamp)))
>> + (unless (string= message (current-message))
>> + (message "%s" message)))))
>
> I'm not an erc user, so perhaps it's just expected to be this way, but
> this sounds too aggressive to me. E.g., if you run a command like
> describe-key-briefly its message will immediately be replaced by the
> timestamp.
Most of the time we won't be echoing a timestamp since point will be in
the same line as the prompt (i.e. the area where you compose a message).
> I was thinking erc-echo-timestamp would just save the last timestamp it
> sent in a buffer-local variable, and then only send a new message if the
> current timestamp is different.
That's certainly possible to do as well. If others prefer that, I can
write that version up.
Alex
next prev parent reply other threads:[~2019-08-14 15:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 16:07 bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line William G. Gardella
2018-04-14 18:49 ` Lars Ingebrigtsen
2018-04-15 0:06 ` Stefan Monnier
2018-04-15 13:01 ` Lars Ingebrigtsen
2019-08-13 20:40 ` Alex Branham
2019-08-13 22:11 ` Lars Ingebrigtsen
2019-08-13 22:13 ` Noam Postavsky
2019-08-14 0:33 ` Alex Branham
2019-08-14 2:40 ` Eli Zaretskii
2019-08-14 13:49 ` Alex Branham
2019-08-14 14:39 ` Eli Zaretskii
2019-08-14 14:56 ` Noam Postavsky
2019-08-14 15:16 ` Alex Branham [this message]
2019-08-14 22:50 ` Stefan Monnier
2019-08-15 14:27 ` Alex Branham
2019-08-15 23:41 ` Lars Ingebrigtsen
2019-08-16 13:25 ` Alex Branham
2019-08-19 9:46 ` Stefan Monnier
2019-08-27 15:08 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736i3hj4r.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=22700@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).