From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file Date: Tue, 27 Aug 2019 11:15:29 +0200 Message-ID: <8736hn2clq.fsf@gnus.org> References: <87a7ic9due.fsf@gnu.org> <87muhnrwvs.fsf@mouse.gnus.org> <875zmk5r5u.fsf@gnus.org> <83sgpofjc9.fsf@gnu.org> <87k1b04a3x.fsf@gnus.org> <83pnksfel0.fsf@gnu.org> <87v9uj2i7l.fsf@gnus.org> <83mufvdomu.fsf@gnu.org> <87ftln2f0f.fsf@gnus.org> <83imqjdmqb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="128152"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34720@debbugs.gnu.org, dunni@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 27 11:16:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2XaL-000X5T-01 for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 11:16:17 +0200 Original-Received: from localhost ([::1]:48640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2XaJ-0001fu-6v for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 05:16:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44341) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2Xa7-0001dt-MN for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:16:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2Xa6-0007Z4-G2 for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38872) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2Xa6-0007Z0-Cx for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2Xa6-0000gs-7T for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2019 09:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34720-submit@debbugs.gnu.org id=B34720.15668973362617 (code B ref 34720); Tue, 27 Aug 2019 09:16:02 +0000 Original-Received: (at 34720) by debbugs.gnu.org; 27 Aug 2019 09:15:36 +0000 Original-Received: from localhost ([127.0.0.1]:47693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2XZg-0000g9-Dx for submit@debbugs.gnu.org; Tue, 27 Aug 2019 05:15:36 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:39402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2XZe-0000fz-9w for 34720@debbugs.gnu.org; Tue, 27 Aug 2019 05:15:34 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2XZa-0007Rw-4Z; Tue, 27 Aug 2019 11:15:32 +0200 In-Reply-To: <83imqjdmqb.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Aug 2019 11:41:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165950 Archived-At: Eli Zaretskii writes: > No, it restores only the window-point marker in each window that shows > the same buffer. See get_window_points_and_markers, which collects > those markers. Oh, oh, you're totally right, of course -- that function only collects the point markers. The reason the other markers magically survive Finsert_file_contents is because that function takes care not to replace any text in the buffer that's identical to the text already there? So the text isn't deleted, the markers stay where they are, and everything works nice. So the fix here is to make epa follow the same logic, perhaps? That is, first get the text we're supposed to insert, then compare with the data in the buffer, and only start replacing at the point where we find the first difference? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no