From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34720@debbugs.gnu.org, dunni@gnu.org
Subject: bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file
Date: Tue, 27 Aug 2019 11:15:29 +0200 [thread overview]
Message-ID: <8736hn2clq.fsf@gnus.org> (raw)
In-Reply-To: <83imqjdmqb.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Aug 2019 11:41:16 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> No, it restores only the window-point marker in each window that shows
> the same buffer. See get_window_points_and_markers, which collects
> those markers.
Oh, oh, you're totally right, of course -- that function only collects
the point markers.
The reason the other markers magically survive Finsert_file_contents is
because that function takes care not to replace any text in the buffer
that's identical to the text already there? So the text isn't deleted,
the markers stay where they are, and everything works nice.
So the fix here is to make epa follow the same logic, perhaps? That is,
first get the text we're supposed to insert, then compare with the data
in the buffer, and only start replacing at the point where we find the
first difference?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-27 9:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 15:28 bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file Ian Dunn
2019-07-09 16:33 ` Lars Ingebrigtsen
2019-08-26 7:20 ` Lars Ingebrigtsen
2019-08-26 7:59 ` Eli Zaretskii
2019-08-26 8:14 ` Lars Ingebrigtsen
2019-08-26 9:42 ` Eli Zaretskii
2019-08-27 7:14 ` Lars Ingebrigtsen
2019-08-27 8:00 ` Eli Zaretskii
2019-08-27 8:23 ` Lars Ingebrigtsen
2019-08-27 8:41 ` Eli Zaretskii
2019-08-27 9:05 ` Lars Ingebrigtsen
2019-08-27 9:17 ` Eli Zaretskii
2019-08-27 9:15 ` Lars Ingebrigtsen [this message]
2019-08-27 10:20 ` Eli Zaretskii
2019-08-30 9:48 ` Lars Ingebrigtsen
2019-08-30 10:21 ` Lars Ingebrigtsen
2019-08-30 12:19 ` Eli Zaretskii
2019-08-27 8:37 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736hn2clq.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=34720@debbugs.gnu.org \
--cc=dunni@gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).