From: Lars Ingebrigtsen <larsi@gnus.org>
To: Sergey Organov <sorganov@gmail.com>
Cc: 37901@debbugs.gnu.org
Subject: bug#37901: 24.4; GNUS: gnus-group-customize breaks posting-style encoding
Date: Mon, 28 Oct 2019 15:13:00 +0100 [thread overview]
Message-ID: <8736fdargz.fsf@gnus.org> (raw)
In-Reply-To: <87o8y6l6lg.fsf@osv.gnss.ru> (Sergey Organov's message of "Thu, 24 Oct 2019 14:34:51 +0300")
Sergey Organov <sorganov@gmail.com> writes:
> Even though I report this for emacs 24.4, the code that is suspect[1] is
> still there in git:master:b3b7451, so it's likely the bug is not yet
> fixed.
Yup, I'm still seeing this in Emacs 27.
> [1] The suspect code is:
>
> ;; Encode values posting-style holds.
> (dolist (style (cdr (assq 'posting-style params)))
> (when (stringp (cadr style))
> (setcdr style (list (encode-coding-string (cadr style) 'utf-8)))))
>
> in gnus-group-customize-done, and it has matching chunk:
>
> ;; Decode values posting-style holds.
> (dolist (style (cdr (assq 'posting-style values)))
> (when (stringp (cadr style))
> (setcdr style (list (decode-coding-string (cadr style) 'utf-8)))))
>
> in gnus-group-customize, though the latter seems to be harmless.
Thanks for tracking down the error. Removing the code in [1] indeed
fixes the problem (I think it was necessary before when the .newsrc.eld
file wasn't utf-8, but now it's an error. And I removed the latter
chunk, too.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-10-28 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 11:34 bug#37901: 24.4; GNUS: gnus-group-customize breaks posting-style encoding Sergey Organov
2019-10-28 14:13 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736fdargz.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=37901@debbugs.gnu.org \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).