From: Stefan Kangas <stefan@marxist.se>
To: 37891@debbugs.gnu.org
Subject: bug#37891: [PATCH] Clean up error on wrong major mode in package-menu-mode
Date: Thu, 07 Nov 2019 04:14:42 +0100 [thread overview]
Message-ID: <8736f01iot.fsf@marxist.se> (raw)
In-Reply-To: <CADwFkm=djsk5WQpsGz8ciCmsYHtM1XGe9AG2mS-MNBiEj-zqRQ@mail.gmail.com> (Stefan Kangas's message of "Wed, 23 Oct 2019 18:09:21 +0200")
close 37891 27.1
thanks
Stefan Kangas <stefan@marxist.se> writes:
> Four package-menu-mode specific commands currently signal an error if
> called when not in package-menu-mode. One of them uses 'user-error',
> the others 'error'. All other commands don't signal an error.
>
> The attached patch makes the behaviour more consistent by:
> 1) Factoring out the error signalling into a new function to make it
> more consistent.
> 2) Calling this function in all other relevant package-mode-menu commands.
>
> Any comments?
No comments in 14 days; now pushed to master as commit ddb797cf4c.
Best regards,
Stefan Kangas
prev parent reply other threads:[~2019-11-07 3:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:09 bug#37891: [PATCH] Clean up error on wrong major mode in package-menu-mode Stefan Kangas
2019-11-07 3:14 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736f01iot.fsf@marxist.se \
--to=stefan@marxist.se \
--cc=37891@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).