From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#40693: 28.0.50; json-encode-alist changes alist Date: Thu, 21 May 2020 22:14:20 +0100 Message-ID: <87367t9ej7.fsf@tcd.ie> References: <87a738jotd.fsf@tcd.ie> <87mu6utxd1.fsf@tcd.ie> <83r1w6ziql.fsf@gnu.org> <82572c3f-fb24-0b01-06ec-47067d9219ca@yandex.ru> <83blnazdly.fsf@gnu.org> <87wo5yqrqo.fsf@tcd.ie> <87ftbyavbq.fsf@tcd.ie> <87zha43ira.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97451"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: darthandrus@gmail.com, 40693@debbugs.gnu.org, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 21 23:15:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbsX5-000P9R-SK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 May 2020 23:15:16 +0200 Original-Received: from localhost ([::1]:39720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbsX4-0004zj-HM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 May 2020 17:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbsWs-0004rW-Gu for bug-gnu-emacs@gnu.org; Thu, 21 May 2020 17:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45898) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbsWs-0006Uz-7A for bug-gnu-emacs@gnu.org; Thu, 21 May 2020 17:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbsWs-0007RN-1n for bug-gnu-emacs@gnu.org; Thu, 21 May 2020 17:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 May 2020 21:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40693 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40693-submit@debbugs.gnu.org id=B40693.159009567028551 (code B ref 40693); Thu, 21 May 2020 21:15:01 +0000 Original-Received: (at 40693) by debbugs.gnu.org; 21 May 2020 21:14:30 +0000 Original-Received: from localhost ([127.0.0.1]:57444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbsWM-0007QQ-6h for submit@debbugs.gnu.org; Thu, 21 May 2020 17:14:30 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:54388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbsWK-0007QD-Ow for 40693@debbugs.gnu.org; Thu, 21 May 2020 17:14:29 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id h4so6776418wmb.4 for <40693@debbugs.gnu.org>; Thu, 21 May 2020 14:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Oromm7gfRpmw6Tb9OK/so9HXWFnrcf87EbCpXKWciuk=; b=Hvwke2W2TcyaWfWWVwlctP+F/OC0mm9+B3xaIhdJdVRtcqUAwvLswt5VTzg5h3eMb6 tHQ4gtF1EYyKgWHWpeioY9WVRIcttZFY83IGPpuro8n/9sYdAbOEXPUNhxkPFYFTgQ9W i299NR25SJvO86HkuD8tsrGvuIaXNQH70heQ7BHhQQp+1SoLv5sIumb2VUS7VNb+mT47 +k4GDJcOCesXNaK+M4NACyfr2tHvP2SRFGt1PdwsBVUZKQsqi32cXmatEmRXkbZyicH1 37WHpeMdRlVZVcYqoCpqBX78XlI1hnDcvOyk2Wb/lu6W4/pxRXsf8re/hA/pOX6dJ5mt lv1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Oromm7gfRpmw6Tb9OK/so9HXWFnrcf87EbCpXKWciuk=; b=pXd4GpN2jpYdxaFtB1gxZxQhpD3Fskf7kowakyume9kKeeusUCAzmlIvQF78crHqEz TsX/VCYHJzTBOe1PBEKZwrGFxgxniRzJgzBvW1j0CNV3lrf2kvrmNDDfNLpyaAxElAmO fyuNq4ML1s6Wn5/j3/A5DkAbmPI6yDEa9+/1bHOcU3I14Rz5wB/idHZl2hYDp2b5TFk2 jTwY+rGwnFMgyhuRkd64nIAy7AUfQvhMs/Hmnf3xOP0PQeM/43v3CredTnCQjr+aTiQi FMTEbKShZqmGvvOmy14GBHK7Jh1W4EB9j0wgEL1VsHz3tprytPIbipIM3MTzGo9QNjr9 0mOw== X-Gm-Message-State: AOAM532N2oBUuPT1LFFp9wGqNUjhhCXd97fC/LD7qrShqHLZeeL6vemh LxL/tepObpuKEVqkeVtXJAEofw== X-Google-Smtp-Source: ABdhPJwlqWHJ7NnNjkxDskzUeMHWXNksX+4GGrDR0N7RPJB/u+FT93fA7gMDjIlp7YB1ecLj/CJNWQ== X-Received: by 2002:a1c:6506:: with SMTP id z6mr10917977wmb.104.1590095662742; Thu, 21 May 2020 14:14:22 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id y5sm2499397wrs.63.2020.05.21.14.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 14:14:22 -0700 (PDT) In-Reply-To: <87zha43ira.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 19 May 2020 00:50:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180721 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > "Basil L. Contovounesios" writes: > >> * lisp/jsonrpc.el (jsonrpc--json-read, jsonrpc--json-encode): Check >> whether native JSON functions are fboundp only once, at load time. > > I welcome this small improvement: in fact I had a TODO there to make > something similar. In the TODO i suggested the jsonrpc--json-read could > be a macro. You used `defalias` instead and that's fine. Thanks. Indeed I don't think a macro is necessary here for now. > However, I don't understand the need for the ugly (require 'json), > defvar and declare-function there. Can't we just use sth like > `eval-and-compile` at the top of the file? The declarations are needed because the byte-compiler does not know that loading json.el will e.g. define a dynamically bound variable json-object-type and a nullary function symbol json-read. It therefore not only complains but also generates invalid byte-code. One way to avoid having to write these declarations is e.g.: (defalias 'jsonrpc--json-read (if (fboundp 'json-parse-buffer) (lambda () ...) (eval-and-compile (require 'json)) (lambda () ...)) ...) But I find this more heavy handed and intrusive, since it unconditionally loads json.el during byte-compilation, even when json-parse-buffer is available. If you prefer this approach as a matter of style I'll push the patch with the corresponding changes made. >> -(defun jsonrpc--json-read () >> - "Read JSON object in buffer, move point to end of buffer." >> - ;; TODO: I guess we can make these macros if/when jsonrpc.el >> - ;; goes into Emacs core. >> - (cond ((fboundp 'json-parse-buffer) (json-parse-buffer >> - :object-type 'plist >> - :null-object nil >> - :false-object :json-false)) >> - (t (let ((json-object-type 'plist)) >> - (json-read))))) >> +(defalias 'jsonrpc--json-read >> + (if (fboundp 'json-parse-buffer) >> + (lambda () >> + (json-parse-buffer :object-type 'plist >> + :null-object nil >> + :false-object :json-false)) >> + (require 'json) >> + (defvar json-object-type) >> + (declare-function json-read "json" ()) >> + (lambda () >> + (let ((json-object-type 'plist)) >> + (json-read)))) >> + "Read JSON object in buffer, move point to end of buffer.") Thanks, --=20 Basil