unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Kim <emacs18@gmail.com>
To: 41888@debbugs.gnu.org
Subject: bug#41888: 27.0.91; fix ACTION argument of display-buffer
Date: Mon, 15 Jun 2020 23:30:08 -0700	[thread overview]
Message-ID: <87366vv7yn.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]


gud-common-init function in emacs 27 seems to have a bug in how it calls
display-buffer. The second argument passed is ACTION. According to
docstring of display-buffer, the list of functions need to be a list
within a list. The attached patch adds the missing extra pair of
parenthesis.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix one display-buffer call --]
[-- Type: text/x-diff, Size: 1111 bytes --]

From f89f87c6997fe26b4d8859dafd85c886c753a5c6 Mon Sep 17 00:00:00 2001
From: Richard Kim <emacs18@gmail.com>
Date: Mon, 15 Jun 2020 23:20:57 -0700
Subject: [PATCH] fixed ACTION argument of display-buffer call

---
 lisp/progmodes/gud.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
index d5fd1dce6f..540bc9ce7f 100644
--- a/lisp/progmodes/gud.el
+++ b/lisp/progmodes/gud.el
@@ -2621,9 +2621,9 @@ comint mode, which see."
     (select-window
      (display-buffer
       (get-buffer-create (concat "*gud" filepart "*"))
-      '(display-buffer-reuse-window
-        display-buffer-in-previous-window
-        display-buffer-same-window display-buffer-pop-up-window)))
+      '((display-buffer-reuse-window
+         display-buffer-in-previous-window
+         display-buffer-same-window display-buffer-pop-up-window))))
     (when (and existing-buffer (get-buffer-process existing-buffer))
       (error "This program is already being debugged"))
     ;; Set the dir, in case the buffer already existed with a different dir.
-- 
2.25.1


[-- Attachment #3: Type: text/plain, Size: 1140 bytes --]


In GNU Emacs 27.0.91 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.18)
 of 2020-06-12 built on kimr-laptop
Repository revision: 22f4fba8a903874ba63f8f479fa40b1dfe12850f
Repository branch: emacs-27
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Ubuntu 20.04 LTS

Recent messages:
Saving file /home/kimr/repos/e/emacs/lisp/progmodes/gud.el...
Wrote /home/kimr/repos/e/emacs/lisp/progmodes/gud.el
~/repos/e/emacs/lisp/progmodes 
Quit
Mark set [2 times]
Using try-expand-line
No further expansions found
No expansion found [5 times]
Quit
Mark set [5 times]

Configured using:
 'configure '--program-transform-name=s/^ctags$/ctags.emacs/'
 --with-file-notification=yes --with-imagemagick --with-modules
 --with-pdumper=yes --with-sound=yes --with-x-toolkit=yes --with-xml2
 --without-compress-install --with-gif=no --prefix
 /home/kimr/opt/emacs27/20200612 CFLAGS=-O3'

Configured features:
XPM JPEG TIFF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS GLIB NOTIFY
INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER LCMS2 GMP


             reply	other threads:[~2020-06-16  6:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16  6:30 Richard Kim [this message]
2020-06-20 14:57 ` bug#41888: further explanation of the patch against gud.el Richard Kim
2020-06-27  7:41 ` bug#41888: 27.0.91; fix ACTION argument of display-buffer Eli Zaretskii
2020-06-28  6:37   ` martin rudalics
2020-06-28 14:06     ` Eli Zaretskii
2020-06-28  2:41 ` bug#41888: gdb does not work with spacemacs on emacs 27 Richard Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87366vv7yn.fsf@gmail.com \
    --to=emacs18@gmail.com \
    --cc=41888@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).