From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) Date: Mon, 07 Sep 2020 21:46:11 +0300 Organization: LINKOV.NET Message-ID: <87363tbe58.fsf@mail.linkov.net> References: <871ui48di4.fsf@mail.jurta.org> <878se2aox0.fsf@gnus.org> <87imd669dh.fsf@gnus.org> <875z961u2l.fsf@mail.linkov.net> <871rjt1uc1.fsf@gnus.org> <878se0gc25.fsf@mail.linkov.net> <87imd2vp1k.fsf@gnus.org> <87sgbv7xtn.fsf@gnus.org> <877dt6er29.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6445"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 12443@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 21:09:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFMVq-0001ae-CY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 21:09:10 +0200 Original-Received: from localhost ([::1]:33424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFMVp-0001uI-E6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 15:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFMVi-0001tw-TG for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 15:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFMVi-0001Zr-Kv for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 15:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFMVi-000597-Ey for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 15:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Sep 2020 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12443 X-GNU-PR-Package: emacs Original-Received: via spool by 12443-submit@debbugs.gnu.org id=B12443.159950569919733 (code B ref 12443); Mon, 07 Sep 2020 19:09:02 +0000 Original-Received: (at 12443) by debbugs.gnu.org; 7 Sep 2020 19:08:19 +0000 Original-Received: from localhost ([127.0.0.1]:50880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFMV1-00058D-91 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 15:08:19 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:58559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFMUy-00057w-7c for 12443@debbugs.gnu.org; Mon, 07 Sep 2020 15:08:17 -0400 X-Originating-IP: 91.129.97.241 Original-Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 7A3E320007; Mon, 7 Sep 2020 19:08:07 +0000 (UTC) In-Reply-To: <877dt6er29.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Sep 2020 19:46:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187471 Archived-At: > The next step here is probably to fix the cases where there's a default, > but where the prompt doesn't mention them. Like: Are you sure about this change in 1921d2176b? diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index d8f932e7a4..56c936e773 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1028,7 +1028,7 @@ tab-bar-rename-tab (tab-index (or current-prefix-arg (1+ (tab-bar--current-tab-index tabs)))) (tab-name (alist-get 'name (nth (1- tab-index) tabs)))) (list (read-from-minibuffer - "New name for tab (leave blank for automatic naming): " + (format-prompt "New name for tab" tab-name) nil nil nil nil tab-name) current-prefix-arg))) (let* ((tabs (funcall tab-bar-tabs-function)) @@ -1057,7 +1057,7 @@ tab-bar-rename-tab-by-name (alist-get 'name tab)) (funcall tab-bar-tabs-function))))) (list tab-name (read-from-minibuffer - "New name for tab (leave blank for automatic naming): " + (format-prompt "New name for tab" tab-name) nil nil nil nil tab-name)))) (tab-bar-rename-tab new-name (1+ (tab-bar--tab-index-by-name tab-name)))) I'm not the author of this code, so I don't know how it should work, but the old prompt with text "leave blank for automatic naming" makes sense to me.