unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Amin Bandali <bandali@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43299@debbugs.gnu.org
Subject: bug#43299: 28.0.50; message-newline-and-reformat does not insert space after citation prefix
Date: Thu, 10 Sep 2020 17:45:38 -0400	[thread overview]
Message-ID: <87363ppapp.fsf@gnu.org> (raw)
In-Reply-To: <877dt148zo.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

Lars Ingebrigtsen writes:

> Amin Bandali <bandali@gnu.org> writes:
>
>> Currently, the `message-newline-and-reformat' function (bound to M-RET
>> in `message-mode') does not insert an empty space after the citation
>> prefix (e.g. '>') when reformatting the lines following the point in a
>> common use scenario.  I would like the behaviour to change, or at least
>> an option be added to have `message-newline-and-reformat' insert a space
>> after each '>'.
>>
>> Example:
>>
>>> test0
>>>
>>> test1 test2 test3 test4 test5 test6 test7 test8 test9 test10 test11 test12
>
> The problem here is that there's no space after that > character.  If it
> had been
>
>> test0
>> 
>> test1 test2 test3 test4 test5 test6 test7 test8 test9 test10 test11 test12
>
> instead (if that trailing space survives the mailing process) then you get
>
>> test0
>> 
>
>
>
>> 
>> test1 test2 test3 test4 test5 test6 test7 test8 test9 test10 test11
>> test12
>

Right, but I don't think there is normally a space there otherwise
either.  For instance, when replying with (quoting) the original in
Gnus, Gnus and/or Message don't insert a trailing space after the '>'
when there is no character on that line.

> 
> Hm...  OK, I think I found it -- I think there was a reversed check
> for the length of the spaces in the following paragraph?  I pushed a
> fix to Emacs 28 that seems to fix this use case, but I'm not exactly
> confident that this doesn't introduce other oddities.

Thanks, it does seem to cover this case.  But now, there's a trailing
single space after the first '>' with no other characters after it.
Would it make sense to remove that once the filling/reformatting of the
paragraph is done?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2020-09-10 21:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 21:35 bug#43299: 28.0.50; message-newline-and-reformat does not insert space after citation prefix Amin Bandali
2020-09-10 21:28 ` Lars Ingebrigtsen
2020-09-10 21:45   ` Amin Bandali [this message]
2020-09-11 12:09     ` Lars Ingebrigtsen
2020-09-15 14:31       ` Amin Bandali
2020-09-17 14:35         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87363ppapp.fsf@gnu.org \
    --to=bandali@gnu.org \
    --cc=43299@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).