From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44617: 26.3; diff-mode ignores diff-switches Date: Sat, 14 Nov 2020 17:25:17 +0100 Message-ID: <87361bzz0y.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6650"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44617@debbugs.gnu.org To: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 14 17:26:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdyNR-0001b4-1y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 17:26:13 +0100 Original-Received: from localhost ([::1]:35452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdyNQ-0007RT-2o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 11:26:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdyNH-0007Px-IV for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:26:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdyNH-0007sx-9C for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:26:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdyNH-0007Ko-5i for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:26:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 16:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44617 X-GNU-PR-Package: emacs Original-Received: via spool by 44617-submit@debbugs.gnu.org id=B44617.160537113728128 (code B ref 44617); Sat, 14 Nov 2020 16:26:03 +0000 Original-Received: (at 44617) by debbugs.gnu.org; 14 Nov 2020 16:25:37 +0000 Original-Received: from localhost ([127.0.0.1]:51740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdyMr-0007Jc-9E for submit@debbugs.gnu.org; Sat, 14 Nov 2020 11:25:37 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:44386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdyMp-0007JP-B8 for 44617@debbugs.gnu.org; Sat, 14 Nov 2020 11:25:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=72Zev4GB7BXE2oWm1Iau+Yqm2UDg4yGc59XII9dXaiQ=; b=PjDz5jZkocZJB1dc+lieLHeyqQ 53fyTaLid8Oo5BGTkAfSdD2YLtR4rINV+4Q13J8xoRvIjo3pj7e11G/41lGS/WKCf0TP91m4EcOFi b7YAZ0gn39dFSRMTvEhWeZlSnx6zA0gje0tIrEx8wH2givd7iOyoIHH/Bttq5mMCQ5vw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdyMZ-0000et-5x; Sat, 14 Nov 2020 17:25:29 +0100 X-Now-Playing: Genesis's _Duke_: "Please Don't Ask" In-Reply-To: ("Francesco =?UTF-8?Q?Potort=C3=AC?="'s message of "Fri, 13 Nov 2020 13:11:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193299 Archived-At: Francesco Potort=C3=AC writes: > diff-mode relies on the diff-command variables defined in diff.el, but > ignores diff-switches > > I think this is a bug Do you mean the `diff-refresh-hunk' command? I does indeed ignore `diff-switches', but that's because it tries to keep the style of the diff consistent: (defun diff-refresh-hunk (&optional ignore-whitespace) "Re-diff the current hunk." (interactive) (let* ((char-offset (- (point) (diff-beginning-of-hunk t))) (opt-type (pcase (char-after) (?@ "-u") (?* "-c"))) Which I think sounds like the correct design. What's the use case you have for diff-switches where you'd want this command to heed diff-switches? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no