From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41198: 28.0.50; heading cycling command for outline Date: Sat, 12 Dec 2020 22:57:02 +0200 Organization: LINKOV.NET Message-ID: <87360a68v5.fsf@mail.linkov.net> References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31149"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41198@debbugs.gnu.org To: Howard Melman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 12 22:13:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koCCb-0007zf-Dr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Dec 2020 22:13:17 +0100 Original-Received: from localhost ([::1]:37350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koCCZ-0000mI-Nd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Dec 2020 16:13:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koC8c-00082r-2A for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 16:09:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koC8U-00024D-Tx for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 16:09:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koC8U-0004vr-P0 for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 16:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Dec 2020 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41198-submit@debbugs.gnu.org id=B41198.160780733618939 (code B ref 41198); Sat, 12 Dec 2020 21:09:02 +0000 Original-Received: (at 41198) by debbugs.gnu.org; 12 Dec 2020 21:08:56 +0000 Original-Received: from localhost ([127.0.0.1]:46923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC8N-0004vP-R6 for submit@debbugs.gnu.org; Sat, 12 Dec 2020 16:08:56 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC8J-0004uo-Qf for 41198@debbugs.gnu.org; Sat, 12 Dec 2020 16:08:52 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B0A5420005; Sat, 12 Dec 2020 21:08:45 +0000 (UTC) In-Reply-To: (Howard Melman's message of "Thu, 10 Dec 2020 14:08:17 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195901 Archived-At: > I don't follow master so I'm not quite sure what's > implemented, but my original suggestion for this was: > > (define-key outline-minor-mode-map (kbd "C-") 'outline-cycle) > (define-key outline-minor-mode-map (kbd "S-") 'outline-global-cycle) > > It's definitely very useful in outline-minor-mode. I use > this for code folding in prog-modes amongst other things and > that's one of the reasons I used C-TAB for outline-cycle > (since TAB often has other uses in prog-modes). > > AFAIR people commented that C-TAB wasn't always available in > some terminals and said it should just be on TAB. Fine. > Either way S-TAB should work. > > I'd argue that if you're enabling outline-minor-mode in a > major mode that has a binding for TAB, you want it to be > overridden. If not, don't enable the minor mode or change > one keymap to not conflict. Maybe outline-minor-mode should > support a variable option a major mode could set to change > the TAB keybinding or at least not override it with a > minor-mode binding? This feature request was closed, so in a new feature request in https://debbugs.gnu.org/45147#8 this is implemented as a new variable 'outline-minor-mode-cycle' that you can set to t to allow cycling keys in 'outline-minor-mode', and a keymap 'outline-mode-cycle-map' where you can define your bindings such as C-TAB instead of the default key TAB.