From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fabrice BAUZAC-STEHLY Newsgroups: gmane.emacs.bugs Subject: bug#45800: 27.1; ibuffer sort by filename/process fails with Dired Date: Tue, 19 Jan 2021 22:37:38 +0100 Message-ID: <8735ywbobh.fsf@mykolab.com> References: <87wnwjfdht.fsf@mykolab.com> <874kjf1t3d.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45800@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 19 22:38:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1yhv-0002Qm-Uy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 22:38:35 +0100 Original-Received: from localhost ([::1]:34182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1yhu-0002j3-Mi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 16:38:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1yhR-0002iI-Or for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 16:38:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1yhN-0001KK-RM for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 16:38:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1yhN-000645-Ov for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 16:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fabrice BAUZAC-STEHLY Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jan 2021 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45800 X-GNU-PR-Package: emacs Original-Received: via spool by 45800-submit@debbugs.gnu.org id=B45800.161109226923291 (code B ref 45800); Tue, 19 Jan 2021 21:38:01 +0000 Original-Received: (at 45800) by debbugs.gnu.org; 19 Jan 2021 21:37:49 +0000 Original-Received: from localhost ([127.0.0.1]:51958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1yhB-00063b-KE for submit@debbugs.gnu.org; Tue, 19 Jan 2021 16:37:49 -0500 Original-Received: from mx.kolabnow.com ([95.128.36.41]:35710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1yhA-00063N-6E for 45800@debbugs.gnu.org; Tue, 19 Jan 2021 16:37:49 -0500 Original-Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id ACC33B0B; Tue, 19 Jan 2021 22:37:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mykolab.com; h= content-type:content-type:mime-version:message-id:in-reply-to :date:date:references:subject:subject:from:from:received :received:received:received; s=dkim20160331; t=1611092261; x= 1612906662; bh=/LEXC+MSRZIHPI4ACZIq2RYD3DggNcCPcRCkVnFTJRs=; b=u S6DzJV3G8r/i/crX27f0M4ySacT6OTKN7kwML8TnKz4bomUXqMPwM07yjy0YZ3qF 4blEqNg8YOTqJRbMNdZbZMZgwew11CYJOvtr25aYCSQ8dim+gVSyfPo+oSXdhe+f PGO06pbLXEubgHX73tJjFfdYE8Q/r8O1zTovczuUsj0GBm86shSPxljiKFW3CPg8 pEKVpy/sUhzbV2J0+/rn8k4qoeSCH/dAqXIQdTiXBe2XrFQme/zTVhrgk00ZMcSz KzogxxEE7xMTKqV4UOaH1hXTzt87kdVi0eedecRHps4qjpqnM2oMyTv2G8rVEbcS w/kaDJf3R28ZNZLSTtqz5VHDdUIomOIs/rOg11kaHjUaL36Ay8updZ+R4u95w8gu nL/PBSwZyuyHmHmXNX+z2ed0+Oscuc80LqKbeoiASTv8sg3Ey1ngJ3+J3tLzGvzt 2pL+TPnNdfskgL+6ilDNDwvNE0zjg3OI0QS2zqoysFbaARfOdKbCNQOdqPvUjrw1 PZl96D7li/fcfIGVLkeua0aNQmsoDINO4j0kgquyK8PAApmPm X-Virus-Scanned: amavisd-new at mykolab.com Original-Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z-LwMpIaEltf; Tue, 19 Jan 2021 22:37:41 +0100 (CET) Original-Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id F022582F; Tue, 19 Jan 2021 22:37:40 +0100 (CET) Original-Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 8F91E270C; Tue, 19 Jan 2021 22:37:40 +0100 (CET) Original-Received: from noon by asus.home with local (Exim 4.94) (envelope-from ) id 1l1yh0-000CCG-V0; Tue, 19 Jan 2021 22:37:38 +0100 In-Reply-To: <874kjf1t3d.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 17 Jan 2021 15:27:50 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198210 Archived-At: --=-=-= Content-Type: text/plain Here is the patch, hopefully in the correct format. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Sort-according-to-filename-process-as-displayed.patch Content-Description: Patch >From b8ea8fed4729297bb22416893ac6369abdb51ee1 Mon Sep 17 00:00:00 2001 From: Fabrice Bauzac Date: Mon, 18 Jan 2021 23:02:21 +0100 Subject: [PATCH] Sort according to filename/process as displayed * ibuf-ext.el (ibuffer-do-sort-by-filename/process): use the same function for sorting and for displaying the filename/process (Bug#45800). --- lisp/ibuf-ext.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el index ed5c9c0211..44574abd46 100644 --- a/lisp/ibuf-ext.el +++ b/lisp/ibuf-ext.el @@ -1497,10 +1497,10 @@ filename/process (string-lessp ;; FIXME: For now just compare the file name and the process name ;; (if it exists). Is there a better way to do this? - (or (buffer-file-name (car a)) + (or (with-current-buffer (car a) (ibuffer-buffer-file-name)) (let ((pr-a (get-buffer-process (car a)))) (and (processp pr-a) (process-name pr-a)))) - (or (buffer-file-name (car b)) + (or (with-current-buffer (car b) (ibuffer-buffer-file-name)) (let ((pr-b (get-buffer-process (car b)))) (and (processp pr-b) (process-name pr-b)))))) -- 2.29.2 --=-=-=--