From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Tue, 09 Feb 2021 11:19:01 +0200 Organization: LINKOV.NET Message-ID: <8735y538wi.fsf@mail.linkov.net> References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87im73m4ki.fsf@gnus.org> <87im72o6r6.fsf@mail.linkov.net> <87czx9u4h9.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="973"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46358@debbugs.gnu.org, Lars Ingebrigtsen , Dmitry Gutov To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 10:58:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Pmn-00006o-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 10:58:21 +0100 Original-Received: from localhost ([::1]:34124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Pmm-0005WX-6j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 04:58:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9PmU-0005W1-Oc for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 04:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9PmU-00071s-HM for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 04:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9PmU-0007tD-GO for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 04:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2021 09:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161286468130318 (code B ref 46358); Tue, 09 Feb 2021 09:58:02 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 9 Feb 2021 09:58:01 +0000 Original-Received: from localhost ([127.0.0.1]:52714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9PmT-0007sw-FQ for submit@debbugs.gnu.org; Tue, 09 Feb 2021 04:58:01 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:53827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9PmR-0007sg-D6 for 46358@debbugs.gnu.org; Tue, 09 Feb 2021 04:58:00 -0500 X-Originating-IP: 91.129.108.204 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id EFEF71C0010; Tue, 9 Feb 2021 09:57:51 +0000 (UTC) In-Reply-To: <87czx9u4h9.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Tue, 09 Feb 2021 08:42:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199678 Archived-At: >>> Maybe better to display the empty Git stash header using the default >>> colors, and then highlight it differently only when it's non-empty? >> >> Not with vc-dir-ignored, though (it is based on the 'shadow' face). > > Before this change, the empty stash looked the same as all other > headers' values. It could continue looking the same as all other headers' values. > This meant that there was no distinction between empty and non-empty > stashes, something that was noted as a "FIXME" in the source code. Indeed, it could be better to have a distinction between empty and non-empty stashes. The FIXME proposed to use a different face when nothing is stashed. But it seems better to use a different face when something is stashed. It's important to attract user attention to the fact that there are stashes laying around. > I think there is value in distinguishing between those two states, > though I am fine with some other choice of fallback color/face. > Currently the empty stash uses 'vc-dir-ignored' which inherits from > 'shadow'. Whereas others use 'vc-dir-header-value' which inherit from > 'font-lock-variable-name-face'. Could some of new vc-dir faces that you added recently be used for non-empty stashes? > If you feel this is a problem 'vc-dir-ignored' could also inherit from > 'font-lock-variable-name-face'. It's good that 'vc-dir-ignored' inherits from the 'shadow' face when it's used on files with the "ignored" status. Then it could be renamed to 'vc-dir-status-ignored' as you already proposed.