From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24774: 26.0.50; Menu display navigation commands Date: Sat, 27 Feb 2021 05:30:39 +0100 Message-ID: <8735xiku8g.fsf@gnus.org> References: <63bb0f8f-86ff-a260-66a1-8a82d4ef6c9e@easy-emacs.de> <87h7pml6ds.fsf@gnus.org> <837dmyvkt4.fsf@gnu.org> <87r1l6bwlw.fsf@gnus.org> <834ki2vjx2.fsf@gnu.org> <831rd6vime.fsf@gnu.org> <87lfbc4iyh.fsf@gmx.net> <20A0FFE1-60BC-4BB0-A840-15D8D39D1B1D@gnu.org> <87y2fc420p.fsf@gnus.org> <83ft1krwuz.fsf@gnu.org> <87czwo401x.fsf@gnus.org> <837dmwroxu.fsf@gnu.org> <87h7lzmcz4.fsf@gnus.org> <83blc7qbld.fsf@gnu.org> <87lfbbkp6h.fsf@gnus.org> <838s7bqai9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37137"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: stephen.berman@gmx.net, stefan@marxist.se, 24774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 27 05:31:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFrGE-0009YW-DZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Feb 2021 05:31:22 +0100 Original-Received: from localhost ([::1]:33178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFrGD-0005qc-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Feb 2021 23:31:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFrFu-0005qM-To for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2021 23:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFrFu-0001EM-Ih for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2021 23:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lFrFu-0002h4-Er for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2021 23:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Feb 2021 04:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24774 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy patch Original-Received: via spool by 24774-submit@debbugs.gnu.org id=B24774.161440026010245 (code B ref 24774); Sat, 27 Feb 2021 04:31:02 +0000 Original-Received: (at 24774) by debbugs.gnu.org; 27 Feb 2021 04:31:00 +0000 Original-Received: from localhost ([127.0.0.1]:42980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFrFs-0002es-Bb for submit@debbugs.gnu.org; Fri, 26 Feb 2021 23:31:00 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:43348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFrFr-0002YX-7M for 24774@debbugs.gnu.org; Fri, 26 Feb 2021 23:30:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hNbRrcNuPsJ1DJHZetqScdTZlKAL42FLrjtjKZ+Np0s=; b=nwYQqO13sMMHs8gwfsjvhqsyib SHsDI4Nw0n6cYlk2+2YDGqvd7YeVakzHWNU56sKg2mKFn+tksyganC7V+v0ybE07rgIXZP+fz61vI E+X/cSiS3/UW8iBUoJ/eBQkPpVxXzeb0dVCyISTTNIUVXtpcz/rqSu0vXOcbJ4fN6Wr8=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFrFZ-0001t8-Dx; Sat, 27 Feb 2021 05:30:51 +0100 X-Now-Playing: Tuxedomoon's _Live in London (1982)_: "Courante Marocaine" In-Reply-To: <838s7bqai9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Feb 2021 14:27:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200907 Archived-At: Eli Zaretskii writes: >> Because it's a better, more sensible way to define menus. > > But the same argument can be brought up for cl-macs.el and cl-lib.el > and seq.el and map.el and pcase.el and probably several others. Yes, of course. > Where do we stop, if the criterion is "better and more sensible" > (which are highly subjective judgments)? I don't think anybody claims that the non-easymenu way of defining menus is superior? Our most important code is the one that is in the very core of Emacs, and it's a shame we don't use more of these libraries there, and instead open-code stuff badly. easymenu.el is over-ripe for preloading since it's very hard to do much in Emacs without it being pulled in anyway -- so you get no space savings in practice, but just a slower Emacs. >> (And possibly smaller .elc file, as I said.) > > I'd like to see the actual numbers, please. And also the memory > footprint before and after loading easymenu. With the current code, I > see a 0.25MB increase in the VM size after I load easymenu.elc. Pre patch: larsi@xo:~/src/emacs/trunk$ ls -l src/emacs src/emacs.pdmp lisp/progmodes/elisp-mode.elc -rw-r--r-- 1 larsi larsi 60375 Feb 27 05:09 lisp/progmodes/elisp-mode.elc -rwxr-xr-x 2 larsi larsi 32583784 Feb 27 05:10 src/emacs -rw-r--r-- 2 larsi larsi 10630544 Feb 27 05:10 src/emacs.pdmp Post patch: larsi@xo:~/src/emacs/trunk$ ls -l src/emacs src/emacs.pdmp lisp/progmodes/elisp-mode.elc -rw-r--r-- 1 larsi larsi 58798 Feb 27 05:21 lisp/progmodes/elisp-mode.elc -rwxr-xr-x 2 larsi larsi 32583784 Feb 27 05:21 src/emacs -rw-r--r-- 2 larsi larsi 10632360 Feb 27 05:21 src/emacs.pdmp (- (+ 10632360 58798) (+ 10630544 60375)) => 239 bytes. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no