From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46904: Non-unique windows produced by window-state-put Date: Thu, 04 Mar 2021 22:31:34 +0200 Organization: LINKOV.NET Message-ID: <8735xar85l.fsf@mail.linkov.net> References: <877dmo0zdn.fsf@mail.linkov.net> <87a6rj8dhe.fsf@mail.linkov.net> <87lfb2izev.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34351"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46904@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 21:52:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHuxc-0008o0-TP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 21:52:40 +0100 Original-Received: from localhost ([::1]:41106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHuxb-0003iJ-T5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 15:52:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHunL-0008Ek-0W for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 15:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHunK-0007fu-OU for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 15:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHunJ-0005Eg-Vv for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 15:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 20:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46904 X-GNU-PR-Package: emacs Original-Received: via spool by 46904-submit@debbugs.gnu.org id=B46904.161489051020109 (code B ref 46904); Thu, 04 Mar 2021 20:42:01 +0000 Original-Received: (at 46904) by debbugs.gnu.org; 4 Mar 2021 20:41:50 +0000 Original-Received: from localhost ([127.0.0.1]:60421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHun8-0005EH-BE for submit@debbugs.gnu.org; Thu, 04 Mar 2021 15:41:50 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:55805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHun4-0005E3-V9 for 46904@debbugs.gnu.org; Thu, 04 Mar 2021 15:41:48 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D4C1E40006; Thu, 4 Mar 2021 20:41:40 +0000 (UTC) In-Reply-To: <87lfb2izev.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Mar 2021 19:57:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201467 Archived-At: >> I'd first try a vertical, then a horizontal split. Give up if both >> fail. > > Maybe something like this: > > @@ -6229,10 +6229,15 @@ window-state-put > + ;; Create a new window to replace the existing one. > + (let ((new-window > + (or (ignore-errors (split-window (selected-window))) > + (ignore-errors (split-window (selected-window) nil t))))) > + (when new-window > + (delete-window window) > + (setq window new-window))) Actually with this patch window-swap-states fails with the error "Wrong type argument: stringp, nil" in: ;; Swap basic states. (window-state-put state-1 window-2 t) (window-state-put state-2 window-1 t) ;; Swap overlays with `window' property. (with-current-buffer (window-buffer window-1) Here '(window-buffer window-1)' returns nil because window-1 doesn't exist anymore after calling window-state-put.