From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#47205: 27.1.91; [bug] unexpected input event interrupted expand-file Date: Thu, 18 Mar 2021 11:07:39 +0100 Message-ID: <8735wsdbbo.fsf@gmx.de> References: <60522405.1c69fb81.dac4f.907b@mx.google.com> <877dm5d6eo.fsf@gmx.de> <83a6r0dg8b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23472"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47205@debbugs.gnu.org, LinSun To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 11:08:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMpZb-0005zO-EB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 11:08:11 +0100 Original-Received: from localhost ([::1]:47738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMpZa-00031K-Bm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 06:08:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMpZR-0002yV-VI for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 06:08:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMpZR-0000Cm-Mn for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 06:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMpZR-0004jX-HE for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 06:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47205 X-GNU-PR-Package: emacs Original-Received: via spool by 47205-submit@debbugs.gnu.org id=B47205.161606207618184 (code B ref 47205); Thu, 18 Mar 2021 10:08:01 +0000 Original-Received: (at 47205) by debbugs.gnu.org; 18 Mar 2021 10:07:56 +0000 Original-Received: from localhost ([127.0.0.1]:45115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMpZM-0004jD-7Q for submit@debbugs.gnu.org; Thu, 18 Mar 2021 06:07:56 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:33777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMpZH-0004it-73 for 47205@debbugs.gnu.org; Thu, 18 Mar 2021 06:07:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616062061; bh=Pa+8kkHwmfKWjwH1HBTRsNTz3XSvJ8M5dmtgGUAJCXo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=SOAEo9P5sqauDxh+xsrRuP7LkFA8ZNx/yA+wnukyde9iG2fHDMZPRj89oGqInCxmI 7MwrC8k7TJlIoBUSIKukUXnoY8tDB7lxLLcAXlaRxwomX7Nax5Xfb9zzp8NEJ/y/lg g6i4dyGFV7pE7RcGns40NbnJ7EO1MW+znsXkaEZs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.63.71]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M26vL-1lOlVM1fA1-002UjN; Thu, 18 Mar 2021 11:07:41 +0100 In-Reply-To: <83a6r0dg8b.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Mar 2021 10:21:40 +0200") X-Provags-ID: V03:K1:xY5H7I1Mn3A2+j0e4f58ghabkn728mKquHoQ6eWHTQArcv5JfCj sZTUSgFerlqZkUqeUTJ60nlXuPqZ1y1xC9X1QlEnlCkuhhOOxlzE2urKGwXar/swR1cA3Vp 4fo/3O3cjqLmcIOkDoXPkRkvJgCibftTODd8SaOym3dLZhNk/s0XIJvN1hgSarrTY937cQG U8BJyBBml/iUOVrcPHncQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZezCGX5EyLE=:geQGsZLM3cbMnfmZB/5Jwz ySaXP3Yb6s+IC89WvmWl4TRcpU5iuf0UQigH6F9+v0m8Tw+EFl3BllXbLdYnb9KCJY4F/upVW YbSu4KkrYheRdzEFo/PNHnD7Xkzr2/9Gl9pxnloVjYndY3LVJ46SDprNOGOKOgQHxSUTE3nwt BF5DsjSftYBEpvvrTFCl7bQse0dI2RZnjtIqixuu4xzxR9Q9HrEqBxM/sV6FieE4vlciuKUa1 uSDFpy91ux3XexSma++H+uxfhAidmbHQd94DmexbeI+5clom+uRhqnw6eq/T4mnO/2OaGR3OM 0THtWZMsgF5Ayt55YLzTg3xmPZGGlSUOEgA24E9DnJhO7X6wu2GpYXNENuZGMFhWpQUd5prz4 u1qxjbyyZauk5f6chjy7nR8d1xJ3qi4+7j+92OShiV/HhT6u77MILZdzplTrjGHaZGm+vWg9D xLxTJbCjANLxbEM/A/3uvIrQenFwrD8cBaGVesG6P0EtvhN+Rmhy+VUmq0AkQQwnvKKMqa1Pa PD6IKu/fcyxKTA0lF0h/WMYD1fn5EWG4Q3UtqtnNLe10knG0VDZ7CBM36tuPq0HOU3Wl2qWFB f8/Cv83SfMV1rLhxNgr/hAnOh5iLcQDuGwQLwIsJasS+bDRqRQoekOdkIUIm7Kykk56IXPjMZ yuCZZHB/F0EPvyy4f0mPPNUTEre6IqIPA/hdSQd7hMW2YtJ7zMq/XXDg38f4aPMIDTbQF3tEk 0VWGiofEC+wrLQAeRyfJ4Ju3q0oSlwFJiCQT9HXJ/n1oGcyNT+bCvBQY1QTVlCcg0+bXhtBh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202582 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> It=E2=80=99s from the issue https://github.com/bbatsov/helm-projectile/i= ssues/154,=20 >>=20 >> =E2=80=9C[bug] `helm-projectile-find-file' empty candidate when there is= "*.iso/" folder=E2=80=9D >>=20 >> Through the traceback I attached in first mail, the dbus event cause a u= nexpected return value in line=20 >>=20 >> https://github.com/emacs-helm/helm/blob/26d4e9e4d38a143d7dfb2fe206eacbc3= 26944532/helm.el#L4649, >>=20 >> Then it=E2=80=99s function will show nothing. > > Is this because helm uses while-no-input or throw-on-input? If so, > does it help to bind while-no-input-ignore-events to a list that > includes this kind of dbus events? This doesn't help (yet), because dbus-event isn't handled via while-no-input-ignore-events. The appended patch extends this for dbus-event and file-notify. The following adapted test works then: --8<---------------cut here---------------start------------->8--- # emacs --batch --eval "(message \"%s\" (catch 'input (let ((while-no-input= -ignore-events (cons 'dbus-event while-no-input-ignore-events)) (throw-on-i= nput 'input)) (expand-file-name \"a.iso/b\" \"/\"))))" --8<---------------cut here---------------end--------------->8--- Is it OK to push this to the master branch (plus doc adaptions)? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable *** /tmp/ediff1fXkLQ 2021-03-18 11:05:59.385773239 +0100 =2D-- /home/albinus/src/emacs/src/keyboard.c 2021-03-18 10:57:18.933131675= +0100 *************** *** 3614,3619 **** =2D-- 3614,3625 ---- case ICONIFY_EVENT: ignore_event =3D Qiconify_frame; break; case DEICONIFY_EVENT: ignore_event =3D Qmake_frame_visible; break; case SELECTION_REQUEST_EVENT: ignore_event =3D Qselection_request; b= reak; + #ifdef USE_FILE_NOTIFY + case FILE_NOTIFY_EVENT: ignore_event =3D Qfile_notify; break; + #endif + #ifdef HAVE_DBUS + case DBUS_EVENT: ignore_event =3D Qdbus_event; break; + #endif default: ignore_event =3D Qnil; break; } --=-=-=--