From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Thu, 06 May 2021 11:57:08 +0200 Message-ID: <8735v0w5fv.fsf@bzg.fr> References: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> <87zgxcdzh3.fsf@gnus.org> <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> <87pmy5io91.fsf@bzg.fr> <20210505172508.doggiqhzlyibqhom@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24785"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 48179@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 11:58:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lealy-0006JN-Sp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 11:58:22 +0200 Original-Received: from localhost ([::1]:56258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lealx-0001uk-VJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 05:58:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leale-0001uK-JA for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 05:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leale-0000Bw-C1 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 05:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leale-0001dG-9d for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 05:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bastien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 09:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.16202950436261 (code B ref 48179); Thu, 06 May 2021 09:58:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 6 May 2021 09:57:23 +0000 Original-Received: from localhost ([127.0.0.1]:37167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leal0-0001cv-Se for submit@debbugs.gnu.org; Thu, 06 May 2021 05:57:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leakz-0001cp-CN for 48179@debbugs.gnu.org; Thu, 06 May 2021 05:57:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54344) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leakt-00086X-VA; Thu, 06 May 2021 05:57:15 -0400 Original-Received: from [78.194.183.21] (port=45282 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leakt-0006Uz-Pq; Thu, 06 May 2021 05:57:15 -0400 Original-Received: by guerry (Postfix, from userid 1000) id B1A2C1A60E9E; Thu, 6 May 2021 11:57:08 +0200 (CEST) In-Reply-To: <20210505172508.doggiqhzlyibqhom@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 5 May 2021 13:25:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205792 Archived-At: Boruch Baum writes: > What are the steps to reproduce this? I don't use those org features, so > I would be starting at square one. 1. C-x C-f test.org RET 2. C-c [ (to include test.org in the agenda files) 3. Add this contents to the buffer: * A headline to refile * A headline where to refile it 4. Put the point at the beginning of "A headline to refile" 5. C-c C-w (or M-x org-refile RET) 6. Select "* A headline where to refile it" Now the refiled headline is fontified with bookmark-face because Org adds a bookmark to help you go back to the refile location. >> There is also dired and, of course, normal bookmarked files: I guess >> some users may be really confused--at least those who don't know to >> M-x customize-face RET at point to guess what this is all about. > > I don't understand the confusion scenario. The scenario I imagine is: > > a) User navigates POINT to location of desired bookmark I would say that the confusion arises because 1. The user does not do anything regarding bookmarking 2. The buffer get fontified but he does not know why 3. The user cannot guess why it has been fontified because he does not know to M-x customize-face RET > I understand the current emacs policy is not to surprise anyone with new > behavior, so I expect Eli Zaretskii would insist it be off by default. I don't insist on anything. I'm open to turning org-capture-bookmark to nil by default in Org to solve the issue for Org. But again, this is not just Org. I think many people have bookmarks they don't even remember, e.g. in dired buffers. If they see such a fontified file in dired, they will just wonder what happened. My suggestion would be to interactively ask the user to customize bookmarks-fontify on the first C-x r m hit, so that he knows what's in there for him. -- Bastien