unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: pauline-galea@gmx.com
Cc: Philip Kaludercic <philipk@posteo.net>, 48707@debbugs.gnu.org
Subject: bug#48707: outline not distinguishing between levels well enough
Date: Fri, 28 May 2021 01:44:36 +0300	[thread overview]
Message-ID: <8735u7re3v.fsf@mail.linkov.net> (raw)
In-Reply-To: <trinity-2f30be63-6eee-4854-adac-a96effce3e03-1622144246677@3c-app-mailcom-bs04> (pauline-galea@gmx.com's message of "Thu, 27 May 2021 21:37:26 +0200")

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

> outline is supposed to highlight the eight different heading levels in a way that
> is easy to distinguish between them.  I do not see such a capability at this time.
>
> Settings up different colours is also quite complicated and confusing.  I have originally
> discussed this on "help-gnu-emacs@gnu.org", who encouraged me to send a bug report.
>
> I do not get different heading colours for the three heading levels below.
> Philip has mentioned the possibility that the wrong face is being applied.
>
> --------- test.el --------
>
> ;;; * heading 1
> ;; comments
> ;;;; ** subheading 1.1
> ;; comments
> ;;;;; *** subsubheading 1.1.1
> ;; comments

Thank you very much for the bug report.  This is really a bug
that should be fixed by the following patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: outline-font-lock-keywords.patch --]
[-- Type: text/x-diff, Size: 726 bytes --]

diff --git a/lisp/outline.el b/lisp/outline.el
index fa7c1a27d9..3eb3e21036 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -205,7 +205,8 @@ outline-font-lock-keywords
                                  (list 'face (outline-font-lock-face)
                                        'keymap outline-mode-cycle-map)
                                (list 'face nil
-                                     'keymap outline-mode-cycle-map)))
+                                     'keymap outline-mode-cycle-map))
+                           (list 'face (outline-font-lock-face)))
                        (outline-font-lock-face))
                   (when outline-minor-mode
                     (pcase outline-minor-mode-highlight

  reply	other threads:[~2021-05-27 22:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <trinity-46969808-84f1-4235-8289-df9253171923-1622050507521@3c-app-mailcom-bs03>
     [not found] ` <874keo4i4j.fsf@icterid>
     [not found]   ` <trinity-fa6539a0-9b38-43ee-ba76-672fe2ffa519-1622122733859@3c-app-mailcom-bs03>
     [not found]     ` <87v9742srs.fsf@icterid>
     [not found]       ` <trinity-5332e9f2-3f50-4479-a243-71c99938f701-1622135005475@3c-app-mailcom-bs04>
     [not found]         ` <877djkozc1.fsf@icterid>
     [not found]           ` <trinity-8f120450-9410-42d5-a519-9bc378a68baa-1622139205889@3c-app-mailcom-bs04>
     [not found]             ` <8735u8ov50.fsf@icterid>
     [not found]               ` <trinity-84d0be44-7429-484c-bdb6-d06366b6e177-1622143054269@3c-app-mailcom-bs04>
     [not found]                 ` <87v974nfrm.fsf@icterid>
2021-05-27 19:37                   ` bug#48707: outline not distinguishing between levels well enough pauline-galea
2021-05-27 22:44                     ` Juri Linkov [this message]
2021-05-27 23:33                       ` pauline-galea
2021-05-28 18:59                         ` Juri Linkov
2021-05-28 19:23                           ` pauline-galea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735u7re3v.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=48707@debbugs.gnu.org \
    --cc=pauline-galea@gmx.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).