unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#4947: Comments on misearch.el [repost from emacs-devel]
@ 2009-11-17 18:36 Tobias C. Rittweiler
  2009-11-30 21:45 ` bug#4947: Comments on misearch.el Juri Linkov
  0 siblings, 1 reply; 4+ messages in thread
From: Tobias C. Rittweiler @ 2009-11-17 18:36 UTC (permalink / raw)
  To: emacs-pretest-bug


I just tried misearch.el which provides the ability to search through
multiple files / buffers via isearch. Thank you, Juri, for writing it,
it's exactly what I need.

(BTW., is there something like misearch but for query-replace, too?)

I do have some comments on it:

  * The docstring of `multi-isearch-next-buffer-function' says that the
    function is called with the current buffer as first argument.

    However, in case of the initial buffer, it's actually called with
    `nil' as first argument.

   Is that intended? If so, the docstring should reflect that.
   I now have in my next-buffer function

     (setq current-buffer (or current-buffer (current-buffer)))

   as a workaround.


  * It'd be nice, not only to display "Repeat for next buffer", but
    actually include the next buffer's name.


  * If I'm in a file that contains matches, and I'm at the last match,
    it exhibits the following behaviour in the minibuffer:

      Multi Isearch: ...                         (pressing C-s)

      Failing multi Isearch: ... [Repeat ...]    (pressing C-s)

      jumps to first match in next buffer

   However, if I'm in a buffer that won't have a match, I see the
   following behaviour:

      Multi Isearch: ..(incremently typing)..    --> turns to
      Failing multi Isearch: ... [Repeat ...]    (pressing C-s)
 
      Failing mutli Isearch: ...                 (pressing C-s)

      goes to next file

   I.e., as you can hopefully see, it expects one C-s too much. (The
   line without the "[Repeat ...]" is superfluous.)

  -T.

   

-- 
Diese Nachricht wurde auf Viren und andere gefaerliche Inhalte untersucht
und ist - aktuelle Virenscanner vorausgesetzt - sauber.
Freebits E-Mail Virus Scanner






^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#4947: Comments on misearch.el
  2009-11-17 18:36 bug#4947: Comments on misearch.el [repost from emacs-devel] Tobias C. Rittweiler
@ 2009-11-30 21:45 ` Juri Linkov
  2021-06-03  9:30   ` bug#4947: Comments on misearch.el [repost from emacs-devel] Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2009-11-30 21:45 UTC (permalink / raw)
  To: Tobias C. Rittweiler; +Cc: 4947

> I just tried misearch.el which provides the ability to search through
> multiple files / buffers via isearch. Thank you, Juri, for writing it,
> it's exactly what I need.
>
> I do have some comments on it:
>
>   * The docstring of `multi-isearch-next-buffer-function' says that the
>     function is called with the current buffer as first argument.
>
>     However, in case of the initial buffer, it's actually called with
>     `nil' as first argument.
>
>    Is that intended? If so, the docstring should reflect that.
>    I now have in my next-buffer function
>
>      (setq current-buffer (or current-buffer (current-buffer)))
>
>    as a workaround.

Thanks for the suggestion.  I fixed `multi-isearch-next-buffer-function'
to always provide a non-nil value of the argument `buffer'.

>   * It'd be nice, not only to display "Repeat for next buffer", but
>     actually include the next buffer's name.

I see two problems with this:

1. A buffer name might be too long to display in the prompt.

2. To get a buffer name, we should preemptively call
`multi-isearch-next-buffer-function' that might break it
if this function expects that we call it only when we really
are going to switch to the next buffer (not just to get and
display its name).

> There's another wishlist item, though it's not that important: I'd like
> to see a small buffer pop up which contains all the files we're going to
> search through, and highlight where we currently are.

`list-buffers' (`C-x C-b') already allows selecting buffers to Isearch.
So we could mark the currently searched buffer in the *Buffer List*.

>   * If I'm in a file that contains matches, and I'm at the last match,
>     it exhibits the following behaviour in the minibuffer:
>
>       Multi Isearch: ...                         (pressing C-s)
>
>       Failing multi Isearch: ... [Repeat ...]    (pressing C-s)
>
>       jumps to first match in next buffer
>
>    However, if I'm in a buffer that won't have a match, I see the
>    following behaviour:
>
>       Multi Isearch: ..(incremently typing)..    --> turns to
>       Failing multi Isearch: ... [Repeat ...]    (pressing C-s)
>
>       Failing multi Isearch: ...                 (pressing C-s)
>
>       goes to next file
>
>    I.e., as you can hopefully see, it expects one C-s too much. (The
>    line without the "[Repeat ...]" is superfluous.)

Actually this is the intended behaviour.

The first

      Failing multi Isearch: ... [Repeat ...]    (pressing C-s)

says "There are no more matches in the current buffer, try to search
in the next buffer".

And the second

      Failing multi Isearch: ...                 (pressing C-s)

says "I've tried to search all buffers and there are no more matches
in all remaining buffers".

And

      goes to next file

actually wraps to the first file/buffer.

-- 
Juri Linkov
http://www.jurta.org/emacs/





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#4947: Comments on misearch.el [repost from emacs-devel]
  2009-11-30 21:45 ` bug#4947: Comments on misearch.el Juri Linkov
@ 2021-06-03  9:30   ` Lars Ingebrigtsen
  2021-06-03 20:24     ` Juri Linkov
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-03  9:30 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 4947, Tobias C. Rittweiler

Juri Linkov <juri@jurta.org> writes:

>> There's another wishlist item, though it's not that important: I'd like
>> to see a small buffer pop up which contains all the files we're going to
>> search through, and highlight where we currently are.
>
> `list-buffers' (`C-x C-b') already allows selecting buffers to Isearch.
> So we could mark the currently searched buffer in the *Buffer List*.

Skimming this bug report, it seems like this wishlist item was the only
thing not handled here?

Is this something that should still be considered, or should this bug
report be closed?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#4947: Comments on misearch.el [repost from emacs-devel]
  2021-06-03  9:30   ` bug#4947: Comments on misearch.el [repost from emacs-devel] Lars Ingebrigtsen
@ 2021-06-03 20:24     ` Juri Linkov
  0 siblings, 0 replies; 4+ messages in thread
From: Juri Linkov @ 2021-06-03 20:24 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 4947, Tobias C. Rittweiler

tags 4947 fixed
close 4947 28.0.50
thanks

>>> There's another wishlist item, though it's not that important: I'd like
>>> to see a small buffer pop up which contains all the files we're going to
>>> search through, and highlight where we currently are.
>>
>> `list-buffers' (`C-x C-b') already allows selecting buffers to Isearch.
>> So we could mark the currently searched buffer in the *Buffer List*.
>
> Skimming this bug report, it seems like this wishlist item was the only
> thing not handled here?
>
> Is this something that should still be considered, or should this bug
> report be closed?

Usually before starting a multi-buffer search you know what files
you are going to search, so perhaps this report could be closed.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-03 20:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-17 18:36 bug#4947: Comments on misearch.el [repost from emacs-devel] Tobias C. Rittweiler
2009-11-30 21:45 ` bug#4947: Comments on misearch.el Juri Linkov
2021-06-03  9:30   ` bug#4947: Comments on misearch.el [repost from emacs-devel] Lars Ingebrigtsen
2021-06-03 20:24     ` Juri Linkov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).