From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Imran Khan Newsgroups: gmane.emacs.bugs Subject: bug#48734: 28.0.50; Performance regression in `string-width`? Date: Sat, 05 Jun 2021 21:25:08 +0600 Message-ID: <8735tw72qz.fsf@teknik.io> References: <87a6odmfp6.fsf@teknik.io> <83o8cs4t9m.fsf@gnu.org> <87y2bwk1nj.fsf@teknik.io> <83eedo4k3j.fsf@gnu.org> <87v970jwik.fsf@teknik.io> <835yz04ean.fsf@gnu.org> <87r1hoza6z.fsf@gnus.org> <834kek4aai.fsf@gnu.org> <87h7ijlats.fsf@gnus.org> <87y2bvozaf.fsf@teknik.io> <837djf2d0j.fsf@gnu.org> <83lf7u20v2.fsf@gnu.org> <83tumck160.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5853"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 48734@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 05 17:26:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpYBc-0001J2-VS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 17:26:08 +0200 Original-Received: from localhost ([::1]:49270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpYBc-0002Qo-0b for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 11:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpYBW-0002Qg-RS for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 11:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpYBW-000334-Kg for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 11:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpYBW-00072R-Hw for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 11:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Imran Khan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jun 2021 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48734 X-GNU-PR-Package: emacs Original-Received: via spool by 48734-submit@debbugs.gnu.org id=B48734.162290672427007 (code B ref 48734); Sat, 05 Jun 2021 15:26:02 +0000 Original-Received: (at 48734) by debbugs.gnu.org; 5 Jun 2021 15:25:24 +0000 Original-Received: from localhost ([127.0.0.1]:49909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpYAt-00071X-MN for submit@debbugs.gnu.org; Sat, 05 Jun 2021 11:25:23 -0400 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:37445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpYAr-00071G-3I for 48734@debbugs.gnu.org; Sat, 05 Jun 2021 11:25:22 -0400 Original-Received: by mail-pf1-f177.google.com with SMTP id y15so9641951pfl.4 for <48734@debbugs.gnu.org>; Sat, 05 Jun 2021 08:25:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=DXT9TocGR3V9BE6Dl4OYvLeW5qnHo35kYliCdAdo60A=; b=GdVSLtGDcGDoR4IcX5CdDm0D/c98QZv0KYdL9btmZCQUXv+jmMaaFnUA3TPVjZJNCH 2+HXlhIhpXuHijaUHgq4Cz2JXl5qU1On32V2ch3OincIUoSICeioGqAlopcMbLDFqMNH jlqrISphL0Ow07YJl0t7Tj89P/4AXY8S1JgF/rt1oFeSIgFqjT1V+qIwepUmUcMDOEAj qgWehfFOvEvot/Uyn7i/SxcWWSwncbw0Mzc+a5gRxl51PndXyqLShWeuOaaGLpKwbgs2 o6LrI5ao66Rp2/ThZIT20RCDG/iYF94Sk9MC2fxn0pcslicI9mPE5FeOOlgrX7hY1CHJ yjjQ== X-Gm-Message-State: AOAM530tQvjwXx+G7MfGv4jABAD1tyjhST13UwUpXVbYSW7TahC9NZdW iSLgMpYgHnZmzEsEU7E1Egg= X-Google-Smtp-Source: ABdhPJxsRQeo1Y2/+moTkErRhIavsJMFF2fZieT+xmkK5qR286GKUPa0Ks7c2Prf5wPte7iNrlAnLg== X-Received: by 2002:a65:4bce:: with SMTP id p14mr10142998pgr.408.1622906715027; Sat, 05 Jun 2021 08:25:15 -0700 (PDT) Original-Received: from localhost ([116.206.252.68]) by smtp.gmail.com with ESMTPSA id o9sm7366776pjp.51.2021.06.05.08.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 08:25:14 -0700 (PDT) In-Reply-To: <83tumck160.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208059 Archived-At: Eli Zaretskii writes: >> Date: Mon, 31 May 2021 21:51:13 +0300 >> From: Eli Zaretskii >> Cc: 48734@debbugs.gnu.org >> >> > Date: Mon, 31 May 2021 17:28:44 +0300 >> > From: Eli Zaretskii >> > Cc: larsi@gnus.org, 48734@debbugs.gnu.org >> > >> > > (benchmark-run 1 >> > > (let ((str)) >> > > (with-temp-buffer >> > > (insert-file-contents "~/2591-0.txt") >> > > (setq str (string-replace "\n" " " (buffer-string)))) >> > > (print (string-width str)))) ;;;; beware this now hangs >> > > >> > > I waited a minute for it to finish before killing Emacs. >> > >> > Why would someone want to measure the visible width of a 550KB string? >> > Is that a real-life use case? >> > >> > But I think I see the reason, and will try to improve this. >> >> Turns out I completely misunderstood how find_automatic_composition >> works (because its API is deceptively similar to that of >> find_composition, and the crucial differences aren't documented). So >> I will need to restructure the code in lisp_string_width to deal >> correctly with automatic compositions; stay tuned. > > Eventually, I found a way of fixing lisp_string_width without > restructuring, so the above test case, however unrealistic, now works > reasonably fast. I have tested and can confirm it works and solves my issues with deft-mode. Thanks a lot Eli, I am grateful for all your work.