From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 19711@debbugs.gnu.org, Oleh Krehel <ohwoeowho@gmail.com>
Subject: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym))
Date: Mon, 16 Aug 2021 15:15:44 +0200 [thread overview]
Message-ID: <8735r9bke7.fsf@gnus.org> (raw)
In-Reply-To: <jwvmw52mvjs.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Wed, 28 Jan 2015 16:46:32 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I'm mainly interested in this application:
>
>> (help-function-arglist
>> (if (ad-is-advised fun)
>> (ad-get-orig-definition fun)
>> fun)
>> t)
>
> Ah, I think this is just a bug of help-function-arglist: it should
> automatically peel off any advice and look for the arglist of the
> unadvised function instead.
I think this was basically fixed by:
commit 6e2d6d54e1236216462c13655ea1fe573d9672e7
Author: Stefan Monnier <monnier@iro.umontreal.ca>
AuthorDate: Fri Jul 14 11:27:21 2017 -0400
That is, "other advise" (not detected by `ad-is-advised') is now peeled
off by `help-function-arglist' itself, so the code in question should
work as expected, I think.
So I don't think there's anything to fix here (any more). Is that
correct?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-08-16 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 13:55 bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) Oleh Krehel
2015-01-28 19:55 ` Stefan Monnier
2015-01-28 20:07 ` Oleh Krehel
2015-01-28 21:46 ` Stefan Monnier
2021-08-16 13:15 ` Lars Ingebrigtsen [this message]
2021-08-16 17:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735r9bke7.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=19711@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).