From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#50410: Tramp does not honor default file modes in make-directory Date: Wed, 08 Sep 2021 18:59:02 +0200 Message-ID: <8735qfatrd.fsf@gmx.de> References: <1505932.1630865835@pental> <87zgspesc0.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8375"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50410@debbugs.gnu.org To: Stephen Gildea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 08 19:00:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mO0vo-00023f-A8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Sep 2021 19:00:16 +0200 Original-Received: from localhost ([::1]:49672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mO0vn-0000pH-1R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Sep 2021 13:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mO0va-0000p4-Vv for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 13:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mO0va-0007uT-Mo for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 13:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mO0va-0003c5-EG for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Sep 2021 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50410-submit@debbugs.gnu.org id=B50410.163112036113790 (code B ref 50410); Wed, 08 Sep 2021 17:00:02 +0000 Original-Received: (at 50410) by debbugs.gnu.org; 8 Sep 2021 16:59:21 +0000 Original-Received: from localhost ([127.0.0.1]:33481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO0uv-0003aL-Fy for submit@debbugs.gnu.org; Wed, 08 Sep 2021 12:59:21 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:56531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO0ut-0003a5-OM for 50410@debbugs.gnu.org; Wed, 08 Sep 2021 12:59:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631120344; bh=w/mfnYsCbBHFGctvSCNukzK35fY4k9hiu5WZvyjVjPw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Gx6P+n2T1THnA9q5M8y13djCAOSGGLR2E8wB2mT2E+o8OCGq4IWgaARd6uI+EmeR8 9VfohMyPoPfZU0/W8Kj/Z8efX7rHMbhpS898aL49piFMka0dY+TuambXNYqz1tkapI MSclZm6Rlst63ynVtR+A3YGL6Vp+47b+oYZCSHHA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.148.40]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N49lJ-1n62lC3m0v-0106qY; Wed, 08 Sep 2021 18:59:04 +0200 In-Reply-To: <87zgspesc0.fsf@gmx.de> (Michael Albinus's message of "Mon, 06 Sep 2021 15:39:27 +0200") X-Provags-ID: V03:K1:9EgjUTZjcXwWgDEhqgg5JxNbdHwz3fxTgbutUz/SxCkC6UVgzbI ukha2PqRM9j9LcgoY7GQVqMmzGDX6dyJezwI++/yi6/mDDJ9IAvJyhXcFOanmCFu4dNGtfw LfFqbIUzyPreuWpIZA5AQ3m7+jbZUkaAjeEq8h3/zkv8JdQau+0R5/MWsEqZ8QlQ4laf0qA 0Oxpf/DBY3dgk/bYjb8UA== X-UI-Out-Filterresults: notjunk:1;V03:K0:69GumBRjYN0=:n52a+hDENfqvg33fUXQ4Tv +SLYD2kUZXBoYRWYXepXMEc+uTtPhS1VX63JNc7TXqB+xNtuMxt73A3bZ3hDX89thJYjWHnP3 pK5FxJtMpoJcPF5AzurkXLG9ywLecd2muBQjgrZZ3gMqfqHAlEf7QisQnSu6/LY3A0lG1OjGb HBPNljx90yqKH1We1I85c5xp6ldFqMdFLEo+q+uoQulD32xTbPbpJFjlYw4UBbBl3n8OaoYgY 55d8B56NjiEuu9LNJO0Z3NIfgzmGf0w9SW601IqaKS5wzTAX0F4H5u7ISk/6lBegMinVa9NfR GwBVTF0PQzk6UHLDT9W909Czsf7pjtLzgL4y1tyjfXSwqJtzM9dhtGYxuR9WdzkquyhdVWwOD ygQfa8hyYadjm2J0DIxcM3+4D2an+GsfdLkQcLTKR0YEVjkohXdX5F7okvKr7Mp59ipnq0QOF vKpnyFYlordy21gFHq0uq09dTpqdVxnd2hk7PFIpZU2AKK6Bt3yNOGO0pqWslcyMEmEW0628Q b9pIpCodySt9OCH5g3zVdEVE+ZRvGFf3Wfgv4ubHo36AvMF+ikVb75M3jFLxojYAEqsVCHnl6 iWgFgM98tFVgTWdpSrjlqZ01RB0AOAXokPsmwZ+Gu9xA1jHE5FligdsPbd9GJ5ZdFoGEa/Kwm jSH8BaaVST89uodLsLPBoJZbTjaUzljB9933OpWF2wOPDvsUKLrfzeKb1GTXithFwgpaBxEKp seEjpVQWh+FsK96Xf4RgCq6yvzNkef0kF0/jWg/6oCLC0+KjaTuC+fiYeEuPrY/d6C6h4zmk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213849 Archived-At: Michael Albinus writes: Hi Stephen, > >> Tramp: honor default file modes in make-directory > > Thanks for this. As discussed privately, I believe it is a good > extension to Tramp. > > I gave it a short try, and it works as expected for the "mock" test > method. Please push to the master branch; perhaps you could also add a > short NEWS entry. > > Next days I let run the test suite for the other Tramp methods. The results are good. In tramp-test13-make-directory-with-file-modes I have applied the same rules like in tramp-test20-file-modes, it looks now --8<---------------cut here---------------start------------->8--- (ert-deftest tramp-test13-make-directory-with-file-modes () "Check that `make-directory' honors `default-file-modes'. This is a separate test from `tramp-test13-make-directory' because some backends cannot pass this test." (skip-unless (tramp--test-enabled)) (skip-unless (or (tramp--test-sh-p) (tramp--test-sshfs-p) (tramp--test-sudoedit-p) ;; Not all tramp-gvfs.el methods support changing the file mode. (and (tramp--test-gvfs-p) (string-match-p "ftp" (file-remote-p tramp-test-temporary-file-directory 'method))))) (tramp-test-make-directory-helper t)) --8<---------------cut here---------------end--------------->8--- In tramp-adb.el I believe it would work as well, if the Android device is rooted. But this we don't support. >From my POV, you could push it to master. Best regards, Michael.