From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bodertz Newsgroups: gmane.emacs.bugs Subject: bug#51324: 28.0.50; Should `message-mark-inserted-region' insert a newline before the end tag? Date: Thu, 21 Oct 2021 16:27:43 -0600 Message-ID: <8735ouui74.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40014"; mail-complaints-to="usenet@ciao.gmane.io" To: 51324@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 22 00:37:52 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdgh5-000AH3-Id for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Oct 2021 00:37:51 +0200 Original-Received: from localhost ([::1]:58392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdgh4-0007rp-IA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 18:37:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdgXa-00008A-LD for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 18:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdgXa-0000hC-CD for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 18:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdgXa-0001yy-4n for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 18:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bodertz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 22:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51324 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16348552717593 (code B ref -1); Thu, 21 Oct 2021 22:28:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Oct 2021 22:27:51 +0000 Original-Received: from localhost ([127.0.0.1]:58873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdgXP-0001yO-1w for submit@debbugs.gnu.org; Thu, 21 Oct 2021 18:27:51 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdgXN-0001yG-Fo for submit@debbugs.gnu.org; Thu, 21 Oct 2021 18:27:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdgXN-0007x9-6Z for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 18:27:49 -0400 Original-Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:40580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdgXL-0000dh-CS for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 18:27:48 -0400 Original-Received: by mail-pg1-x52f.google.com with SMTP id q5so1558111pgr.7 for ; Thu, 21 Oct 2021 15:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=JzKL818gMn57f2pgbjPbOKh1K/jkc92m3Q88YZFZBXg=; b=kMEhFTdKeObZR0oWXVSoD+GuoLyNFZ1ZCulwWqzcUuvYN/Q9PaSTUhr0i8FgUt9aLn z2aFUtsQtcQ3qMBIl0+q5VawfDOKbqQbMMrJSwiGBAfoJC7x8IKWrBNCYHaA1SsvBulO vSBS4bKlYdxm130HvCurYvDHwnhP2JQwkUJoradvyuw60ruNm0/8pevByG6tXb03u6cA VMqGQ3ABV1odWTOoQbxj0XJ4CK71oEOMBVEl89BQpdypDQkK+CV7K3kzUstLvqSzqRpA s9j/wG1HyXVU68HdgKCHeaGKrGGBBSXNUuJi9kPOjZmTXiGjKPy9crt/iVNQQU0hP/4G HLYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=JzKL818gMn57f2pgbjPbOKh1K/jkc92m3Q88YZFZBXg=; b=q6Y5IOvQ951kAKJiNVreCwd1Kt4Wig6sKIReuslJOKOqu+zwHJrXV9Xbk6WtEoypxx Hq8zcuotDo69RhgJfbGFEJKZOROwvDn636S/8gs2bghqqD/SOVn8rwiURU+mbKtQzNEG uex2+eF+z63E5OQ810/m+OcGryRmXfLfblM3tl2Bjb30MsIuB/rLD/OCC2xYjuRvlldO 4/aY8s2cAd9or0wMWAEzhMOB72vJ8qH+GLl5mIhU4H1kQbI0QDS7S1+wxxNOTHmV0pa2 kTxqu5x3NXL9Xnvt/mBbXSUlwJGUpzy70+JXZClqFssQfqyGyskNZq6ss7C/Lm6VaTnM lY5g== X-Gm-Message-State: AOAM530YgSKOY/+pUXGQ65EytvepaNzggO2lBJ4zQrDj9V0NCJpFCAWy NbD1HqQuLiVLtzrxrVGSFt+x1ZPDUPQ= X-Google-Smtp-Source: ABdhPJxF9V0XFX92HjtulKPPFEXjMUO2z689wUetvi+8aBbMc3uBXYaaT6oVhIFa9cVSuPhj78GRXw== X-Received: by 2002:a05:6a00:24d6:b0:44c:df15:f52e with SMTP id d22-20020a056a0024d600b0044cdf15f52emr8803095pfv.36.1634855264789; Thu, 21 Oct 2021 15:27:44 -0700 (PDT) Original-Received: from flavia (S01061cabc0a572b3.ed.shawcable.net. [68.148.90.108]) by smtp.gmail.com with ESMTPSA id z24sm7311972pfr.141.2021.10.21.15.27.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 15:27:44 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=bodertz@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217836 Archived-At: The function `message-mark-inserted-region', bound to {C-c M-m} in message-mode, inserts "cut here" text around the region. By default, the end tag is inserted directly after the text in the region, resulting in: text in the region The text inserted is customizable by changing the values of either or both of `message-mark-insert-beginning' and `message-mark-insert-end', so what the defaults are doesn't matter much, but I think it would make more sense for the default end tag to include a newline at the beginning, or for the function `message-mark-inserted-region' to insert a newline before the end tag: text in the region `message-mark-insert-beginning' already includes a newline at the end, so I think making `message-mark-insert-end' include a newline at the beginning makes sense. Otherwise, a user will have to insert the newline manually every time, since I don't think the anyone ever wants to see it without the newline: --8<---------------cut here---------------start------------->8--- text in the region--8<---------------cut here---------------end--------------->8--- The same issue applies when using the prefix argument to use so-called verbatim marks: #v+ text in the region#v- This looks wrong to me, but maybe it isn't.