From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#51386: 29.0.50; fido-vertical-mode: ssh host completion Date: Tue, 26 Oct 2021 20:53:12 +0200 Message-ID: <8735onk487.fsf@gmx.de> References: <410f97e4-1cc0-3a3e-bc07-b076ccd52ac8@inventati.org> <822aec9d010037a1158a@heytings.org> <87916c87-fcea-d8a4-5f1d-9066e845add1@inventati.org> <822aec9d01dd14907c52@heytings.org> <664bd93fdd4dd6ce0249@heytings.org> <2f34674e-a170-99e6-f923-dabbd7013e60@inventati.org> <877ddzk64t.fsf@gmx.de> <664bd93fdd51d1c62c79@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6541"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51386@debbugs.gnu.org, Manuel Uberti To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 26 21:02:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfRiC-0001Rr-GE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 21:02:16 +0200 Original-Received: from localhost ([::1]:39402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfRi8-0007Ul-Ou for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 15:02:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfRaF-0006lc-ED for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 14:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36013) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfRaE-0007Uc-He for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 14:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfRaE-0000R4-Gb for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 14:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Oct 2021 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51386 X-GNU-PR-Package: emacs Original-Received: via spool by 51386-submit@debbugs.gnu.org id=B51386.16352744021614 (code B ref 51386); Tue, 26 Oct 2021 18:54:02 +0000 Original-Received: (at 51386) by debbugs.gnu.org; 26 Oct 2021 18:53:22 +0000 Original-Received: from localhost ([127.0.0.1]:47559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfRZa-0000Px-05 for submit@debbugs.gnu.org; Tue, 26 Oct 2021 14:53:22 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:57321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfRZY-0000Ph-LC for 51386@debbugs.gnu.org; Tue, 26 Oct 2021 14:53:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1635274394; bh=ul+KKJUWHDEvPN2RaKXD1NpodvJQwKcOoi8861kesos=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=OGTk8iwca9M6Seq6uzs2hWwfmSYwnI6hr1ZDXgQeOAJN7I3fOU6+NvgLlun7JnDYc RynrNKw9iWR1YBSRlUO+uuwnLU1cHIcTc6IVypYsMsNCAmpkRFCs8U/mnYVI2efgxY DLlubBLhaZCDO6F5llNBQ0Gdhj6qp7q5nM0ltY5E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.242.69]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MYNJg-1mBB0t3k3O-00VNDm; Tue, 26 Oct 2021 20:53:14 +0200 In-Reply-To: <664bd93fdd51d1c62c79@heytings.org> (Gregory Heytings's message of "Tue, 26 Oct 2021 18:24:44 +0000") X-Provags-ID: V03:K1:hRXypZn4KK6DVYxY2t1bjriKvUJRQUnPvAEAWwJjq8fuJhz7VuG tRWFP35WsFdkpy/lAMAaAix2flBL+godjz9a2E3Fwaef3xuePkv4Nkn+gr12laUyIlvrM+n 4vNK3gS16MY/VrQlkdBDTD7HhZvGnjXFcMdzQ5OiuRg5VBrHM6XT9dfXZ5/l3pdu7iNbAag DL1e2iFYlD3gk1UhL9RMQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:po/nSo24sFs=:9FSB2HNC/6US+Qf7QwBHeF 2gBglDB1B4tFMpWEIjKQJ4wMj0dxvwHOv5QXDIlMJBtBhod5phTKI2qaVrPIqDGi/aRSDe9jd CWcjHLxFC/j3+sCeGbIde4MMBCziy3fFDU7d2fwxj9jMWRpMtIFe/VQjZXvj1qu3Xm9W6a7dA eH6VsfiNGL3NHWEWHVNVwhJ7NpK77Ta6OxRW0gcHltZIi1vZm+eNA0uixXewTkbVBktUG4Juq PHMmI4R7EBZGyq3gqeCdr+9wS034WIX5xuwf5aw4gFPiZBQx6Z9n5Xmn0uu/WVelmSbidbbUN Rv6XCUHxZGCofz6Y8+SMgZNmTg61yxZIKWUsZ5VSC9VbYvuUueeah6ChNB5/RkGeA3MCAtvF8 aCoD5QYKrixNz7xdbyMmzHDxOBljsL0/BswyXg6S5RmEx07e5MWKIlLhfiHgsbdAOHktBupXL aQJeHyaMnRgmfOQANKPHLQTcsmgybfPnnHQoIEJv5VDA8SPmhecaWiv65qalpraI+Y5Nz0Nqu tHmvPlADQBQPNFCKcfEho/I4nwJM14va+ankWyXzRaOjOCXIZMx0M+cMA58CyfkKazABTejLV 3XoIv++pfbZ3rmp4n4YvMp74vATXUnPXVBvFqsvx+tF5Et0PzF93QIiQQ/oxVXjCUwqg642Nz CMs7wIJDm8RIvrox7URvH9R4LXWCgAAS1nEthfRfZa41NYi4V0xtB8winHcgMmChIroqUqpH4 lN8yqqIicplTruWLhy/i0Vhefme6na7RJFTeflMD0uTmM2gyc6tUUe+DMZC01Z2XzzsB9srv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218399 Archived-At: Gregory Heytings writes: Hi Gregory, >> Bonus point, if somebody who knows completion styles by heart could >> fix this annoyance. Then we don't need to document it. >> > > ??? I sent you a (one-line!) patch for the second annoyance, and you > rejected it. I'd be willing to look at the first annoyance, but not > if it's to see the patch again rejected. Your patch violates the file-name-all-completions API. Testing with "emacs -Q -l tramp": Currently, we have the following with vanilla Emacs (on my laptop): --8<---------------cut here---------------start------------->8--- (file-name-all-completions "" "/") => ("sudoedit:" "sshfs:" "smb:" "rcp:" "remcp:" "scp:" "scpx:" "rsync:" "rsh:" "remsh:" "ssh:" "sshx:" "telnet:" "nc:" "su:" "sg:" "sudo:" "doas:" "ksu:" "krlogin:" "plink:" "plinkx:" "pscp:" "psftp:" "fcp:" "rclone:" "afp:" "dav:" "davs:" "gdrive:" "mtp:" "nextcloud:" "sftp:" "ftp:" "adb:" "sbin/" "proc/" "bin/" "snap/" "opt/" "var/" "dev/" "lib64/" "./" "nonexistent/" "lost+found/" "media/" "root/" "srv/" "etc/" "mnt/" "../" "tmp/" "net/" "sys/" "lib/" "boot/" "home/" "run/" "usr/") --8<---------------cut here---------------end--------------->8--- With your one-line patch, we have instead --8<---------------cut here---------------start------------->8--- (file-name-all-completions "" "/") => ("sbin/" "proc/" "bin/" "snap/" "opt/" "var/" "dev/" "lib64/" "./" "nonexistent/" "lost+found/" "media/" "root/" "srv/" "etc/" "mnt/" "../" "tmp/" "net/" "sys/" "lib/" "boot/" "home/" "run/" "usr/") --8<---------------cut here---------------end--------------->8--- That means, all Tramp methods are suppressed. This is wrong, a valid file name can start with a Tramp method. The Elisp manual calls such cnstructs "magic" file names, but they are still valid file name prefixes in the sense of file-name-all-completions. And so they are valid results. Our discrepancy is, that I believe we shall follow the API, and fix problems where they are located. You want a workaround in Tramp, which would IMO do more damage than it is good for. My experience tells me that such hacks will create new problems we have to deal with in the future. Both of us agree that there is a problem. I don't intend to reject patches from you, I just must be convinced that they solve the problem adequately. Best regards, Michael.