From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware? Date: Thu, 28 Oct 2021 10:02:46 +0200 Message-ID: <8735olwp95.fsf@gmx.de> References: <69264ece-bb7f-4db1-f461-dacd33db2402@gmail.com> <87cznqev5g.fsf@gmx.de> <2c3dffbc-9af0-f318-15bc-cce91a106898@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22325"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51426@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 28 10:03:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mg0NR-0005bP-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 10:03:09 +0200 Original-Received: from localhost ([::1]:45012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mg0NQ-0002Ka-Ft for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 04:03:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg0NK-0002KO-9Y for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 04:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mg0NK-0008I5-0c for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 04:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mg0NJ-0003VV-PW for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 04:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Oct 2021 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51426-submit@debbugs.gnu.org id=B51426.163540817813468 (code B ref 51426); Thu, 28 Oct 2021 08:03:01 +0000 Original-Received: (at 51426) by debbugs.gnu.org; 28 Oct 2021 08:02:58 +0000 Original-Received: from localhost ([127.0.0.1]:51257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg0NF-0003VA-SU for submit@debbugs.gnu.org; Thu, 28 Oct 2021 04:02:58 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:38221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg0NC-0003Ut-Hx for 51426@debbugs.gnu.org; Thu, 28 Oct 2021 04:02:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1635408167; bh=xmN/5r3DOYpVpzJ/hL1PENMxJowRUS6tDSL1eWN7O0o=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=N2fhU/PHT1V7B3P2d7ooVSUQs2uohhT4qB426OWeRdGe/81//rHnYDknPoWLWYqAW nlx5LZ3ihisQ1lnpNpThpspCbTYgVl2pY4WKu/r+3u9GutWJhFh10l9tZXG8d9Upks psZgMPMFl50Nu0HhXpxdcB2FvJzA8v/8/4+9riPw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.242.69]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MacSe-1nCaIn2Znm-00cBXu; Thu, 28 Oct 2021 10:02:47 +0200 In-Reply-To: <2c3dffbc-9af0-f318-15bc-cce91a106898@gmail.com> (Jim Porter's message of "Wed, 27 Oct 2021 17:45:53 -0700") X-Provags-ID: V03:K1:YylCXrIaldj8O85+A4qdG4h0r09TecfMN22Gy4LNZb5QYBK1/VL wBtVw5Xmz8uBwwHItPYjKi4ElY8qbClVqaToVdiNVAs7Ryg1HQGcSP2SVYbTCG93MAwZ07C q4VvK1DD2mZktqvHoAHj48xPf1yc4Y45NXC0nmhnfatdy/gwFbCFcbZBZvjsLh9ELZs+hDN tnT06itQyMjAr/KwJPOtw== X-UI-Out-Filterresults: notjunk:1;V03:K0:i3WZkpvZVb4=:DX8FNtywZYIRWCdik05fOT 7DeDo2t6pIA27wlTaD/iMxfEx7oV02QtTk3body3jPbrul2dU+LbbZPRxydh1ABstvA8tXYDG +2Bz+cUBS/MbprvJ22GhrxSrtXSN2O6BWMEJGsvpbCwHN2DVZOiZZf6lAj13bkARITc+2A+87 7hQLd2tNyZGTGdlgRPrv0mMWKTN1fJ/Hg8lsU0KmMF4bs1qIKUzcH3Sw5+R+0I98t04Y4x7Q8 I6GOFIuYMGdX89zwyfcVQrEig0bi6KQluxAB0FRbpuzijowBYV2nDST41G54bKwc7iry7R1+d XNUAVhL04v8Cbv0WtjLAG7szZovdzKmVTXfaK4K9Y5+AMF7uUZPcvkA85Fl70HOoEpqSrQPMd 0T8o8g0Utp1/nya7tB8OclRS6dI2LISpKtM0Yifuc0rrRA5F0LdI+KTJnbyVxs0u//lRevIaf B6o2Oz86ivCZXU2OcjpgEvFaMCLJSMt8GhJdHjJFTYBWp0YgF0aEIjHPGxPnDCYJNrhJ2/IJi pN0DtArJQIU75NBZh5p4FgBLPBykcWS1UPMS6jp712HILKAJ1dww+Q7h/hB22via13RC/bh/3 NZiPwIrZYMXMvpsMU/LqUhIrySTr3kaDa/PwaT3/0mVgF3+8sLhbTALhuPZwG8wGkDMXR3+8Q rXWGlmhT5VZfuXKjoIdsgBa1lPsOnVV6hRk+0cj+sIobZS9T5mHwvaxru/pa4N3TK8FhZkSk7 EZPuhGRaTUirOIdvgoOCgsuvcrAXzm9gvGKXmgaRFbBQAoiPHdMEyCiBrV9ZobrtwtJRioC+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218491 Archived-At: Jim Porter writes: Hi Jim, > Thanks. I've expanded the section about `comint-terminfo-terminal' in > the manual to include information about how `system-uses-terminfo' > works as well as mentioning that these variables can be declared as > connection-local. LGTM. Just one nit: > color is supported. Therefore, Emacs provides an option > -@code{comint-terminfo-terminal}, which you can set to a terminal that > -is present in your system's terminfo database, in order to take > -advantage of advanced features of that terminal. > +@code{comint-terminfo-terminal} to let you choose a terminal with more > +advanced features, as defined in your system's terminfo database. > +When @code{system-uses-terminfo} is non-nil, Emacs will use this > +option as the value for @env{TERM}. "this option" sounds like Emacs uses system-uses-terminfo for TERM, at least in my ears. Could you pls rephrase it a little bit? Otherwise, it is OK. If nobody else objects, I would push it in your name to the master branch, when you have reworded it. > Thanks for taking a look. > > - Jim Best regards, Michael.