From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53136: 28.0.90; segfault in lock_file Date: Tue, 11 Jan 2022 08:51:25 +0800 Message-ID: <8735lvp01e.fsf@yahoo.com> References: <871r1hv40o.fsf.ref@yahoo.com> <871r1hv40o.fsf@yahoo.com> <83bl0l2we3.fsf@gnu.org> <87r19htjlp.fsf@yahoo.com> <838rvp2tcw.fsf@gnu.org> <875yqtt9qk.fsf@yahoo.com> <8335lxazg6.fsf@gnu.org> <37cd3017-38cb-fa2c-7b52-fbeb3b085744@cs.ucla.edu> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26164"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Eli Zaretskii , 53136@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 11 01:56:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n75SF-0006dF-MD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jan 2022 01:56:03 +0100 Original-Received: from localhost ([::1]:40318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n75SE-0007Fa-MB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Jan 2022 19:56:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n75OU-0003vF-2a for bug-gnu-emacs@gnu.org; Mon, 10 Jan 2022 19:52:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60712) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n75OM-00037r-5E for bug-gnu-emacs@gnu.org; Mon, 10 Jan 2022 19:52:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n75OL-0003Yj-QD for bug-gnu-emacs@gnu.org; Mon, 10 Jan 2022 19:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jan 2022 00:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53136 X-GNU-PR-Package: emacs Original-Received: via spool by 53136-submit@debbugs.gnu.org id=B53136.164186230313651 (code B ref 53136); Tue, 11 Jan 2022 00:52:01 +0000 Original-Received: (at 53136) by debbugs.gnu.org; 11 Jan 2022 00:51:43 +0000 Original-Received: from localhost ([127.0.0.1]:53615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n75O3-0003Y6-I3 for submit@debbugs.gnu.org; Mon, 10 Jan 2022 19:51:43 -0500 Original-Received: from sonic308-10.consmr.mail.ne1.yahoo.com ([66.163.187.33]:34165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n75O0-0003Xq-LX for 53136@debbugs.gnu.org; Mon, 10 Jan 2022 19:51:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641862295; bh=pKNIVFnrkfhhA8n2SoxTioiamYwvEZv/XQT97xodIIw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=GtC0J2oBlqEQ6CRN7PgS0j9PTX1BwgYdvObq1Bm2oqUpRwV7m9RZkDfjHqyoLTPQsh3DGmnrl+IWGVTmwi56Ym4ZtKGrAVRg3rCoTgyrG9SR1pJbXIo45WyhDiDA9k7zDBjnli0gjSMDMxfHjUl+oSV1nKFmnI7282Jnt600VVx6WDIQEY/06ETuH2syZljRU4cvdNd+pxTGUXBaIum86wzW6BqjpzdCcDyskCVFHuu/ophkb2cH64FWLtesuzer7N9vjE+eccShU+hAdPSFBsJivOjxuMxkvG1JtABhFdaFrjzqdvBkSIEzM6BOiDzADcyrCt2qeUnRnuyzotYWcQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641862295; bh=LEVbdR6kj0xrHUTfczPysqRA/QKP3VS12iQP2jZVXXJ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PaEQmUXwoAn+ysdJzhr44kNei3/Jec6soty8FFOTBbz4Uzi8+8c+lVQfHvz0ESV6fBLzSfKe79IplCtAdFUEmd7SEaYu6tkMy6WPVrP4ckUiOdI82AH20P7iHwR4yXOEIMeF/f7cagghFPOZxCC0cchMzzaIlko2RRu1n++OFqFoGqsfa8vEn0D4LQqKdzjJkTlqnArGUReUFoxYzSspJmY9qYPQzYvcUpc3b3RMBBQgEbKLzjzwsPX9FE3v3vcUm3t9b3ni+Vf0kd4rroik1xEf8co0QNJ+hCBMeeq50MK+SbUAWL1gndhq4ELozwraKdq3+8N2dQP/jOPAPFssOg== X-YMail-OSG: ku08TzcVM1lZa2c8zV9GG6BwexCCVeD8Pyba29UsqDS26CNPfn71fvO8FLDoweP SskN_22w2YN7WyEsAneDhWZpuyFcZ6apecOVqPOgTNfJ4aa79xLRrx9WQ6vA3xnkQK7E_RbB721u 8ZjAnHxcI7JztmP5DghuCmNk6KIjyF8l0itnS3N_M5sug7FxL0igJNIjkGY62QaJkvS0sLtJi.kW kx5tScMLLVKIeGtwms7Ey.8Bc3MTESY6wshQnfCfeg0IWhvh_piZkLZ9ZZhys0.x5RJt36Qauk9U QYTAZ2P7zrvfTgHIIm_AJVvD596hu02SE_LzriukKsR2yi5iM_sJ130hYUKukZhPycB4Njg3yp07 BPj5biTaueoyFwJW4BOQB6LKGJMNvDrzo.HEXzrabwNy2cO5Aa1rjbEawR1l7LgNT0lY0anq6ME. kWHca3AhsYvgdyAmeSS9zx2fKdl81FRD2jpT7jJPJiuEkMDSP_x9xYJJFUbyKt7vaRrMjpeiF7_U iYzFsYduJdaVwbmXnwGZcMLQSyzhw50kcrcv4P1XnObcWZC6lvC__Dma7XanFJzsGt306OODIoCw wW2eX.rr.AjVjuu2hS2rz3gGkb3wzWZnsnxoOB8Kbz79GDYWcURTjbQswWlYCi4xocnqvqrHXUeE 1vG4mHdWBDSANspS8nd1KVR9EmC8r78uIJVOK15_bsV6eXYXwux2XOnwmTNJ4Qdms6pbgYTUld2f ZoTilMHn0v3vyg2q0FXDd7jamxh_7Dvvock2zMEyQ4uyEXTFChgVZU3QK65EYtZVEXBbF0BP7rj3 ZKEVe88Lc5jaxxHLqGwGKfRpwczax3vTpAMu9v0lmb X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Tue, 11 Jan 2022 00:51:35 +0000 Original-Received: by kubenode509.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 92a5d95d998719460ebd45c9b1568c4f; Tue, 11 Jan 2022 00:51:29 +0000 (UTC) In-Reply-To: <37cd3017-38cb-fa2c-7b52-fbeb3b085744@cs.ucla.edu> (Paul Eggert's message of "Mon, 10 Jan 2022 15:11:04 -0800") X-Mailer: WebService/1.1.19551 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223910 Archived-At: Paul Eggert writes: > On 1/9/22 04:03, Eli Zaretskii wrote: > >> Paul, could you please take a look? > > The problem (as Po deduced) seems to be that Haiku errno values are > negative by default. That was an unrelated problem. This bug is on GNU/Linux, when running under Valgrind. (I was trying to find the GC bug from last month.) > 1. It uses BE_USE_POSITIVE_POSIX_ERRORS but Haiku spells it > B_USE_POSITIVE_POSIX_ERRORS. I'll fix that. > 2. There's no need to replace "if (err < 0)" with "if (err == -1 || > err == -2)", as this replacement is not needed given the "#if !defined > HAIKU ..." stuff. > 3. More importantly, I'm sure there are other places where Emacs > assumes that errno values are positive. I doubt whether it's > reasonable to expect Emacs developers to remember and work around this > Haiku incompatibility, every time they call a function that sets errno > or returns an errno value. Instead, we should arrange for Haiku builds > to use positive errno values, they way errno behaves on GNU and other > POSIX-compatible hosts. This should be a much more maintainable > solution. I would prefer for us to find and fix those instances manually, because B_USE_POSITIVE_POSIX_ERRORS is some kind of stopgap measure for porting POSIX utilities like sshfs, and prevents some other functionality from working correctly (i.e. apparently it's an error to -ltracker with it defined, so file dialogs won't work.) Thanks.