From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Date: Tue, 22 Feb 2022 16:09:01 -0700 Message-ID: <8735kawlbm.fsf@melete.silentflame.com> References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> <87bkyzvn84.fsf@athena.silentflame.com> <4cc2bbdb-7296-bada-8def-440cfcb18af1@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8421"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) To: Dmitry Gutov , sbaugh@catern.com, 53626@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 23 00:10:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMeIX-0001z4-BP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Feb 2022 00:10:22 +0100 Original-Received: from localhost ([::1]:58898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMeIV-0006di-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Feb 2022 18:10:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMeIF-0006da-Dc for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 18:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMeIF-0006dy-2e for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 18:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMeIE-0002zM-MT for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 18:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2022 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53626 X-GNU-PR-Package: emacs Original-Received: via spool by 53626-submit@debbugs.gnu.org id=B53626.164557135011392 (code B ref 53626); Tue, 22 Feb 2022 23:10:02 +0000 Original-Received: (at 53626) by debbugs.gnu.org; 22 Feb 2022 23:09:10 +0000 Original-Received: from localhost ([127.0.0.1]:42828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMeHO-0002xg-B3 for submit@debbugs.gnu.org; Tue, 22 Feb 2022 18:09:10 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMeHM-0002xQ-CE for 53626@debbugs.gnu.org; Tue, 22 Feb 2022 18:09:09 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 07A865C0196; Tue, 22 Feb 2022 18:09:03 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 22 Feb 2022 18:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=FaJ6e9AmjgXll732LzBgzbWD+YVvibu9Xz9HtS 6Cans=; b=L4UdDXUzjnpUF+eB+r3IU8CvOjmBG20rkbWzCvG2vIAat+K/BPANK1 Wf8yzd88DApyUKbUXlxAeId3iFgs6R58hrg42rK9djeLXCfDRc2wCc33Dv1pMTMN HrcqUxWcH6U5qsM4WDxp72BpB895Myi+eHxk0lYI6fYeIk2Ud+ju92Kpiq2CfmcR 36nGyWjSvqDK68NXeASeIx5T+FM3KS/VmOlYF/ql4iChTdN3oSSE8ELWyWLUBsGl 7q0kIkfEksGjw2Xy4pNnWRVtkRBLy/bwOJS4uyiaphculqlgo2z/s8tZmRTWSm9U S1qVhDZtrWw9OshZFOhWVVB3AI8L0xRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FaJ6e9AmjgXll732L zBgzbWD+YVvibu9Xz9HtS6Cans=; b=a3R67/4MFI4XtU1+T4LTObfnGFtY4STEp 8NmcuoprW2eaLK+nWwBJv4BBqHGTfy/jKYKLQ+4KOlj/Fgdd+jIftgdJ5O1t4ofI P9B7LCeg34/NBs0fdSwCqdGqVIlu+DPSomWbTfzPuTcvLVLRI+F+nkMlDMdlNKiW Yv2wyI0kZ9RsSgi2sUOM2ddyj1S1Q6wqTxMB1NR9Z2LnKWd6eqfuaB0j2grInj0F x4r87KpoYPWdHmd3mqnODW0xXA7M6bhM/Yq0lqrYQgtTdFoMkTWeFpCoBZda0qu/ Ir8JGkz1dJSIu2j1YnCJICmvRAglmLqdqGBj7ht85ruBDHoNz6vfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeelgddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedugeeg feetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Feb 2022 18:09:02 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 537207E1A7C; Tue, 22 Feb 2022 16:09:01 -0700 (MST) In-Reply-To: <4cc2bbdb-7296-bada-8def-440cfcb18af1@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227463 Archived-At: Hello, On Tue 22 Feb 2022 at 01:14AM +02, Dmitry Gutov wrote: > On 22.02.2022 01:00, Sean Whitton wrote: >> I think I prefer my with-temp-buffer thing to this, to be honest -- >> adding a timer into the mix seems like it might make debugging harder. >> >> Assuming you're still okay with my initial idea, I'll come up with a >> patch to do it with a macro, and apply it across project.el. > > I liked the simplicity of the with-temp-buffer solution, but it doesn't > solve the conceptual problem: that any code trying to let-bind > default-directory around the call for xref-show-xrefs will have > rediscover and solve this problem (or, more likely, live with it for a > few years until somebody notices). Good point. > The timer-based solution is hacky, but it affects only one place (the > xref buffer and the variable in it), so it's easier to verify that it > has the intended effect, and no external callers will need to bother > with additional knowledge (hopefully, of course). Is there no chance of any concurrency issues with this, btw? -- Sean Whitton