From: Michael Heerdegen <michael_heerdegen@web.de>
To: 54119@debbugs.gnu.org
Subject: bug#54119: 29.0.50; Edebug: Jumping commands in recursive definitions
Date: Fri, 25 Feb 2022 04:36:47 +0100 [thread overview]
Message-ID: <8735k7ty5s.fsf@web.de> (raw)
In-Reply-To: <87czjez0jg.fsf@web.de> (Michael Heerdegen's message of "Wed, 23 Feb 2022 05:09:39 +0100")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> #+begin_src emacs-lisp
> (defun my-factorial (n) (if (< n 2) 1 (* n (my-factorial (1- n)))))
> #+end_src
We could exploit the fact that the function is already instrumented.
Every function call of the definition is then wrapped in an
`edebug-after' call:
#+begin_src emacs-lisp
(symbol-function 'my-factorial) ==>
(closure (t) (n)
(edebug-enter 'my-factorial
(list n)
#'(lambda nil
(edebug-after
(edebug-before 0)
12
(if
(edebug-after
(edebug-before 1)
3
(<
(edebug-after 0 2 n)
2))
1
(edebug-after
(edebug-before 4)
11 (* etc...)))))))
#+end_src
We could solve this bug if we temporarily change the function binding of
`edebug-after'. This is a bit tricky, though, mainly because it's not
trivial to restore the original setup:
- two places must be updated: (symbol-function 'edebug-after) and the
entry in `edebug-behavior-alist'
- `edebug-forward-sexp' terminates immediately, it's on the "meta
level", undoing the change in that function is too early, since we
must expect recursive calls of `edebug-after'.
- the actual code is evaluated as an argument of `edebug-after', so the
replacement can also not restore the original function binding
Which means: either we also redefine `edebug-before', or we use
something very different. Here is a proof of concept using
`post-command-hook' for restoring:
#+begin_src emacs-lisp
(defun my-edebug-forward-sexp--around-ad (f &rest args)
(cl-macrolet ((after-fun ()
'(nth 2 (cdr (assq 'edebug edebug-behavior-alist)))))
(let ((orig-after-fun (after-fun)))
(cl-labels ((set-after-fun (f)
(setf (symbol-function 'edebug-after)
(setf (after-fun) f)))
(reset-after-fun ()
(remove-hook 'post-command-hook #'reset-after-fun)
(set-after-fun orig-after-fun)))
(set-after-fun #'edebug-fast-after)
(add-hook 'post-command-hook #'reset-after-fun)
(apply f args)))))
(advice-add 'edebug-forward-sexp :around #'my-edebug-forward-sexp--around-ad)
(advice-add 'edebug-step-out :around #'my-edebug-forward-sexp--around-ad)
#+end_src
Seems to do the job. A patch would not need an advice of course.
Better ideas welcome.
Michael.
next prev parent reply other threads:[~2022-02-25 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 4:09 bug#54119: 29.0.50; Edebug: Jumping commands in recursive definitions Michael Heerdegen
2022-02-25 3:36 ` Michael Heerdegen [this message]
2022-02-26 4:20 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735k7ty5s.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=54119@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).