From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56110: 27+; switching from line-mode to char-mode Date: Sun, 26 Jun 2022 16:49:49 +0200 Message-ID: <8735frqy2a.fsf@web.de> References: <875ykvs9gq.fsf@electra.home.arpa> <87wndaw84w.fsf@web.de> <87sfnyw6m7.fsf@web.de> <877d58obnn.fsf@web.de> <87k097mi81.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9951"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "C. Michailidis" , 56110-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 26 16:51:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5Tbh-0002OJ-FU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 16:51:25 +0200 Original-Received: from localhost ([::1]:59612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5Tbg-0004Bl-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 10:51:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5TbK-0003zI-Fh for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 10:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5TbK-0007pT-7A for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 10:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5TbK-0008BD-6Y for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 10:51:02 -0400 Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2022 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56110 X-GNU-PR-Package: emacs Mail-Followup-To: 56110@debbugs.gnu.org, michael_heerdegen@web.de, signal3@gmail.com Original-Received: via spool by 56110-done@debbugs.gnu.org id=D56110.165625500431344 (code D ref 56110); Sun, 26 Jun 2022 14:51:01 +0000 Original-Received: (at 56110-done) by debbugs.gnu.org; 26 Jun 2022 14:50:04 +0000 Original-Received: from localhost ([127.0.0.1]:48563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5TaO-00089U-JF for submit@debbugs.gnu.org; Sun, 26 Jun 2022 10:50:04 -0400 Original-Received: from mout.web.de ([212.227.15.4]:43759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5TaJ-00088g-NV for 56110-done@debbugs.gnu.org; Sun, 26 Jun 2022 10:50:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1656254990; bh=OgdILGEsT/KgLrR/Ph3foOAPvdBUKopraGkO8expThc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=MT1ZbD9W65ZeVEvPXdqytCAB6bfOaBZ5fWnK6loqZDFzY6TMsRMGSGkIBQV+qtZqh a9Rr5Zb5T3Ga5cM9wGRedfFjdLlQdWx6mziHQzU/gswqZvLJYjG4yunyCAa222+itV hmx3tOTYAatLlKCKIHjRD8r6GIqtA3jze6Onlkf4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MJWsm-1oKobe12Lo-00JxTR; Sun, 26 Jun 2022 16:49:50 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 23 Jun 2022 17:45:55 -0400") X-Provags-ID: V03:K1:ag//ZSHjiV6tkPLPjzgvYzeMC/bjkEnTR6Xv3nYi274EKJ/kazV mgauFIvuRx195H2SMM9hjcCDGZTezM8kPC28AdhUm+aLrPNusLE/0iCQpUMovCPmNsM9ruS gSapsCP3nsWYZzQPW2v19CI2oTEkCLAlHRCa+TmlqPbyaFMpIMTh/JI58p4xoMLZ7mcWq+S 9bjQTMKAwA/nnw45X/d9A== X-UI-Out-Filterresults: notjunk:1;V03:K0:TAg38SAiG2w=:vhRzL39/JDxSo9u/v6u0H2 oEOX/+qcR8/cE3l9ExG0AAUlQAJJIJIW8a3/7v0XQSIFjmsEWgoWySF2cwS7GEW1kaNR38LSY KLHx/9c4es3wWSWAZvAK4f8Ci59EuLtG63t/gL5ikdntI6CFuw+vbDgeZBZ0qlilqDbrAh0PQ Lfuny8PlLzPdnNBh8z/lKx/+i8L9pkn0Br0iSgB8sjqnjJEeMO0fQZb2LAd+ShVDk1NHx1h0V lx5GbpVbBadeMb3oNRK6xO2gUB7RkwPdqtDfR9ohfq+S6Sbtq4bxOKSwhxQV6gIhtBFica05N Q6KGcPgahox8UPc9Z8h7IMxudNAxWIw08glSgma3vhZHxaok9ioRbXF4JJZpJdgCQrYsisqAl CnqjMTtdMBWda+xxocGH5ynClkweIF5AuMqqS+q4iQJ5qjsAbigl99mdqtci/lMtevS+mTys8 tatCqaRyFOVUHYqRIaueX7gSniBQsjYWD43VEU0WqdRjnQG9vCFRuYfgYDKlXmiJ0oivnmt1t gmXm8bSjXh1kZVVt9cs/0pC8kF/VIoYXvRASKsmqe1mtCaSqb17roGtysE4MG4iWAFim+bTKy bG6VF7rvIT7sdFtJQhApcrnasbhzr1YuUWc3KR54QHPl7+q1r+UV/EXb3s9sSVc40yfqafjpP I40FSZYGJRboEAyDMqzcswh19nPls2iEytpfXNoL+7g+ucW6+07dVVKf2Nos5FNSyQp7O0wLj fwj6QoFeJ2cjDfrhSuytWv+Sn8m8qluinzZduwKQ9+i2oQht5HVV56Ue2J1X/sBEv+mhC/Xs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235339 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: > Personally, I prefer using `add/remove-function` and stop worrying about > those risks. After all, that's part of the reason why I developed them. Ok - I have now installed this fix: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-Bug-56110-switching-from-line-mode-to-char-mode.patch Content-Transfer-Encoding: quoted-printable =46rom edf6f5d0cae97de10c914c6e94dc5b35f06ec33c Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Tue, 21 Jun 2022 13:41:51 +0200 Subject: [PATCH] Fix Bug#56110 (switching from line-mode to char-mode) * lisp/term.el (term-char-mode): Make `add-function' override the correct place (the buffer local variable `term-input-sender'). =2D-- lisp/term.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/term.el b/lisp/term.el index 94bf13e973..a8e44b4c34 100644 =2D-- a/lisp/term.el +++ b/lisp/term.el @@ -1467,10 +1467,10 @@ term-char-mode (when (> (point) pmark) (unwind-protect (progn - (add-function :override term-input-sender #'term-send-string) + (add-function :override (local 'term-input-sender) #'term-send-str= ing) (end-of-line) (term-send-input)) - (remove-function term-input-sender #'term-send-string)))) + (remove-function (local 'term-input-sender) #'term-send-string)))) (term-update-mode-line))) (defun term-line-mode () =2D- 2.30.2 --=-=-= Content-Type: text/plain Thanks, Michael. --=-=-=--