From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: daanturo <daanturo@gmail.com>, 56355@debbugs.gnu.org
Subject: bug#56355: 29.0.50; Implement file-parent-directory
Date: Sat, 02 Jul 2022 14:11:48 +0200 [thread overview]
Message-ID: <8735fj3e9n.fsf@gnus.org> (raw)
In-Reply-To: <83wncvbuht.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Jul 2022 14:54:06 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks, but it looks as a very thin wrapper around
> file-name-directory, so I wonder whether we really need a separate
> function fir this.
I think it looks like a handy utility function -- we have quite a few
instances of
(file-name-directory (directory-file-name filename))
(possibly with an expand-file-name in there, too) and using
`file-parent-directory' would both express the intention of the code
better, and be less error prone (because many people forget the
`directory-file-name' in the first attempt).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-07-02 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 11:06 bug#56355: 29.0.50; Implement file-parent-directory daanturo
2022-07-02 11:54 ` Eli Zaretskii
2022-07-02 12:02 ` daanturo
2022-07-02 12:11 ` Lars Ingebrigtsen [this message]
2022-07-02 15:29 ` Drew Adams
2022-07-02 18:24 ` daanturo
2022-07-04 11:08 ` Lars Ingebrigtsen
2022-08-31 10:26 ` daanturo
2022-09-01 10:08 ` Lars Ingebrigtsen
2022-09-01 4:11 ` daanturo
2022-09-04 14:38 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735fj3e9n.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=56355@debbugs.gnu.org \
--cc=daanturo@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).