From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56002: src/process.c; make-process fails to clean up stderr process on early exit Date: Mon, 08 Aug 2022 13:36:58 +0200 Message-ID: <8735e70xwl.fsf@gnus.org> References: <83pmj9qjgk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36544"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 56002@debbugs.gnu.org To: Tom Gillespie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 08 13:38:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oL15I-0009Hl-93 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Aug 2022 13:38:12 +0200 Original-Received: from localhost ([::1]:34866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oL15G-0000Dg-HP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Aug 2022 07:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oL158-0000DW-Oa for bug-gnu-emacs@gnu.org; Mon, 08 Aug 2022 07:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oL158-0004fX-FM for bug-gnu-emacs@gnu.org; Mon, 08 Aug 2022 07:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oL158-0005Cr-80 for bug-gnu-emacs@gnu.org; Mon, 08 Aug 2022 07:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Aug 2022 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56002 X-GNU-PR-Package: emacs Original-Received: via spool by 56002-submit@debbugs.gnu.org id=B56002.165995863019954 (code B ref 56002); Mon, 08 Aug 2022 11:38:02 +0000 Original-Received: (at 56002) by debbugs.gnu.org; 8 Aug 2022 11:37:10 +0000 Original-Received: from localhost ([127.0.0.1]:39370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL14I-0005Bm-4a for submit@debbugs.gnu.org; Mon, 08 Aug 2022 07:37:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL14G-0005Ba-Fq for 56002@debbugs.gnu.org; Mon, 08 Aug 2022 07:37:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=70VI/9wFARy8je6sxz9cEFO1uGXl+pA0tPmqPshS7fA=; b=c4+2fp3JVMUrI0GiBrdcFg9WZ9 JyTY4dR2S4Yt2FaCaCb9wBDyLmk83LwL1fp6n7QYW6P/0PZHhGSVQHSa2OCLZ8+QjlXrxkKedShrr k7X8WMuKsLDevt2AMogmeYwuKKJcrZKs8+JiLJAXPF4GklrglJ7WHlDES0ED5eIQ78lw=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oL147-00005h-GZ; Mon, 08 Aug 2022 13:37:01 +0200 In-Reply-To: (Tom Gillespie's message of "Sun, 7 Aug 2022 16:48:44 -0700") X-Now-Playing: Dzyan's _Deutsche Elektronische Music 4 (2)_: "Dragonsong" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239108 Archived-At: Tom Gillespie writes: > * src/process.c (Fmake_process): Move the call to create the stderr > process as late as possible to avoid having to clean up stderrproc in > the event of an error prior to the call to create_process. This change > is needed to ensure that when called with :query-stderr t (aka the > default behavior prior to the addition of :query-stderr) make-process > will not leak the stderr process if a call to make-process fails. > Also adds a new keyword argument :query-stderr to control whether to > query on exit the stderr process (if one is created). (bug#56002) I think this makes sense... Eli, any comments?