From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#57176: 29.0.50; Commit 744ed0ce applies outline-minor-mode-highlight-buffer repeatedly Date: Wed, 17 Aug 2022 09:57:59 +0200 Message-ID: <8735dvfgjc.fsf@rub.de> References: <87edxi9cly.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12604"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: daanturo , 57176@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 17 09:59:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oODxN-000373-3U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 09:59:17 +0200 Original-Received: from localhost ([::1]:39152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oODxL-0003Zp-Up for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 03:59:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oODx9-0003XR-EM for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 03:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oODx8-0005kh-DA for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 03:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oODx8-0003dg-5t for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 03:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2022 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57176 X-GNU-PR-Package: emacs Original-Received: via spool by 57176-submit@debbugs.gnu.org id=B57176.166072309613935 (code B ref 57176); Wed, 17 Aug 2022 07:59:02 +0000 Original-Received: (at 57176) by debbugs.gnu.org; 17 Aug 2022 07:58:16 +0000 Original-Received: from localhost ([127.0.0.1]:49369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oODwL-0003cf-RI for submit@debbugs.gnu.org; Wed, 17 Aug 2022 03:58:15 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:37405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oODwH-0003cN-1u for 57176@debbugs.gnu.org; Wed, 17 Aug 2022 03:58:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660723082; bh=mm6Mx/M4ryjN4CU3UXJzb+BQ+YNIiKjebazNGKySm60=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=SoRvCaVcDeaA/QZ37kshuwozIPY8S2S+R2Dj+eShpWooUSgXNhroI25HmBQh6bpTM iQHMCkaWFC61sBot/znhCdJLOPNaeZYsxYF9XYYCfCDpbtKRcbHbfVmRSQC+i7WUF8 6pgKUIxOcEvdTTUBdmDx+JQtYNpNxzKC2dUO3Zp4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs2 ([89.246.38.165]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mr9Bk-1nb9Lw1QM2-00oHgh; Wed, 17 Aug 2022 09:58:02 +0200 In-Reply-To: <87edxi9cly.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 15 Aug 2022 09:42:33 +0200") X-Provags-ID: V03:K1:YNhvaJfQ5LOF9VVAEZqux6itZdordKJw5nzIJwHun60kJG2CmyG 9054KYwxYDaUUibpjlTMNgNay9doOcuEIhytZ1B2pxiIFzyCuey1EcpHdfNRKwZxZIddYMO bJaWphKS+2U/LiIZ6WHY5vwzcQbPfdWt91Ahw0YIi9dp9OEndKUoTC+Sig5VP/Ui2fiSVso V8eWepvj9AyZVwQccRzlg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Zh48OP9cFJ8=:SV7H5WaI/sOMcwh4t8v1s1 z+RIXBfK1ypau+Db8gYK1jJ06la+DGrOV0K4rPLiFwD8JfuhQmNPM1cNjyIfD+10gZoroSFkX 0O9axQglXb1SxaC61yjKfrfZ06JjeA0ReZPQp9QT2pfs98FaNheQamB7yHKAJN5/1ZhVqXL13 tJoRHT7hcP7EEeaQqArLEWVCyYp6CQ1RxmYmjq7meJ0MB8bI2u7grhoC+g+GvLdgk9hi1lkq/ zOJrq6Cskj9u5w7Hz8BSvrtduX2L0poYMT4U7aaEW+3R0gWVvmCJFqSvFNY1uC3uSjXCqfK8L U2YsMTeJg/Jglvf5e+fNJHtpZRvGIpEjhPyVul166ljatNCmfCbe15zPqmwRXpxb9vQUlC+J5 FoMvdcEHLOAVlrotBtvld+w6Uvsq12Qq/c+mhRlgZuVhoEWUgywo5nCM3NoxALC63TsGJrS7M 9VQqoRjVw+/wOVX/wLOwY701lVxwPD9PpZfUuTLKxDnifHn7d4BUAg/yFwgGifbbt4pS5WmYo asYNk+QeG8mEIUXYAnQ4YuVrSRQs1ndKzOKbJRXdkNCka+4o29qddjFMOKDXcCj/xSprETnWO Uzlo/kyATZa3+TODw6SV4aLtHbkO6RzuhsO0gc3PelrtrXA4eB/t3/oA7QdojbZuzkuqpZzGt z9JZ//JmB3fnsU6g5of/RSxGT1gCspO93e+qX4xbs5m8XJ679GJEBQxBNuALt4WO1DJJnsSXV 6I2QFp9dBLZdOW6zzIuB7cTFcXp1E15JY86XC5TLbquR10aCkEWu87esI/O1Eb7XirBkf7PQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240031 Archived-At: On Mon, 15 Aug 2022 09:42:33 +0200 Lars Ingebrigtsen wrote: > daanturo writes: > >> I think we should clear old outline overlays before applying new ones, >> or adjust the conditions like the old one. > > I guess this might be the result of this change? > > - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) > - (progn > - (font-lock-add-keywords nil outline-font-lock-keywords t) > - (font-lock-flush)) > - (outline-minor-mode-highlight-buffer))) > + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) > + (font-lock-add-keywords nil outline-font-lock-keywords t) > + (font-lock-flush)) > + (outline-minor-mode-highlight-buffer)) > > I've added Stephen to the CCs; perhaps he has some comments. Sorry for the late response. Juri Linkov already noted a probably related problem with my patch, see <86sfm4q6nu.fsf@mail.linkov.net>. I'm afraid my reply to his message still holds: >> I'm not familiar enough with the intricacies of font-lock to whip >> up a quick fix and can't afford to spend a lot of time on it, so I hope >> someone better qualified than me will do it. Juri replied to that: > I guess what is needed here is to find the right place to call > outline--fix-up-all-buttons on first visiting the NEWS buffer. but I haven't had time to look into that, nor whether that would also work for bug#57176. Steve Berman