From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57825: 29.0.50; Superkey handling regression in pgtk Date: Mon, 19 Sep 2022 15:22:18 +0800 Message-ID: <8735cnsuad.fsf@yahoo.com> References: <87v8pp6msk.fsf@trop.in> <87o7vgyjyy.fsf@yahoo.com> <87mtb0q71l.fsf@trop.in> <87k063x401.fsf@yahoo.com> <87y1uggdmp.fsf@trop.in> <87r107zvnb.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15638"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: masmer4@yahoo.co.jp, 57825@debbugs.gnu.org, Andrew Tropin To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 09:24:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaB8d-0003ug-5b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 09:24:19 +0200 Original-Received: from localhost ([::1]:47160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaB8c-0005q5-8f for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 03:24:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaB7O-0005of-Al for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaB7O-0008Ko-2K for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaB7N-0004Vh-Tn for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 07:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57825 X-GNU-PR-Package: emacs Original-Received: via spool by 57825-submit@debbugs.gnu.org id=B57825.166357215717290 (code B ref 57825); Mon, 19 Sep 2022 07:23:01 +0000 Original-Received: (at 57825) by debbugs.gnu.org; 19 Sep 2022 07:22:37 +0000 Original-Received: from localhost ([127.0.0.1]:52122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaB6z-0004Ul-5z for submit@debbugs.gnu.org; Mon, 19 Sep 2022 03:22:37 -0400 Original-Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:38638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaB6x-0004UY-BC for 57825@debbugs.gnu.org; Mon, 19 Sep 2022 03:22:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663572147; bh=KghQwi6PFURc/+Tph5AC0kACAD5ignMEJvIm3yjRv1Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=MUkHhKdyu+fvDtS2JTtZ5GS8q3zHiT/rkOFm7ZQ8vzTWc0QC4UejO9HsQPH4pm+6k1TvOC4O9nHuqzJWEsMGfAS+ZOy1UoIsZJw4/zs52S30Uvh5OaY6Wr9KhHkVSPUGCPOogle0iciQcp1FoowZczy427s6mIw9Kl1pDug5AvQ3th2jNzUbxkEtfiKGPDBsj6GqZj2Mq0ufzWLO7JRi9lEySBv8/Vt8TgnG1XA6Iei2qThNzXFfKhFVyJVag0h7bx/vk1NpwMYJNCxyLxf2aTWxG7Sim2nXKc05EZrjdjCuFNtSQnr5ldb8qJsabrSCjh/i+zXpY9ThGzO5VGy/Og== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663572147; bh=E0KDeve2evP2zWQdV62AeGELTnpixCJ66qnmgxRfDEa=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Wck/VhRYcYmBGQV4GqpKPlai7veth+A8oyKMRC7NO/YK0Gni02umJpvuT49m0BFPcINdqFOjEFvQ5S4egA343eKNmqHvuu7aq5mhbMN6oxDQLvtGBS4+Ob9QocNZ922s8jUUN1HBaUJsSFgRd4dI6y+nuo324J+EWlbhvGVbYz35sC9ZjDO7jrrJO+4Ii2jCbwnZzewIEzzrCqe+hCwzsTfZpd1X7fEZNBoeHcbijofozcaNpuYZMpb7Ewzuk45iiIniOVM+IrQ9PJiFobjuQL0Xqdskta975F+5x0VQM77LaPPdPZxb3O8OKYIdLnE5Q5q799coFfNIoCrMhZM4/g== X-YMail-OSG: R3ZAn20VM1kuW9ap357Ps63hVkIsrXygr4N5k2Xwo7oFJ5d_qzSecpZFWvH5Or4 fxHg..EJqj8GLxbmWeIW2sUkTz7iYwzeyGYizno5b.AKplLAnuec_r9jW4IxlcHU4i5c8HghJ9SB nchpZDXuXY3qmIEXkJ7Pb0PTKXJ4LX4jTfifO0BP6XC5njy1kx_338Vu.OSkrt8vdoGWUtYDVj7U bJgcGz3J_9cb4i2udkKQYcd2IXcKzFftxzAOjNvg_nKS8KsIhB.0sHe8XhGl49NOjbR.78CEuv18 QrIO0U0t3cvChOVou2ftimGnjT2rlhsZZIlDRdW4pCDZjLwMAhyfrzzZbYMhWumOSCp9uoADNE5K CY291oCZIR.5vEsz0W9b9rgF1kpmNSnV4WRLjklTa98ZqoJ6Xlq8.Po3SURUhBI9aicE1susIvpY OOa8DRLJFG5Jnj0YGDG0M_n2ga7.sQNH_AixpdVbrg4UZtfTD6L2DthaXH5tB0uk6cYfqKSNfmsR T0DrVEyVyboLjKn0zwe4Qo_68IDBhgaLFnagmn_SIQ3z297IuydZ57A32_g_eMs7IEzROES99TfY HojklKtOJrYo3XcWaT09hH_ourqvrbVGl283q7K4kzyTREn4NPHuGvVZqETjqXyEgB0JVVPn0lWx YLTk.AXs7EiyUITaKLNrCI21Mflg0GcVia6PGXweirW2qI0BNiHtmhWpeAFWTTdAFOdpP95OKrPt rkqDXQT4dMXpaCGBRE9yV2tgy0tdJQT6jw0LIOzqwCTTb2d2EiBmYe6fYw9ZodsKsjWFlba8bTzw LeuNOeIfGrBVlFZ9In.92J_hcHHu9RBzBY7TOKvB7w X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Mon, 19 Sep 2022 07:22:27 +0000 Original-Received: by hermes--canary-production-sg3-6bb8946c47-wlcqj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bbcbd9e600181577624f6c913e9cf618; Mon, 19 Sep 2022 07:22:24 +0000 (UTC) In-Reply-To: <87r107zvnb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 09:11:04 +0200") X-Mailer: WebService/1.1.20612 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243035 Archived-At: Lars Ingebrigtsen writes: > Andrew Tropin writes: > >> and applied this workaround: >> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=77e768ac4e57d5fd443c7d69a7cc0c8339d0c238 >> >> the logic in the code is not completely correct, but should work for >> most users and use cases, we will remove it, once the problem is fixed >> in GTK and gtk package is updated. > > For future reference, I've included the patch below. > > Perhaps we should apply something like this to Emacs? > > diff --git a/gnu/packages/patches/emacs-pgtk-super-key-fix.patch b/gnu/packages/patches/emacs-pgtk-super-key-fix.patch > new file mode 100644 > index 0000000..a58c448 > --- /dev/null > +++ b/gnu/packages/patches/emacs-pgtk-super-key-fix.patch > @@ -0,0 +1,49 @@ > +From a897516fc5ec380938115ad42023f279d128fc1e Mon Sep 17 00:00:00 2001 > +From: Andrew Tropin > +Date: Fri, 16 Sep 2022 15:24:19 +0300 > +Subject: [PATCH] Workaround gtk bug for superkey handling > + > +https://gitlab.gnome.org/GNOME/gtk/-/issues/4913 > +https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55362 > +Patch based on Thomas Jost's suggestion. > + > +--- > + src/pgtkterm.c | 9 +++++---- > + 1 file changed, 5 insertions(+), 4 deletions(-) > + > +diff --git a/src/pgtkterm.c b/src/pgtkterm.c > +index 491ba33882..d5a9970693 100644 > +--- a/src/pgtkterm.c > ++++ b/src/pgtkterm.c > +@@ -5051,7 +5051,7 @@ pgtk_gtk_to_emacs_modifiers (struct pgtk_display_info *dpyinfo, int state) > + mod |= mod_ctrl; > + if (state & GDK_META_MASK || state & GDK_MOD1_MASK) > + mod |= mod_meta; > +- if (state & GDK_SUPER_MASK) > ++ if (state & GDK_SUPER_MASK || state & GDK_MOD4_MASK) > + mod |= mod_super; > + if (state & GDK_HYPER_MASK) > + mod |= mod_hyper; > +@@ -5184,7 +5184,7 @@ key_press_event (GtkWidget *widget, GdkEvent *event, gpointer *user_data) > + /* While super is pressed, the input method will always always > + resend the key events ignoring super. As a workaround, don't > + filter key events with super or hyper pressed. */ > +- if (!(event->key.state & (GDK_SUPER_MASK | GDK_HYPER_MASK))) > ++ if (!(event->key.state & (GDK_SUPER_MASK | GDK_MOD4_MASK | GDK_HYPER_MASK))) > + { > + if (pgtk_im_filter_keypress (f, &event->key)) > + return TRUE; > +@@ -5199,8 +5199,9 @@ key_press_event (GtkWidget *widget, GdkEvent *event, gpointer *user_data) > + /* make_lispy_event turns chars into control chars. > + Don't do it here because XLookupString is too eager. */ > + state &= ~GDK_CONTROL_MASK; > +- state &= ~(GDK_META_MASK > +- | GDK_SUPER_MASK | GDK_HYPER_MASK | GDK_MOD1_MASK); > ++ state &= ~(GDK_META_MASK | GDK_MOD1_MASK > ++ | GDK_SUPER_MASK | GDK_MOD4_MASK > ++ | GDK_HYPER_MASK); > + > + nbytes = event->key.length; > + if (nbytes > copy_bufsiz) > +-- > +2.37.3 No, because this will break on other Wayland compositors, including one that I am writing.