From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 58288@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
ajd2195@columbia.edu, larsi@gnus.org
Subject: bug#58288: 29.0.50; (flyspell-correct-word-before-point) followed by <down> crashes emacs
Date: Wed, 05 Oct 2022 18:46:48 +0800 [thread overview]
Message-ID: <8735c2wns7.fsf@yahoo.com> (raw)
In-Reply-To: <87fsg28sxt.fsf@gmail.com> (Robert Pluim's message of "Wed, 05 Oct 2022 12:29:18 +0200")
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Wed, 05 Oct 2022 13:06:52 +0300, Eli Zaretskii <eliz@gnu.org> said:
> >> void
> >> save_menu_items (void)
> >> {
> >> Lisp_Object saved = list4 (menu_items_inuse ? menu_items : Qnil,
> >> make_fixnum (menu_items_used),
> >> make_fixnum (menu_items_n_panes),
> >> make_fixnum (menu_items_submenu_depth));
> >> record_unwind_protect (restore_menu_items, saved);
> >> menu_items_inuse = false;
> >> menu_items = Qnil;
> >> }
> >>
> >> This fixes it, but it seems a bit dodgy to me, why has no other
> >> platform ever run into this?
>
> Eli> How come a menu is in use, but menu_items_inuse is zero?
>
> `menu_items_inuse' is not zero, itʼs false. `menu_items_used' is
> non-zero. I guess something called `unuse_menu_items', and the
> assumption is then that `menu_items' will not be accessed (but then
> why save away `menu_items_used' etc?
>
> menu.c says:
>
> /* Whether the global vars defined here are already in use.
> Used to detect cases where we try to re-enter this non-reentrant code. */
> bool menu_items_inuse;
>
> so should we be adding "if (menu_items_inuse)" guards everywhere?
>
> Robert
No matter how much I try I cannot reproduce this (or bug#58296) on
GNUstep, and I don't have access to Mac OS anymore.
But after the holidays are over I will be able to test stuff on a Mac
and will look into this.
Thanks.
next prev parent reply other threads:[~2022-10-05 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 21:20 bug#58288: 29.0.50; (flyspell-correct-word-before-point) followed by <down> crashes emacs Andrew John De Angelis
2022-10-04 11:19 ` Lars Ingebrigtsen
2022-10-04 12:32 ` Eli Zaretskii
2022-10-04 13:16 ` Robert Pluim
2022-10-04 13:47 ` Eli Zaretskii
2022-10-04 15:14 ` Robert Pluim
2022-10-04 16:30 ` Eli Zaretskii
2022-10-05 10:01 ` Robert Pluim
2022-10-05 10:06 ` Eli Zaretskii
2022-10-05 10:29 ` Robert Pluim
2022-10-05 10:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-10-05 13:53 ` Robert Pluim
2022-10-06 2:35 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735c2wns7.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=58288@debbugs.gnu.org \
--cc=ajd2195@columbia.edu \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).