From: Felix <felix.dick@web.de>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 57781@debbugs.gnu.org, Sean Whitton <spwhitton@spwhitton.name>
Subject: bug#57781: missing wallpaper command
Date: Fri, 07 Oct 2022 21:55:13 +0200 [thread overview]
Message-ID: <8735bzjtmf.fsf@web.de> (raw)
In-Reply-To: <CADwFkmnRt23kiDLFwP0YhA57MGB__nkNaBOdDLGfuj1Vup5Xdg@mail.gmail.com>
Stefan Kangas <stefankangas@gmail.com> writes:
> [Please use "Reply to all" so that the discussion
> is recorded in the bug tracker.]
>
> Felix <felix.dick@web.de> writes:
>
>>> [2. text/x-diff; 0001-Fix-setting-the-wallpaper-with-swaybg-and-wbg.patch]...
>>
>> It doesn't work on my side.
>> Here is the debug log
>>
>> Debugger entered--Lisp error: (wrong-type-argument numberp nil)
>> number-to-string(nil)
>> (and (fboundp 'x-window-property) (display-graphic-p) (number-to-string (or (x-window-property "_NET_CURRENT_DESKTOP" nil "CARDINAL" 0 nil t) (x-window-property "WIN_WORKSPACE" nil "CARDINAL" 0 nil t))))
>> (or (and (fboundp 'x-window-property) (display-graphic-p) (number-to-string (or (x-window-property "_NET_CURRENT_DESKTOP" nil "CARDINAL" 0 nil t) (x-window-property "WIN_WORKSPACE" nil "CARDINAL" 0 nil t)))) "0")
>> (cons 87 (or (and (fboundp 'x-window-property) (display-graphic-p) (number-to-string (or (x-window-property "_NET_CURRENT_DESKTOP" nil "CARDINAL" 0 nil t) (x-window-property "WIN_WORKSPACE" nil "CARDINAL" 0 nil t)))) "0"))
>> (list (cons 102 (expand-file-name file)) (cons 70 (mapconcat #'url-hexify-string (file-name-split file) "/")) (cons 104 #'(lambda nil (wallpaper--get-height-or-width "height" #'display-pixel-height wallpaper-default-height))) (cons 119 #'(lambda nil (wallpaper--get-height-or-width "width" #'display-pixel-width wallpaper-default-width))) (cons 83 (let ((display (frame-parameter (selected-frame) 'display))) (if (and display (string-match ":[0-9]+\\.\\([0-9]+\\)\\'" display)) (match-string 1 display) "0"))) (cons 77 #'wallpaper--x-monitor-name) (cons 87 (or (and (fboundp 'x-window-property) (display-graphic-p) (number-to-string (or (x-window-property "_NET_CURRENT_DESKTOP" nil "CARDINAL" 0 nil t) (x-window-property "WIN_WORKSPACE" nil "CARDINAL" 0 nil t)))) "0")))
>> (format-spec format (list (cons 102 (expand-file-name file)) (cons 70 (mapconcat #'url-hexify-string (file-name-split file) "/")) (cons 104 #'(lambda nil (wallpaper--get-height-or-width "height" #'display-pixel-height wallpaper-default-height))) (cons 119 #'(lambda nil (wallpaper--get-height-or-width "width" #'display-pixel-width wallpaper-default-width))) (cons 83 (let ((display (frame-parameter (selected-frame) 'display))) (if (and display (string-match ":[0-9]+\\.\\([0-9]+\\)\\'" display)) (match-string 1 display) "0"))) (cons 77 #'wallpaper--x-monitor-name) (cons 87 (or (and (fboundp 'x-window-property) (display-graphic-p) (number-to-string (or (x-window-property "_NET_CURRENT_DESKTOP" nil "CARDINAL" 0 nil t) (x-window-property "WIN_WORKSPACE" nil "CARDINAL" 0 nil t)))) "0"))))
>> wallpaper--format-arg("%f" "~/wallpapers/bloom.jpg")
>> (closure ((args "%f") (file . "~/wallpapers/bloom.jpg") cl-struct-wallpaper-setter-tags t) (arg) (wallpaper--format-arg arg file))("%f")
>> mapcar((closure ((args "%f") (file . "~/wallpapers/bloom.jpg") cl-struct-wallpaper-setter-tags t) (arg) (wallpaper--format-arg arg file)) ("%f"))
>> (let* ((args (if (functionp wallpaper-command-args) (funcall wallpaper-command-args) wallpaper-command-args)) (real-args (mapcar #'(lambda (arg) (wallpaper--format-arg arg file)) args)) (bufname (format " *wallpaper-%s*" (random))) (setter (and (progn (and (memq (type-of wallpaper--current-setter) cl-struct-wallpaper-setter-tags) t)) (equal (progn (or (progn ...) (signal ... ...)) (aref wallpaper--current-setter 2)) wallpaper-command) wallpaper--current-setter)) (init-action (and setter (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... setter))) (aref setter 5)))) (detach (and setter (progn (or (progn (and ... t)) (signal 'wrong-type-argument (list ... setter))) (aref setter 6)))) process) (if init-action (progn (funcall init-action))) (wallpaper-debug "Using command: \"%s %s\"" wallpaper-command (string-join real-args " ")) (if detach (apply #'call-process wallpaper-command nil 0 nil real-args) (setq process (apply #'start-process "set-wallpaper" bufname wallpaper-command real-args)) (let* ((v process)) (set-process-sentinel v #'(lambda (process status) (unwind-protect (if ... ... ...) (condition-case nil ... ...)))))) process)
>> wallpaper-default-set-function("~/wallpapers/bloom.jpg")
>> funcall(wallpaper-default-set-function "~/wallpapers/bloom.jpg")
>> wallpaper-set("~/wallpapers/bloom.jpg")
>> (progn (wallpaper-set "~/wallpapers/bloom.jpg"))
>
> Thanks. This error was unrelated to the patch, but should now be fixed
> on the master branch (commit 55bd6a5cd4). Could you please pull latest
> master, re-apply the patch, and then try again?
Now it works!
Nice one!
next prev parent reply other threads:[~2022-10-07 19:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 20:20 bug#57781: missing wallpaper command Felix
2022-09-14 5:41 ` Stefan Kangas
2022-09-14 17:00 ` Sean Whitton
2022-09-14 22:51 ` Stefan Kangas
2022-09-14 22:51 ` Felix
2022-09-14 23:22 ` Stefan Kangas
2022-09-15 9:47 ` Felix
2022-09-16 21:09 ` Stefan Kangas
2022-09-17 12:00 ` Felix
2022-09-17 17:48 ` Stefan Kangas
2022-09-18 11:16 ` Felix
2022-09-19 9:40 ` Stefan Kangas
2022-09-18 22:19 ` Felix
2022-09-19 9:40 ` Stefan Kangas
2022-09-19 17:19 ` Felix
2022-09-19 19:16 ` Stefan Kangas
2022-09-19 19:26 ` Felix
2022-09-19 20:07 ` Stefan Kangas
2022-09-19 21:04 ` Felix
2022-09-15 10:37 ` Felix
2022-09-16 21:09 ` Stefan Kangas
2022-09-16 15:50 ` Thierry Volpiatto
2022-09-16 20:52 ` Stefan Kangas
2022-09-17 6:14 ` Thierry Volpiatto
2022-09-17 18:34 ` Stefan Kangas
2022-09-18 3:33 ` Thierry Volpiatto
2022-10-04 5:58 ` Stefan Kangas
[not found] ` <87v8owv8lc.fsf@web.de>
2022-10-07 9:08 ` Stefan Kangas
2022-10-07 19:55 ` Felix [this message]
2022-10-07 20:16 ` Stefan Kangas
2022-09-14 23:25 ` Sean Whitton
2022-09-14 13:50 ` bug#57781: wbg " Felix
2022-09-14 16:27 ` Stefan Kangas
2022-09-14 20:01 ` Felix
2022-09-14 23:06 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735bzjtmf.fsf@web.de \
--to=felix.dick@web.de \
--cc=57781@debbugs.gnu.org \
--cc=spwhitton@spwhitton.name \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).