From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows Date: Thu, 13 Oct 2022 13:30:39 +0200 Message-ID: <8735bs7yg0.fsf@gnus.org> References: <82k055fsos.fsf@gmail.com> <87y1tlcn7u.fsf@gnus.org> <83czaxchgp.fsf@gnu.org> <87mta1b2p9.fsf@gnus.org> <83sfjtazln.fsf@gnu.org> <87edvdays6.fsf@gnus.org> <83leplavfs.fsf@gnu.org> <871qrdavc6.fsf@gnus.org> <83ilkpauuz.fsf@gnu.org> <87r0zc88fn.fsf@gnus.org> <83wn949fui.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40908"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: pquessev@gmail.com, Paul Eggert , 58464@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 13:33:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiwT4-000AMy-EB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 13:33:38 +0200 Original-Received: from localhost ([::1]:58648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiwT3-0002f4-1F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 07:33:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiwRX-0001sv-6y for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 07:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiwRW-0002Cg-Oo for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 07:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiwRW-0001a7-JP for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 58464-submit@debbugs.gnu.org id=B58464.16656606675983 (code B ref 58464); Thu, 13 Oct 2022 11:32:02 +0000 Original-Received: (at 58464) by debbugs.gnu.org; 13 Oct 2022 11:31:07 +0000 Original-Received: from localhost ([127.0.0.1]:59735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiwQb-0001YO-VE for submit@debbugs.gnu.org; Thu, 13 Oct 2022 07:31:06 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiwQP-0001Xi-GH for 58464@debbugs.gnu.org; Thu, 13 Oct 2022 07:31:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rAUFEwSRXDQnmS/b4Q4LiFaZmfg2iCPpfVR5bV30/Ac=; b=Qf9YDgwhTP18WE1baqxKvIJBlg m/Aeb8Lu/pQYInmtToqT0OH6WQphzjztIsfBDCseQyouYX/Z1ZYYeGm4G/JoLmwe/PvbS/3/ELns2 TlBHtMFDhnV4mVElFc/UAdopJRyaDoQltG32GLudPeXqsgmvKgcdX7emCF2N9p1fDFPw=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiwQE-0007Qi-Rb; Thu, 13 Oct 2022 13:30:45 +0200 In-Reply-To: <83wn949fui.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Oct 2022 13:29:25 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXY1MKSZ2BIRD// ////4AazAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YKDQseDGWxDlYAAAF0SURBVCjPPdGxittAEAbg kbndQpUPbIOuT8j5KVaQpEilwiM4VSbYAe9T+Mp0m8Pr4ioXWrH7P2VmZckCCT5mZjX6RSpgaJI/ UL6UQ9ghTDjbcIDvZ6Qv+Ddji9VwnbH52AETnL72QLzjViA8KpG2vpsrOyJmWt4h95rlwUagnFJs tp75Rqrq7TsbRIU9qdOp3bMJsURDaoOrYzoeXq20PffDuaLV8lsp+Or+mCeqmtffAtAL0bJyqmhI w7w4LcuV9VIqnx9RI9m/TxkIURMw9CNOURsAjjJ+xNJbtOeMcIllY2ORt8bgL4uA2/gJ+IRbBDuh Rd8m7UYkRuwiNRnas43cm9VUsXF9JvV9nPFd1BfSv6RRcfU29t/TKbxkxTmcHNXxp2yGCaqTF/sp RGWB7YxC0D0gE5154FZ0bp5JRNPWI2qE+eh13dhEOR2B/CmbTH3HnhZIVIxtuqcNQIsRZaK8m2Sd gRpITroV7RS3wfLxrfkPV1CbwxASRxcAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMTAtMTNUMTE6 MzA6MTIrMDA6MDBri6TAAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTEwLTEzVDExOjMwOjEyKzAw OjAwGtYcfAAAAABJRU5ErkJggg== X-Now-Playing: Jane's _Make More Noise (3)_: "It's A Fine Day" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245295 Archived-At: Eli Zaretskii writes: > Thanks. But this part: > > - if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0) > + if (save_errno != 0) > > might cause us signal an error when VISIT is nil, something that > didn't happen before. > > (I also am not sure it is 100% reliable to rely on save_errno being > non-zero whenever we encounter an error, especially in the > file-handlers case.) That's Paul's change -- added to the CCs.