From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Thu, 13 Oct 2022 10:35:51 +0000 Message-ID: <8735bs3ta0.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> <87y1udlzlt.fsf@posteo.net> <87o7v953uf.fsf@gnus.org> <87tu50nca7.fsf@posteo.net> <87a6652lyb.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> <87wn98nlhq.fsf@gnus.org> <87lepo9c1e.fsf@posteo.net> <87r0zfkxzx.fsf@gnus.org> <87pmeyg24x.fsf@posteo.net> <87edvef8nc.fsf@gnus.org> <871qre2l63.fsf@posteo.net> <875ygqf7pc.fsf@gnus.org> <87r0ze15rt.fsf@posteo.net> <871qref5mq.fsf@gnus.org> <875ygohztx.fsf@posteo.net> <83tu489fm6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21630"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 57639@debbugs.gnu.org, info@protesilaos.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 12:49:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oivmd-0005NP-Fs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 12:49:47 +0200 Original-Received: from localhost ([::1]:39754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oivmc-0002zE-GL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 06:49:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivaJ-000348-Vy for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:37:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oivaI-0000T6-8t for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oivaH-0006O6-Ta for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 10:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166565736724469 (code B ref 57639); Thu, 13 Oct 2022 10:37:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 13 Oct 2022 10:36:07 +0000 Original-Received: from localhost ([127.0.0.1]:59695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivZO-0006Ma-Ij for submit@debbugs.gnu.org; Thu, 13 Oct 2022 06:36:06 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:58299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivZJ-0006Lz-GQ for 57639@debbugs.gnu.org; Thu, 13 Oct 2022 06:36:04 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A0E73240104 for <57639@debbugs.gnu.org>; Thu, 13 Oct 2022 12:35:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665657355; bh=aLyEI0LUKDN7Oloi8aFFh5jIYtDfBfxZYR5RvaamG+c=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=B+NvKHFNknKCYlO9PzZXfbv3tUTISVSnyANj9JgXCAqLpXhXuwVQvN9G/erCL6uVG CWcp++cTQXphks/eV6UTRzQSbq9l2trjfNfdRt9ewwFYRiiSWOMyFqh0IzUFtUcNZS 0ZLxxAtw7eOIwHGtUeqEUJaIeGXg6TIjrtSZmItWQbfeRniI0uehpx4cqk3r20sGO5 vfXM6n550EEBKUFQWvsp8eDdJvotkGuUXMHDhaMszT3PDP4tuK0AfAd10/wXSdE8XB uaJvlsIYDeXbyUI9GQ2ZhDsCdhoeiPSePj00AUdISh7ZkMljUhVlRhNnvY5/SNcT20 O6CAB5G56X4Gg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mp5X73F5tz6tmp; Thu, 13 Oct 2022 12:35:51 +0200 (CEST) In-Reply-To: <83tu489fm6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Oct 2022 13:34:25 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245291 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Eli Zaretskii , 57639@debbugs.gnu.org, Protesilaos >> Stavrou >> Date: Thu, 13 Oct 2022 08:50:34 +0000 >> >> Lars Ingebrigtsen writes: >> >> > Philip Kaludercic writes: >> > >> >> Great, can you point me to the places I would have to make changes for >> >> this to work: >> >> >> >> add a function to loaddefs-gen that only fetched those for the >> >> Emacs build (it'd almost be trivial -- we just bind >> >> lisp-mode-autoload-regexp to ";;;###theme-autoload" and then >> >> point the scraping function at etc/themes). >> > >> > I think you'd basically put something like the following into >> > `loaddefs-generate--emacs-batch' -- >> > >> > (let ((lisp-mode-autoload-regexp >> > "^;;;###\\(\\(noexist\\)-\\)?\\(theme-autoload\\)")) >> > (loaddefs-generate >> > (expand-file-name "../etc/themes/" lisp-directory) >> > (expand-file-name "theme-loaddefs.el" lisp-directory))) >> > >> > Then you have to teach `loaddefs-generate--make-autoload' to generate >> > the correct forms as a result of the `deftheme' -- which should be some >> > `put's. >> >> OK, it looks like this worked. Just to recap, these are the proposed >> changes: > > What, if anything, does this mean for themes that aren't bundled with > Emacs? Nothing for now, but I could add support for package.el. > Also, this needs a NEWS entry. Yes, thanks for the reminder. > Thanks.