From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59626@debbugs.gnu.org
Subject: bug#59626: 29.0.50; [PATCH] comint-fontify-input: Fix field boundary issue
Date: Sun, 27 Nov 2022 13:22:50 +0100 [thread overview]
Message-ID: <8735a437tx.fsf@miha-pc> (raw)
In-Reply-To: <83y1rwpwh8.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2554 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sun, 27 Nov 2022 10:23:57 +0100
>> From: miha--- via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> Please find attached a patch which fixes a minor issue with narrowing to
>> fields during comint input fontification. The issue didn't cause any
>> visible bugs that I know of, I only noticed it during experimentation
>> with tree-sitter integration.
>
> Thanks. Do you have a recipe for demonstrating the problem which you are
> trying to fix?
Instrument comint input fontification with this diff:
diff --git a/lisp/comint.el b/lisp/comint.el
index f47e6089f2..c83da95ad2 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -4083,7 +4083,10 @@ comint--fontify-input-fontify-region
nil (lambda (beg end)
(unless (get-text-property
beg 'comint--fontify-input-inhibit-fontification)
- (font-lock-fontify-region beg end verbose)))
+ (font-lock-fontify-region beg end verbose)
+ ;; Output contents of the visible portion of the
+ ;; buffer to *Messages*.
+ (message "%S" (buffer-substring-no-properties (point-min) (point-max)))))
beg end)))
(`((jit-lock-bounds ,beg1 . ,_) . (jit-lock-bounds ,_ . ,end1))
(setq beg (min beg beg1))
Now open up an M-x shell and type "date RET" into the buffer to make
your shell output the current date and an new prompt. Press "C-p C-p
C-e" to move point to "date" and change it into "datee".
Open up *Messages* and find the following strings:
"date"
"date
"
"datee
Sun Nov 27 01:05:27 PM CET 2022
~$ "
These strings represent the context in which shell fontification was
performed on the input. The last one includes "Sun Nov 27 01:05:27 PM
CET 2022\n~$ ", which is a mistake that this patch attempts to fix.
However, in pretty much all cases, this didn't result in any user
visible inaccuracies, since shell fontification of a command rarely
depends on the contents of the lines that follow it.
>> Not that my copyright paperwork renewal is currently in progress, but I
>> hope that the number of lines in this patch fall below the threshold.
>
> Since when your previous assignment became outdated? I need to know that to
> make sure the cumulative amount of changes we already received from you
> doesn't exceed the limit.
24. of October this year.
Thanks, best regards.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2022-11-27 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 9:23 bug#59626: 29.0.50; [PATCH] comint-fontify-input: Fix field boundary issue miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-27 9:39 ` Eli Zaretskii
2022-11-27 12:22 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-27 12:27 ` Eli Zaretskii
2022-12-07 15:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735a437tx.fsf@miha-pc \
--to=bug-gnu-emacs@gnu.org \
--cc=59626@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=miha@kamnitnik.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).