From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 15 Dec 2022 12:07:14 +0100 Message-ID: <87359hlycd.fsf@gmail.com> References: <8735budxiz.fsf@gmail.com> <87k04li5nw.fsf@gmail.com> <864jvphx4r.fsf@mail.linkov.net> <86tu3mftm0.fsf@mail.linkov.net> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <86fsdpjasd.fsf@mail.linkov.net> <86k02zjiwj.fsf@mail.linkov.net> <864ju1lt5k.fsf@mail.linkov.net> <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> <86cz8or02n.fsf@mail.linkov.net> <87sfhko3tf.fsf@gmail.com> <868rjbusog.fsf@mail.linkov.net> <87h6xylyox.fsf@gmail.com> <1d03758e-369a-c522-a91a-696243f1074f@yandex.ru> <87cz8ln5lt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25577"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 58447@debbugs.gnu.org, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 12:08:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5m5x-0006SW-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 12:08:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5m5r-00044n-Ih; Thu, 15 Dec 2022 06:08:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5m5q-00044V-65 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 06:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5m5p-00065Q-UQ for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 06:08:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5m5p-0001ud-Pe for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 06:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 11:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.16711024487339 (code B ref 58447); Thu, 15 Dec 2022 11:08:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 15 Dec 2022 11:07:28 +0000 Original-Received: from localhost ([127.0.0.1]:42816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5m5I-0001uJ-4Q for submit@debbugs.gnu.org; Thu, 15 Dec 2022 06:07:28 -0500 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:41978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5m5D-0001uA-UM for 58447@debbugs.gnu.org; Thu, 15 Dec 2022 06:07:26 -0500 Original-Received: by mail-ed1-f49.google.com with SMTP id m19so26523814edj.8 for <58447@debbugs.gnu.org>; Thu, 15 Dec 2022 03:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AX8w1BFySbtVcXObsoq5FzruIPr1QEt1QiemAWOU27g=; b=oZfbBxYfRyIf9wQGKfGHCWbUKLob/zV4/r0yZWeC5UJlS2XEbJzxHbBSfQdmR5lkVL A44mSfjsQA6MRgT8ZDv86NXzgkcwmWRxQYv+JBy669kNN8g8VSMR8CeUUaQpMZFS7mVx Nee+j4D+t/SimXKTr9aCS4BRqElg+2ftazH86717/b+YSA4teZbzgZFskh6EtqqGvTH5 xA8TYJnYn4Gy/ZjhV8yGar+4d4s0Nr68ZfGjFrmZ83iycmIgtUvguzp+zJRK7Q1xM81j UTo3o6Zudz0SmNxktPco2TaeufRxjOd1+IJ83Dwxvq/wN5kXl8uvjyqQ1E3QcS7rS667 d0Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AX8w1BFySbtVcXObsoq5FzruIPr1QEt1QiemAWOU27g=; b=gUnlyw8i+Gmr6A20X07FM34+nMIxHkhgw9D6X+QhMoFC31+rWpOJzoW0LMGmBJXsMl QW9Crmok30xwZ5mzEUpgZ/mxDKXrq7kbceeQGtpit/VIrTfNAwP6v9mexSU6m8m+va0X dC3TyskCdIYIGDRbFrXcyobCHtpLi2L7TElOQR0YXAdFlxMIwZRnpRy1YKLBnpeN9o9h DrFLfGbAtXbWccdbEe3tYe8cBY8sjeCNlPmNyYz2aFpZo7xvSpgJznVTFI4wDj5es0++ f1rX0Rii44SXwRE7WQmVAfj61vmUwYU5bQPbB7j6EN0veYEroDvFUT9FS2t3FaVSknWT I5fg== X-Gm-Message-State: ANoB5pmkhKyPKUkAZNqAWDOKW01turHemPtyJde9tij5dl5Ifrr9PLJO KqQi1QoWlWH6WuYoFZLWwFI= X-Google-Smtp-Source: AA0mqf5Zl4TGT9fJOI0G48AiRzy+zjM9DpNi7k3nkX6K+dg4AAPkRd4+HBmdsktgJgZqUmK4yT7lKw== X-Received: by 2002:a05:6402:35d1:b0:46c:fabc:5897 with SMTP id z17-20020a05640235d100b0046cfabc5897mr31431251edc.7.1671102436726; Thu, 15 Dec 2022 03:07:16 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::ea0f]) by smtp.gmail.com with ESMTPSA id c2-20020a17090618a200b007c10bb5b4b8sm6955507ejf.224.2022.12.15.03.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 03:07:15 -0800 (PST) In-Reply-To: (Dmitry Gutov's message of "Thu, 15 Dec 2022 01:04:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251071 Archived-At: On Thu, 15 Dec 2022 at 01:04, Dmitry Gutov wrote: > We're probably talking about the same thing, if the filtering is going > to use the list of files from project-files, rather than > file-exists-p. In either case, the user could actually input a > non-existent file (or file not in the completion table) which would > fail that test. But they'll hopefully hit C-x C-s soon after. My suggestion was not to filer based on project-files, but rather simply by file name prefixes. Which, if I read correctly, is exactly what your patch v2 does. > The patches could be combined, but v1 seems to be too invasive for > emacs-29, yet v2 could be just small enough to be considered > "bugfix-only". > > So, what does everyone think about the latter? > > If people agree that the v2 patch is an improvement, we can check it > in and leave project-local histories until later. In fact I think v2 already is a completely satisfactory implementation the project-local file history feature.