From: Mickey Petersen <mickey@masteringemacs.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60880@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
Subject: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
Date: Fri, 20 Jan 2023 09:08:09 +0000 [thread overview]
Message-ID: <873585fu4o.fsf@masteringemacs.org> (raw)
In-Reply-To: <83ilh1ofiu.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 60880@debbugs.gnu.org
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 19 Jan 2023 14:30:46 -0800
>>
>>
>> Mickey Petersen <mickey@masteringemacs.org> writes:
>>
>> > A medley of issues here:
>> >
>> > 1. Executing `treesit-explore-mode' on a buffer with no valid grammar
>> > support causes the minor mode (and playground buffer) to stick around and "load" anyway.
>> >
>> > 2. Bailing out of the grammar prompt does not, in actual fact, stop
>> > explore mode from proceeding. Instead it creates an empty buffer and
>> > it still engages the minor mode.
>> >
>> > 3. Killing the playground buffer does not remove the explore mode buffer.
>> >
>> > 4. treesit-explore-mode is stored against a buffer during
>> > `desktop-save' (and subsequently read with) `desktop-read'. Thus
>> > broken buffers or files inherit the explore mode. This is especially
>> > pernicious due to #1, #2, and #3.
>>
>> Ok, I fixed those problems. Now if the language is not available,
>> treesit-explore-mode raises an error instead of continuing, desktop-save
>> will not save the explorer buffer, and killing the source buffer also
>> kills the explorer buffer.
>
> I don't think the desktop-save part is correct: the test should be at
> desktop-read time, not at desktop-save time. Because the fact we had
> the language available when we saved the desktop doesn't guarantee we
> will have it available when restoring that desktop: it could be in a
> different build of Emacs or even on a different machine.
>
> I'm not sure I understand the problem which desktop-read has when
> restoring desktop with buffers in treesit-explore-mode, but if the
> problems are more than just warning messages, then desktop-read should
> detect these problems, emit an echo-area message, and refrain from
> restoring the mode. Like it does with buffers that visited files
> which are no longer there, for example.
Another problem is that it stops the loading process, pending manual
selection of the grammar you want explore mode to use. It would be
nice if we saved the previous choice -- when you made the choice to
begin with -- so that, upon read, it does not have to ask.
That way the desktop read experience is not interrupted by prompts
during Emacs startup.
prev parent reply other threads:[~2023-01-20 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 13:44 bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly Mickey Petersen
2023-01-19 22:30 ` Yuan Fu
2023-01-20 7:02 ` Eli Zaretskii
2023-01-20 7:59 ` Juri Linkov
2023-01-20 13:13 ` Eli Zaretskii
2023-01-20 9:08 ` Mickey Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873585fu4o.fsf@masteringemacs.org \
--to=mickey@masteringemacs.org \
--cc=60880@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).