From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#61395: 28.2; bug-reference warning seems incorrect Date: Fri, 10 Feb 2023 18:21:09 +0100 Message-ID: <87357dxvax.fsf@gnu.org> References: <87pmailkqw.fsf@tromey.com> <838rh6kjua.fsf@gnu.org> <877cwplg1s.fsf@tcd.ie> <871qmx7bvv.fsf@gnu.org> <87h6vtjxjp.fsf@tromey.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26954"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.19; emacs 30.0.50 Cc: Basil Contovounesios , Eli Zaretskii , 61395@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 10 18:53:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQXaR-0006pp-6m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Feb 2023 18:53:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQXa8-0000C3-Ho; Fri, 10 Feb 2023 12:53:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQXa4-0000Bi-0m for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 12:53:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQXa2-0006uM-Aw for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 12:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQXa1-0002yd-W0 for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 12:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Feb 2023 17:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61395 X-GNU-PR-Package: emacs Original-Received: via spool by 61395-submit@debbugs.gnu.org id=B61395.167605154211388 (code B ref 61395); Fri, 10 Feb 2023 17:53:01 +0000 Original-Received: (at 61395) by debbugs.gnu.org; 10 Feb 2023 17:52:22 +0000 Original-Received: from localhost ([127.0.0.1]:38042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQXZN-0002xb-Sx for submit@debbugs.gnu.org; Fri, 10 Feb 2023 12:52:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQXZJ-0002xJ-1u for 61395@debbugs.gnu.org; Fri, 10 Feb 2023 12:52:20 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQXZC-0006ny-IF; Fri, 10 Feb 2023 12:52:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=11psKIPjquqMFYfi2TIddy2xOQjdCAwVenlXawqDrhA=; b=iLAT732QyOgcPg efs24w4UKGEG3OPazWeU6tNdBJ4GVCme2LB9OhM6V8s3VY/D+O6baRbiXNnKasjdxOfp2ED6n5/uD 30CV5/CrK1chrTXuNAkhVkob20PRvXxbEkv0QepGThAdgzhcM2C9KqZ43pGDxcRfN1Ghb9KbXJJJq w/Ouct0ZQM5F3wfMGiudREPwvZGew84EC7n2NpVn8Av0wa4I0sRLYg++98A1CMyrj3RDnMhIBhqh1 pciS5zOl+7Od0lUNXxajqQ5kTeQ+IP4Fm6Zvh3xMscnWqbLhm5UppcdUysZ9u4vqA+G9A4nwGoY3w /fLiHQENkHHmjJiHjRpg==; Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQXZC-0007dA-4r; Fri, 10 Feb 2023 12:52:10 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailauth.nyi.internal (Postfix) with ESMTP id C135C27C005A; Fri, 10 Feb 2023 12:52:09 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 10 Feb 2023 12:52:09 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehhedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepvfgr shhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrh hnpefgtedtudeivdfhfffhfefhvefhuedvheejjeefleffheekffeutdfhgfejiefhgeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorh hnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieef hedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Feb 2023 12:52:08 -0500 (EST) In-reply-to: <87h6vtjxjp.fsf@tromey.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255297 Archived-At: Tom Tromey writes: >> I'll have a look later today! > > It seems difficult to reproduce. I can't do it reliably. > > My co-worker K=C3=A9vin suggested that perhaps the problem is here, in > bug-reference-fontify: > > (while (and (< (point) end-line) > (re-search-forward bug-reference-bug-regexp end-line 'm= ove)) > (when (or (not bug-reference-prog-mode) > ;; This tests for both comment and string syntax. > (nth 8 (syntax-ppss))) > > ... with the question being whether the call to syntax-ppss needs to > be wrapped in save-match-data. Hm, I've tried somthing like (while (re-search-forward "\\(NILP\\)\\(.*\\)$" nil t) (syntax-ppss-flush-cache (point-min)) (let ((md (match-data))) (syntax-ppss) (unless (equal md (match-data)) (error "Match-data clobbered: %S %S" md (match-data))))) many times in buffer.c but `syntax-ppss' doesn't seem to clobber match-data. If you can reproduce the issue, try changing `bug-reference--overlay-bounds' so that the check (member bug-reference-bug-regexp bug-reference--nonconforming-regexps) isn't performed inhibiting the warning for this regexp and add some more info to the warning message like (match-string N) for N in 0..9. If the match-data isn't about matches of `bug-reference-bug-regexp', we are on the right track, i.e., someone clobbers our match data. Bye, Tassilo