From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function Date: Sat, 18 Feb 2023 23:20:00 +0100 Message-ID: <87357262gf.fsf@thornhill.no> References: <87h6vo1ph6.fsf@thornhill.no> <87pmacjl4l.fsf@betli.tmit.bme.hu> <74E0BF9F-42AF-4578-9681-D0FB936081AE@thornhill.no> <87v8k3st80.fsf@gmail.com> <875yc3qf8n.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39406"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Felician Nemeth , 61506@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 23:21:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTVa0-000A13-Ke for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 23:21:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTVZo-0006li-E8; Sat, 18 Feb 2023 17:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTVZm-0006lF-OG for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 17:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTVZm-0000Nw-4j for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 17:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTVZm-0004Ny-0Z for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 17:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 22:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61506 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61506-submit@debbugs.gnu.org id=B61506.167675881116748 (code B ref 61506); Sat, 18 Feb 2023 22:21:01 +0000 Original-Received: (at 61506) by debbugs.gnu.org; 18 Feb 2023 22:20:11 +0000 Original-Received: from localhost ([127.0.0.1]:45125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTVYt-0004Lz-Ck for submit@debbugs.gnu.org; Sat, 18 Feb 2023 17:20:11 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]:56396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTVYr-0004Lh-DF for 61506@debbugs.gnu.org; Sat, 18 Feb 2023 17:20:05 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1676758802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KXlBXxstuZGbkT+A8+a++8Ej5dE7CBfaB2O4h57WGrc=; b=TeLinec1vZP3vXn3yFCwJ2w9+edbGBOG4o2aKZ7GJBM4/bVEgLRJWPixCE5LgP+J5IWZ3B Fu3DFokUZz4o+T0bpZFPGPi/koN1/L8q70yCWochQzgaWQKV42PSASZ3prYOedXXTZQPdN uQC0wmVKPtGizqj85gmTByMOWATdvPKKWw4L7wc9UU0Fa47ZyV33aaRrGNe9OTc/5P0CXG t+JD5iyeDobgwgk7b6xp2JaBzZMl+JFF7hYyk+RSir8ZawOUNAwrgR0VOFw9yF42txflgC dvSNrVcrW+OfsKwQDNSl90TEabyu74Nvd7WELa7Ha8FEiAewwOP86ppRnEz8SQ== In-Reply-To: <875yc3qf8n.fsf@thornhill.no> (Theodor Thornhill's message of "Wed, 15 Feb 2023 13:34:32 +0100") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256001 Archived-At: Ping :-) >> >> FWIW I don't see this as a good enough reason in itself. If there is >> little to no discernible benefit, supporting esoteric features can >> become code bloat that makes maintenance of more important features >> difficult. There is a fair amount of junk in the LSP standard, or >> simply stuff that doesn't make as much sense in Emacs as it does in >> other editors. >> > > Yeah, I agree. However, this should make sense in Emacs too, no? > >> Regardless, I'm not opposed to this feature if there's a simple enough >> patch. But we should weigh pros and cons -- and Felici=C3=A1n's request= to >> measure the pros is quite reasonable. > > The patch is simple enough, it could just be its own function, to be > executed. Then it's a one-liner in the exit-function > >> >> (Not to mention that a smart enough server can already derive these >> smarts from the evolution of the LSP document's contents as reported by >> the client.) >> > > Maybe - I don't think that's reason enough to dismiss the command > argument outright, though. > >> Jo=C3=A3o > > Theo