From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Sun, 05 Mar 2023 13:23:59 +0100 Message-ID: <87356jfktc.fsf@gmx.de> References: <87y1ootw2t.fsf@gmail.com> <87a613f0b7.fsf@gmx.de> <87r0udvmzr.fsf@gmx.de> <878rglxrzm.fsf@gmail.com> <87cz5wmjbx.fsf@gmx.de> <87h6v8f7u9.fsf@gmail.com> <87o7pflfcd.fsf@gmx.de> <87wn43e9ht.fsf@gmail.com> <874jr6oont.fsf@gmx.de> <87sfeqd4zi.fsf@gmail.com> <877cw1swjm.fsf@gmx.de> <87k0016dgo.fsf@gmx.de> <1458446553.50372.1677606917251@office.mailbox.org> <87ilfkh89k.fsf@gmail.com> <87y1ofct83.fsf@gmx.de> <87356n8kja.fsf@gmail.com> <877cvvfnp6.fsf@gmx.de> <54377687.213790.1678016749459@office.mailbox.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2893"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 61350@debbugs.gnu.org To: Thomas Koch Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 05 13:25:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYnQS-0000a1-9E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Mar 2023 13:25:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYnQG-0006ax-0I; Sun, 05 Mar 2023 07:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYnQE-0006ap-Tp for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 07:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYnQE-0003O4-8x for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 07:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYnQD-0004mC-L2 for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 07:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Mar 2023 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167801904918284 (code B ref 61350); Sun, 05 Mar 2023 12:25:01 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 5 Mar 2023 12:24:09 +0000 Original-Received: from localhost ([127.0.0.1]:38646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYnPM-0004kq-V4 for submit@debbugs.gnu.org; Sun, 05 Mar 2023 07:24:09 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:51943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYnPK-0004kI-UZ for 61350@debbugs.gnu.org; Sun, 05 Mar 2023 07:24:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1678019040; i=michael.albinus@gmx.de; bh=gS0WNhoN2sBZzXHHp6uMP87X5y0udu6xYvcSGxTBpzA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=KCs0t87APzuv9dIrwag7nVza2ioApLXyuq4+M+ctVgRrcimnquoJ2u7GRGr4fvIeS M32HKt/fO0LjNr7h7y86snLpVUkDaAxycNkuPHDcx0IBYV1gJU7PbVxdQNoEN4aB1T eoJEVYAB5FW7J4Hki2fsPAKj4Vw1ThUek+cgdhRlFacvMKSEsKZ0HR9lGYfob0rV3U 6E/WeN1oRyu9nW22AIYph1PAYfDteHDbDqL7CfWJA+QF6PwMZHOpev1enIRt8xFsHF eTz+gCJOhVsBJhoUqaKE63eon6Q5RjjrpfgPBSV7PN8V901G2dDnG+zT21nxdbGX8V 824lyt2dkaWDQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.22]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M8QWG-1pdDG40l5U-004Vya; Sun, 05 Mar 2023 13:24:00 +0100 In-Reply-To: <54377687.213790.1678016749459@office.mailbox.org> (Thomas Koch's message of "Sun, 5 Mar 2023 13:45:49 +0200 (EET)") X-Provags-ID: V03:K1:lMH38uIRpvkwejSqIQSNF5yuU9tihI8C3DHfxPxFIrFEOwk4Cmy 670vj//yZ7gOHDKSnjobZtvxtgggO0hyvNtLJZsVz60uS1zMQu3nNsJA5im6uZQNVHtyYiu 56R6nPws77Y+8hKfbJbLyW90ITAF1iwB0QxgFY5YGkQysqjO+TC2/1ZJ9KVax4wI0Uy/gKE JAfcLeIisB/N/kuSyo/kg== UI-OutboundReport: notjunk:1;M01:P0:UvVkMBxVuew=;ZSEf6P5daJFQowcVJjmjTXPiOkH 3bOUu3jXMZZZpdWq7QuIDYGqqJpadI9v+raYEXULIY/WuRmYEzpKis8szbvpmjoIvAWvee2C9 Q2pMmnaD6UK21rrejIqWtc2919d15X8QTlvP8DcPKHpnHhowLG2IDaQo5+ojI05pOq7iQTXGg igj1rcw4Zu2IDsS75HJXmSHp/qpHcEEdqmKbeac8dbwGJ1pXf14Cg+t4tDS6VfT6yrrKlCgJR 3JYN1xJXQk2r5d1wd1SUppD/rz4v9YLMwfgarS9huwiWQIK6JWsLlbiJW8J4TzILfghxjsRiB mCb4Uvw5d+0Gyg+dRnHsCOugR0o1revd8ISN6oDhg0h3f8G7igcGSCERfKhL3yayaBWjdrVM5 KE5f9iF+7FKWi3chzgYAwP2Wyl7+ZBhizlcxqnkIWw7DCN6FxSYQ8CiJqKk7Rt8c3BBZwCIi5 obIvl37xULSZuiCSi24QZBgGBqP24mG7EjWV8AfTXeKvbrwJteO76P9q41k1CjxpMkWoBBJvS qwxBohoM7faw/Je8mNA8Mml6VPQGkDFb5UiSJLzgJhIJn2DrsnTkAJWU4MVuSDbxDhrXnE+X/ hlYHbcRfeMWgI+6xMKskNdZ/3tMGAQx8v0ac22QklB8OSxIQo+R8nReWJNc3BPoVW248Rhasa m0aF33SXk/VR6j8QiCE+ji5BnwU7amlAhzFnDSrVJoyWUKz8ROH+LGXW/QuMPg4UsBMTZUljR KTAWRaqIc5Ly+Bgps539agO2GztKWKPDmJQ/LFXNlAyQCHMBJcP6l4dqsWpvCIoBfGDgVNAN X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257349 Archived-At: Thomas Koch writes: Hi Thomas, > Thanks Michael for digging! This is exactly what I also think happens. > > However my conclusion is different. I consider the root-cause to be the = use of JUST-THIS-ONE in tramps call to accept-process-output. Please check= my comment to bug > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12145 I've seen this. And yes, we shall fix the problems described there. > Applying a workaround (adding extra code to surpress ControlMaster > with a newly introduced hook) would increase the complexity and thus > brittleness. I believe the right thing to do is remove JUST-THIS-ONE > in Tramp and fix find-name-dired and any other place that's broken. I won't change Tramp this way in Emacs 29. It is in feature freeze, closed to pretest. I cannot risk to destabilize it. And as we see with the find-name-dired case, there might be collateral damages if we change Tramp this way. And I don't believe, that adding a hook in Eglot is worse than what we have now, where Eglot manipulates Tramp data. Whenever we need to change Tramp in this area, it wouldn't apply in Egloot. A hook is much better suited, and we use the very same technique already with compile.el. > As a practical roadmap you could add an option to Tramp to disable > JUST-THIS-ONE and recommend its use. Later the options default could > be toggled. Eventually the option can go away. Might be applicable in the master branch. But first we need much more checks that it doesn't break something else. I'm always uncomfortable to change Tramp such a way that other packages could be broken. Letting Tramp accept process output for all existing processes doesn't seem to be the right thing to me, although I admit that it seems to fix the specific problem we're discussing here. > Eglot could emit a warning if it sees the above tramp option not being > used. (... could lead to Emacs hanging. Are you sure to continue > (y/n)?) No check in Eglot. A hint in the manual would be sufficient I believe. Best regards, Michael.