From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#62426: [PATCH] eshell: Add 'rgrep' builtin. Date: Sat, 25 Mar 2023 10:22:07 -0700 Message-ID: <87355syce8.fsf@athena.silentflame.com> References: <87jzz5eucl.fsf@mailbox.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10935"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Antero Mejr , 62426@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 18:23:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg7c5-0002UT-JM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 18:23:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg7be-0007OZ-De; Sat, 25 Mar 2023 13:23:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg7bc-0007MY-Cm for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 13:23:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg7bc-0000WK-4c for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 13:23:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg7ba-0007Te-04 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 13:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62426-submit@debbugs.gnu.org id=B62426.167976493628672 (code B ref 62426); Sat, 25 Mar 2023 17:23:01 +0000 Original-Received: (at 62426) by debbugs.gnu.org; 25 Mar 2023 17:22:16 +0000 Original-Received: from localhost ([127.0.0.1]:43385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg7aq-0007SN-BU for submit@debbugs.gnu.org; Sat, 25 Mar 2023 13:22:16 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg7ao-0007S8-1u for 62426@debbugs.gnu.org; Sat, 25 Mar 2023 13:22:15 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B879B5C013E; Sat, 25 Mar 2023 13:22:08 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 25 Mar 2023 13:22:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1679764928; x= 1679851328; bh=3Sd3xObocIGtl4OGXrWzAqy3A0sDjSYNIs+BAaFeKsA=; b=j 5STbt0RE4zee61qTEg86y8HDDzqHm9e1VSlwMknWKxnr2U+xzqq0SwDP5E4x061p sv3tNluiu4rf3/u2thwOQ5KxptKtTwtSh54J/GoKLN6Ev8BSMfZY2TlhD6z785kS fQbXQ4PZVl68QAdfvr3pxDue2YoPJce4g4O62HLtM/KL0kwSjdmt3vSJJtAc8FeG Jg/bM6N/LHr2mEhi4T+DDfObAQDNphMdm98gJLOCoE2Ru05N1pud8ygKzxzqMRpM 6y7PWSFqiPKXRAHeI/uYFsRrwdBdyPxd5jsD4gQakyyedvKjYvYIKs5iBSAA4Sp+ 6Wm3cMZ2rmzw8N8yN2mdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679764928; x=1679851328; bh=3Sd3xObocIGtl 4OGXrWzAqy3A0sDjSYNIs+BAaFeKsA=; b=U2r1PFbu3T+WhgIeAdsPgX6jG0YSc 7Qw4l1tfPcCeR30TPne5M/kw0GzYedIywmVhKYGBfiT/N2CZCG/NRQT24qGHugxs LEaxp66Q6pbmcSZZGbTJSBpMDRWT9Vc5oFO174bRPI4/sIgrOVQM7hnbwq2rb29v EuhHk54YmD+/3GzTLgfSkmTYR7EtpJ9M/aUnUDCmJJJxOnPCCOAlYjorhTYYIY0G 3xED2eQUfPY7jmyfcFb74M5ykY6sY4CXfRHSpP3xDDJRDeBCl0J4yNDPM1hbTSH8 AH/yYEKU2vv/AMpA6IStnW6cZ4uue5O5pEqx+U5wMzJ6NRAOoI3ops/fg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegkedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Mar 2023 13:22:08 -0400 (EDT) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id 2AFE21B5962; Sat, 25 Mar 2023 17:22:07 +0000 (UTC) In-Reply-To: (Jim Porter's message of "Fri, 24 Mar 2023 17:04:56 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258605 Archived-At: Hello, On Fri 24 Mar 2023 at 05:04PM -07, Jim Porter wrote: > On 3/24/2023 2:02 PM, Antero Mejr via Bug reports for GNU Emacs, the Swiss > army knife of text editors wrote: >> eshell has builtins for agrep/egrep/fgrep that use the Emacs grep >> feature, but rgrep is not included so it behaves differently. This patch >> adds the rgrep builtin. > > Thanks, I think it would make sense to add an rgrep built-in to > Eshell. However, I'm not sure if this is the best way for it to > work. Personally, I'd have expected this to use the 'rgrep' function in Emacs > Lisp (which uses find + grep to do its job). That's a bit different from > /usr/bin/rgrep, but I find it a lot more useful since it ignores > "uninteresting" files by default. For example, 'M-x rgrep' in a Git repo > ignores the .git/ subdir, but /usr/bin/rgrep includes that subdir. Hence, I'd > almost always prefer Emacs' version of rgrep. > > That said, it might be a bit strange for Eshell's rgrep to work this way, when > Eshell's agrep/egrep/fgrep work like the external versions. This seems like a > tricky case... Tricky indeed. Here is an attempt: Normally with M-x rgrep one benefits from how Emacs prompts you separately for the parameters to the function, right? In particular, you get completion for the second and third parameters. Given that, you're unlikely to want to type 'rgrep foo bar baz' into Eshell, and not benefit from that completion, when you could just type M-x rgrep in the same buffer, and benefit from it. Given this, I suggest rgrep in Eshell should be /usr/bin/rgrep. -- Sean Whitton