unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cohen@bu.edu, 63842@debbugs.gnu.org, cohen@andy.bu.edu
Subject: bug#63842: 30.0.50; Slow 'gnus-summary-refer-thread'
Date: Fri, 16 Jun 2023 12:36:48 +0200	[thread overview]
Message-ID: <87352rr8vz.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <831qiduv5f.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Jun 2023 08:55:24 +0300")

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Hi,

So here is the crux of this issue.  When using
'gnus-summary-refer-thread' in a nnml group, Emacs ends up calling
'gnus-get-newsgroup-headers-xover' (via 'gnus-fetch-headers').  AFAIU in
this function when 'gnus-read-all-available-headers' is t, Emacs will
parse *all* of the " *nntp*" buffer content.  In my case, this buffer is
quite big (about 50k lines and 23MiB) hence the slowness.

BTW, I also have examples where 'gnus-summary-refer-thread' gives me
some false positives (eg., not the same thread but part of the subject
matching)

I don't know how to proceed except from unsetting
'gnus-read-all-available-headers' for nnml backends (see attached
patch).
-- 
Manuel Giraud

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Do-not-read-all-headers-for-nnml-groups.patch --]
[-- Type: text/x-patch, Size: 917 bytes --]

From 170cc2f96ebc606c25d85e345f9f9196fe6a7f33 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 16 Jun 2023 12:20:32 +0200
Subject: [PATCH] Do not read all headers for nnml groups

---
 lisp/gnus/gnus-sum.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 4effaa981ec..14da8735e88 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -9029,7 +9029,8 @@ gnus-summary-refer-thread
          (id (mail-header-id header))
          (gnus-inhibit-demon t)
          (gnus-summary-ignore-duplicates t)
-         (gnus-read-all-available-headers t)
+         (gnus-read-all-available-headers
+          (not (eq (car (gnus-find-method-for-group group)) 'nnml)))
          (gnus-refer-thread-use-search
           (if (or (null limit) (numberp limit))
               gnus-refer-thread-use-search
-- 
2.40.0


  parent reply	other threads:[~2023-06-16 10:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 13:17 bug#63842: 30.0.50; Slow 'gnus-summary-refer-thread' Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-02 15:26 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-02 23:32 ` Andrew Cohen
2023-06-03 13:23   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-15  5:55     ` Eli Zaretskii
2023-06-15 17:59       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-16 10:36       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-06-16 23:37         ` Andrew Cohen
2023-06-17 22:16           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-18  0:45             ` Andrew Cohen
2023-06-18 20:57               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-19 12:58                 ` Andrew Cohen
2023-06-19 15:44                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 10:00                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-01  8:25                       ` Eli Zaretskii
     [not found]                         ` <87edlsav34.fsf@ust.hk>
2023-07-01  9:49                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87352rr8vz.fsf@ledu-giraud.fr \
    --to=bug-gnu-emacs@gnu.org \
    --cc=63842@debbugs.gnu.org \
    --cc=cohen@andy.bu.edu \
    --cc=cohen@bu.edu \
    --cc=eliz@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).